From: Akseli Lahtinen <akselmo@akselmo.dev>
Date: Mon, 3 Mar 2025 12:02:20 +0000 (+0200)
Subject: dolphinstatusbar: Fix negative value warnings with small statusbar fixedwidth
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/d01d6ca476ce89cab3c3cc2ee50d242c74789cb4?ds=inline

dolphinstatusbar: Fix negative value warnings with small statusbar fixedwidth

During splitview animations the parentWidget()->width could be lower
than scrollbarWidth. If it goes to negatives it causes a lot of
warnings.

Make sure to bound the value between 0 and parentWidget()->width() so
that it can't go into negatives.
---

diff --git a/src/statusbar/dolphinstatusbar.cpp b/src/statusbar/dolphinstatusbar.cpp
index e9773cb69..4d76afcbe 100644
--- a/src/statusbar/dolphinstatusbar.cpp
+++ b/src/statusbar/dolphinstatusbar.cpp
@@ -285,7 +285,8 @@ void DolphinStatusBar::updateWidthToContent()
         // Make sure minimum height takes clipping into account.
         setMinimumHeight(m_label->height() + clippingAmount());
         const int scrollbarWidth = style()->pixelMetric(QStyle::PM_ScrollBarExtent, &opt, this);
-        const int maximumViewWidth = parentWidget()->width() - scrollbarWidth;
+        // Make sure maximumViewWidth does not go below 0.
+        const int maximumViewWidth = qMax(0, parentWidget()->width() - scrollbarWidth);
         if (m_stopButton->isVisible() || m_progressTextLabel->isVisible() || m_progressBar->isVisible()) {
             // Use maximum width when interactable elements are shown, to keep them
             // from "jumping around" when user tries to interact with them.