From: Ahmad Samir <a.samirh78@gmail.com>
Date: Sun, 20 Sep 2020 16:38:29 +0000 (+0200)
Subject: Fix mouse back/forward buttons
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/d0c71a1435bc9d67475c5525c3641bd4a13c61f0

Fix mouse back/forward buttons

We need to emit mouseButtonPressed (now in the onPress method) before the
check needed to not select items on back/foward mouse button press events.
---

diff --git a/src/kitemviews/kitemlistcontroller.cpp b/src/kitemviews/kitemlistcontroller.cpp
index 650bf6286..1733eeab5 100644
--- a/src/kitemviews/kitemlistcontroller.cpp
+++ b/src/kitemviews/kitemlistcontroller.cpp
@@ -550,17 +550,19 @@ bool KItemListController::mousePressEvent(QGraphicsSceneMouseEvent* event, const
     m_pressedMousePos = transform.map(event->pos());
     m_pressedIndex = m_view->itemAt(m_pressedMousePos);
 
-    if (event->buttons() & (Qt::BackButton | Qt::ForwardButton)) {
-        // Do not select items when clicking the back/forward buttons, see
-        // https://bugs.kde.org/show_bug.cgi?id=327412.
-        return true;
-    }
-
     const Qt::MouseButtons buttons = event->buttons();
+
     if (!onPress(event->screenPos(), event->pos(), event->modifiers(), buttons)) {
         startRubberBand();
         return false;
     }
+
+    if (buttons & (Qt::BackButton | Qt::ForwardButton)) {
+        // Do not select items when clicking the back/forward buttons, see
+        // https://bugs.kde.org/show_bug.cgi?id=327412.
+        return true;
+    }
+
     return true;
 }