From: Kai Uwe Broulik <kde@privat.broulik.de>
Date: Thu, 20 Jan 2022 11:38:47 +0000 (+0100)
Subject: [Tab Bar] Accept proposed action only ontop of a tab
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/d8322161594cfa967ae80ea7b37f2e04393b0f1a

[Tab Bar] Accept proposed action only ontop of a tab

You cannot drop a file/folder onto the empty area of the tab bar,
so show the appropriate "not allowed" cursor.
---

diff --git a/src/dolphintabbar.cpp b/src/dolphintabbar.cpp
index 67a61b031..4c1d9e44a 100644
--- a/src/dolphintabbar.cpp
+++ b/src/dolphintabbar.cpp
@@ -36,7 +36,13 @@ void DolphinTabBar::dragEnterEvent(QDragEnterEvent* event)
     const int index = tabAt(event->pos());
 
     if (mimeData->hasUrls()) {
-        event->acceptProposedAction();
+        if (index >= 0) {
+            event->acceptProposedAction();
+        } else {
+            event->setDropAction(Qt::IgnoreAction);
+            // Still need to accept it to receive dragMoveEvent
+            event->accept();
+        }
         updateAutoActivationTimer(index);
     }
 
@@ -56,6 +62,11 @@ void DolphinTabBar::dragMoveEvent(QDragMoveEvent* event)
     const int index = tabAt(event->pos());
 
     if (mimeData->hasUrls()) {
+        if (index >= 0) {
+            event->acceptProposedAction();
+        } else {
+            event->setDropAction(Qt::IgnoreAction);
+        }
         updateAutoActivationTimer(index);
     }