From: Kai Uwe Broulik <kde@privat.broulik.de>
Date: Tue, 27 Jun 2017 12:03:31 +0000 (+0200)
Subject: [Places Panel] Disallow editing devices
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/da42a9eefb7c28ca346f1be2817f1f36ddf9bb6e

[Places Panel] Disallow editing devices

I introduced this bug when I changed the layout of the menu.
While it would be nice if one could edit devices, it is currently not possible
and would require significant re-engineering effort in Solid.

While the "Edit" menu works just fine, changes are not persisted.

Reviewed-By: emmanuelp

Differential Revision: https://phabricator.kde.org/D6294
---

diff --git a/src/panels/places/placespanel.cpp b/src/panels/places/placespanel.cpp
index 17367b865..3c9309435 100644
--- a/src/panels/places/placespanel.cpp
+++ b/src/panels/places/placespanel.cpp
@@ -197,7 +197,9 @@ void PlacesPanel::slotItemContextMenuRequested(int index, const QPointF& pos)
         menu.addSeparator();
     }
 
-    editAction = menu.addAction(QIcon::fromTheme("document-properties"), i18nc("@item:inmenu", "Edit..."));
+    if (!isDevice) {
+        editAction = menu.addAction(QIcon::fromTheme("document-properties"), i18nc("@item:inmenu", "Edit..."));
+    }
 
     QAction* removeAction = 0;
     if (!isDevice && !item->isSystemItem()) {