From: Peter Penz <peter.penz19@gmail.com>
Date: Thu, 26 Jun 2008 22:23:09 +0000 (+0000)
Subject: respect the inline-renaming setting also for the Folder Panel (= treeview)
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/f067201e9f25eddd9b62e41240e93685992dcf22?ds=inline

respect the inline-renaming setting also for the Folder Panel (= treeview)

svn path=/trunk/KDE/kdebase/apps/; revision=824946
---

diff --git a/src/treeviewcontextmenu.cpp b/src/treeviewcontextmenu.cpp
index f15ac0c6e..db2366689 100644
--- a/src/treeviewcontextmenu.cpp
+++ b/src/treeviewcontextmenu.cpp
@@ -31,7 +31,6 @@
 #include <klocale.h>
 #include <kpropertiesdialog.h>
 
-#include "renamedialog.h"
 #include "treeviewsidebarpage.h"
 
 #include <QtGui/QApplication>
@@ -152,17 +151,7 @@ void TreeViewContextMenu::paste()
 
 void TreeViewContextMenu::rename()
 {
-    KFileItemList item;
-    item.append(m_fileInfo);
-    RenameDialog dialog(m_parent, item);
-    if (dialog.exec() == QDialog::Accepted) {
-        const QString& newName = dialog.newName();
-        if (!newName.isEmpty()) {
-            KUrl newUrl = m_fileInfo.url();
-            newUrl.setFileName(newName);
-            KonqOperations::rename(m_parent, m_fileInfo.url(), newUrl);
-        }
-    }
+    m_parent->rename(m_fileInfo);
 }
 
 void TreeViewContextMenu::moveToTrash()
diff --git a/src/treeviewsidebarpage.cpp b/src/treeviewsidebarpage.cpp
index d5f5f4053..8258fbfc8 100644
--- a/src/treeviewsidebarpage.cpp
+++ b/src/treeviewsidebarpage.cpp
@@ -24,12 +24,15 @@
 #include "dolphinview.h"
 #include "dolphinsettings.h"
 #include "dolphin_folderspanelsettings.h"
+#include "dolphin_generalsettings.h"
+#include "renamedialog.h"
 #include "sidebartreeview.h"
 #include "treeviewcontextmenu.h"
 
 #include <kfileplacesmodel.h>
 #include <kdirlister.h>
 #include <kfileitem.h>
+#include <konq_operations.h>
 
 #include <QApplication>
 #include <QItemSelection>
@@ -81,6 +84,28 @@ bool TreeViewSidebarPage::showHiddenFiles() const
     return FoldersPanelSettings::showHiddenFiles();
 }
 
+
+void TreeViewSidebarPage::rename(const KFileItem& item)
+{
+    if (DolphinSettings::instance().generalSettings()->renameInline()) {
+        const QModelIndex dirIndex = m_dolphinModel->indexForItem(item);
+        const QModelIndex proxyIndex = m_proxyModel->mapFromSource(dirIndex);
+        m_treeView->edit(proxyIndex);
+    } else {
+        KFileItemList items;
+        items.append(item);
+        RenameDialog dialog(this, items);
+        if (dialog.exec() == QDialog::Accepted) {
+            const QString& newName = dialog.newName();
+            if (!newName.isEmpty()) {
+                KUrl newUrl = item.url();
+                newUrl.setFileName(newName);
+                KonqOperations::rename(this, item.url(), newUrl);
+            }
+        }
+    }
+}
+
 void TreeViewSidebarPage::setUrl(const KUrl& url)
 {
     if (!url.isValid() || (url == SidebarPage::url())) {
diff --git a/src/treeviewsidebarpage.h b/src/treeviewsidebarpage.h
index ba820ff20..6bc0ae6c3 100644
--- a/src/treeviewsidebarpage.h
+++ b/src/treeviewsidebarpage.h
@@ -51,6 +51,8 @@ public:
     void setShowHiddenFiles(bool show);
     bool showHiddenFiles() const;
 
+    void rename(const KFileItem& item);
+
 signals:
     /**
      * Is emitted if the an URL change is requested.