From: Méven Car Date: Sat, 9 Mar 2024 12:01:42 +0000 (+0100) Subject: KItemListController::onPress: remove unused screenPos argument X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/f2c78d3e989e126cfaf5b63b02377c888e94e56e?ds=sidebyside KItemListController::onPress: remove unused screenPos argument NO_CHANGELOG --- diff --git a/src/kitemviews/kitemlistcontroller.cpp b/src/kitemviews/kitemlistcontroller.cpp index 2a0641aa1..ecb91dd8a 100644 --- a/src/kitemviews/kitemlistcontroller.cpp +++ b/src/kitemviews/kitemlistcontroller.cpp @@ -589,7 +589,7 @@ bool KItemListController::mousePressEvent(QGraphicsSceneMouseEvent *event, const const Qt::MouseButtons buttons = event->buttons(); - if (!onPress(event->screenPos(), event->pos(), event->modifiers(), buttons)) { + if (!onPress(event->pos(), event->modifiers(), buttons)) { startRubberBand(); return false; } @@ -1103,7 +1103,7 @@ void KItemListController::tapTriggered(QTapGesture *tap, const QTransform &trans if (m_dragActionOrRightClick) { m_dragActionOrRightClick = false; } else { - onPress(m_pressedMouseGlobalPos.toPoint(), tap->position().toPoint(), Qt::NoModifier, Qt::LeftButton); + onPress(tap->position().toPoint(), Qt::NoModifier, Qt::LeftButton); onRelease(transform.map(tap->position()), Qt::NoModifier, Qt::LeftButton, true); } m_isTouchEvent = false; @@ -1218,7 +1218,7 @@ void KItemListController::twoFingerTapTriggered(QGestureEvent *event, const QTra const QPointF pressedMousePos = transform.map(twoTap->pos()); m_pressedIndex = m_view->itemAt(pressedMousePos); if (m_pressedIndex.has_value()) { - onPress(twoTap->screenPos().toPoint(), twoTap->pos().toPoint(), Qt::ControlModifier, Qt::LeftButton); + onPress(twoTap->pos().toPoint(), Qt::ControlModifier, Qt::LeftButton); onRelease(transform.map(twoTap->pos()), Qt::ControlModifier, Qt::LeftButton, false); } } @@ -1576,7 +1576,7 @@ void KItemListController::updateExtendedSelectionRegion() } } -bool KItemListController::onPress(const QPoint &screenPos, const QPointF &pos, const Qt::KeyboardModifiers modifiers, const Qt::MouseButtons buttons) +bool KItemListController::onPress(const QPointF &pos, const Qt::KeyboardModifiers modifiers, const Qt::MouseButtons buttons) { Q_EMIT mouseButtonPressed(m_pressedIndex.value_or(-1), buttons); diff --git a/src/kitemviews/kitemlistcontroller.h b/src/kitemviews/kitemlistcontroller.h index 9c3a003d3..ccfc76267 100644 --- a/src/kitemviews/kitemlistcontroller.h +++ b/src/kitemviews/kitemlistcontroller.h @@ -331,7 +331,7 @@ private: void pinchTriggered(QGestureEvent *event, const QTransform &transform); void swipeTriggered(QGestureEvent *event, const QTransform &transform); void twoFingerTapTriggered(QGestureEvent *event, const QTransform &transform); - bool onPress(const QPoint &screenPos, const QPointF &pos, const Qt::KeyboardModifiers modifiers, const Qt::MouseButtons buttons); + bool onPress(const QPointF &pos, const Qt::KeyboardModifiers modifiers, const Qt::MouseButtons buttons); bool onRelease(const QPointF &pos, const Qt::KeyboardModifiers modifiers, const Qt::MouseButtons buttons, bool touch); void startRubberBand();