From: Martin T. H. Sandsmark <martin.sandsmark@kde.org>
Date: Thu, 7 Jan 2021 15:48:43 +0000 (+0100)
Subject: Check the version of the plugins before trying to load them
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/f334a736b9e9d23e02b1e36913a825d087753b8c?ds=inline

Check the version of the plugins before trying to load them
---

diff --git a/src/views/versioncontrol/versioncontrolobserver.cpp b/src/views/versioncontrol/versioncontrolobserver.cpp
index 9f0933a48..175d362bc 100644
--- a/src/views/versioncontrol/versioncontrolobserver.cpp
+++ b/src/views/versioncontrol/versioncontrolobserver.cpp
@@ -304,6 +304,13 @@ void VersionControlObserver::initPlugins()
                 continue;
             }
             if (enabledPlugins.contains((*it)->name())) {
+                KPluginLoader pluginLoader(*(*it));
+                // Need to cast to int, because pluginVersion() returns -1 as
+                // an unsigned int for plugins without versions.
+                if (int(pluginLoader.pluginVersion()) < 2) {
+                    qCWarning(DolphinDebug) << "Can't load old plugin" << (*it)->name();
+                    continue;
+                }
                 KVersionControlPlugin* plugin = (*it)->createInstance<KVersionControlPlugin>(this);
                 if (plugin) {
                     m_plugins.append(plugin);