From: Felix Ernst Date: Wed, 8 Jun 2022 12:23:32 +0000 (+0200) Subject: Add "Invert Selection" and "Select All" to bottom bar X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/f45d2e985422a0ca96098155a20d32ec4783e5fa Add "Invert Selection" and "Select All" to bottom bar In selection mode, a bottom bar with contextual actions appears when at least one item is selected. This commit makes it so this bottom bar also contains the "Invert Selection" and "Select All" actions so users have more complete control over changing what is and isn't selected while in selection mode. --- diff --git a/src/selectionmode/bottombarcontentscontainer.cpp b/src/selectionmode/bottombarcontentscontainer.cpp index ab3a8e7c7..048e845a0 100644 --- a/src/selectionmode/bottombarcontentscontainer.cpp +++ b/src/selectionmode/bottombarcontentscontainer.cpp @@ -498,6 +498,21 @@ std::vector BottomBarContentsContainer::contextActionsFor(const KFile } } } + + auto separator = new QAction(m_internalContextMenu.get()); + separator->setSeparator(true); + contextActions.emplace_back(separator); + + // Add "Invert Selection" and "Select All" at the very end for better usability while in selection mode. + // Design-wise this decision is slightly questionable because the other actions in the bar apply to the selected items while + // the "select" actions apply to the view instead but we decided that there are more benefits than drawbacks to this. + auto invertSelectionAction = m_actionCollection->action(QStringLiteral("invert_selection")); + Q_ASSERT(invertSelectionAction && !internalContextMenuActions.contains(invertSelectionAction)); + contextActions.emplace_back(invertSelectionAction); + auto selectAllAction = m_actionCollection->action(KStandardAction::name(KStandardAction::SelectAll)); + Q_ASSERT(selectAllAction && !internalContextMenuActions.contains(selectAllAction)); + contextActions.emplace_back(selectAllAction); + return contextActions; }