From: Peter Penz <peter.penz19@gmail.com>
Date: Wed, 19 Nov 2008 20:09:51 +0000 (+0000)
Subject: Disable the "quick view" feature: I like the Previewer plasmoid, but I think after... 
X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/f542da84a27e11f58405da729e952987d16f151d

Disable the "quick view" feature: I like the Previewer plasmoid, but I think after a few months of trying to use it there is no need for having a separate menu entry (shortcut: CTRL+Return) in Dolphin: Doing a drag & drop operation to the previewer plasmoid is faster than selecting a file and pressing CTRL+Return (or selecting the menu entry). Using "Space" as shortcut conflicts with the Terminal and is still slower than simply just opening the file...

The i18n() string is still part of the code, so that it could be reactivated during the 4.2 cycle.

svn path=/trunk/KDE/kdebase/apps/; revision=886672
---

diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp
index cf2064482..9fe681462 100644
--- a/src/dolphinmainwindow.cpp
+++ b/src/dolphinmainwindow.cpp
@@ -251,8 +251,10 @@ void DolphinMainWindow::slotSelectionChanged(const KFileItemList& selection)
         compareFilesAction->setEnabled(false);
     }
 
+#if defined(QUICK_VIEW)
     const bool activeViewHasSelection = (activeViewContainer()->view()->selectedItemsCount() > 0);
     actionCollection()->action("quick_view")->setEnabled(activeViewHasSelection);
+#endif
 
     m_activeViewContainer->updateStatusBar();
 
@@ -1047,12 +1049,15 @@ void DolphinMainWindow::setupActions()
     compareFiles->setEnabled(false);
     connect(compareFiles, SIGNAL(triggered()), this, SLOT(compareFiles()));
 
+    // disabled Quick View
+#if defined(QUICK_VIEW)
     KAction* quickView = actionCollection()->addAction("quick_view");
     quickView->setText(i18nc("@action:inmenu Tools", "Quick View"));
     quickView->setIcon(KIcon("view-preview"));
     quickView->setShortcut(Qt::CTRL + Qt::Key_Return);
     quickView->setEnabled(false);
     connect(quickView, SIGNAL(triggered()), this, SLOT(quickView()));
+#endif
 
     // setup 'Settings' menu
     m_showMenuBar = KStandardAction::showMenubar(this, SLOT(toggleShowMenuBar()), actionCollection());