From: Peter Penz Date: Fri, 19 Jun 2009 19:13:08 +0000 (+0000) Subject: Fix bottleneck when renaming several hundrets of items (the expensive update of m_sel... X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/commitdiff_plain/f8c3c95a40f59786effe4f55fb84d7f470c8aa1e?ds=sidebyside Fix bottleneck when renaming several hundrets of items (the expensive update of m_selection is not required). svn path=/trunk/KDE/kdebase/apps/; revision=984020 --- diff --git a/src/panels/information/informationpanel.cpp b/src/panels/information/informationpanel.cpp index 2c9edcc18..30a41fefc 100644 --- a/src/panels/information/informationpanel.cpp +++ b/src/panels/information/informationpanel.cpp @@ -446,25 +446,9 @@ void InformationPanel::showPreview(const KFileItem& item, void InformationPanel::slotFileRenamed(const QString& source, const QString& dest) { - const KUrl sourceUrl = KUrl(source); - - // Verify whether the renamed item is selected. If this is the case, the - // selection must be updated with the renamed item. - bool isSelected = false; - for (int i = m_selection.size() - 1; i >= 0; --i) { - if (m_selection[i].url() == sourceUrl) { - m_selection.removeAt(i); - isSelected = true; - break; - } - } - - if ((m_shownUrl == sourceUrl) || isSelected) { + if (m_shownUrl == KUrl(source)) { m_shownUrl = KUrl(dest); m_fileItem = KFileItem(KFileItem::Unknown, KFileItem::Unknown, m_shownUrl); - if (isSelected) { - m_selection.append(m_fileItem); - } showItemInfo(); } }