]> cloud.milkyroute.net Git - dolphin.git/log
dolphin.git
3 years agoDon't show selection toggle areas on files while in selection mode
Felix Ernst [Wed, 18 May 2022 23:44:03 +0000 (01:44 +0200)]
Don't show selection toggle areas on files while in selection mode

3 years agoAddress Nate's UX feedback: Episode 2
Felix Ernst [Mon, 16 May 2022 13:53:18 +0000 (15:53 +0200)]
Address Nate's UX feedback: Episode 2

- Make Esc leave selection mode and have it only clear selection
    when already outside selection mode.
- Let translators know that the "More" overflow button should only
    have a short text on it.
- Fix a crash that happened when any code tried to exit selection
    mode even though selection mode had never been enabled to begin
    with.

3 years agoAddress Nate's UX feedback
Felix Ernst [Thu, 5 May 2022 10:54:36 +0000 (12:54 +0200)]
Address Nate's UX feedback

-More labels
-More icons
-"Abort" -> "Cancel"

3 years agoMake touch tap to select items work in selection mode
Felix Ernst [Sun, 1 May 2022 10:37:21 +0000 (12:37 +0200)]
Make touch tap to select items work in selection mode

Thanks to Steffen Hartleib for the help.

3 years agoImprove naming consistency and leave mode on Escape
Felix Ernst [Thu, 28 Apr 2022 20:55:28 +0000 (22:55 +0200)]
Improve naming consistency and leave mode on Escape

3 years agoImprove code quality
Felix Ernst [Mon, 25 Apr 2022 10:52:05 +0000 (12:52 +0200)]
Improve code quality

3 years agoBetter separation of classes
Felix Ernst [Sun, 24 Apr 2022 11:18:30 +0000 (13:18 +0200)]
Better separation of classes

Make obvious when actions trigger selection mode.

3 years agoKeep working towards a reviewable state
Felix Ernst [Sun, 24 Apr 2022 00:34:43 +0000 (02:34 +0200)]
Keep working towards a reviewable state

- Various code improvements
- Smoother animations
- The bottom bar in General Mode only becomes visible if items are
    currently selected
- Removed the selection mode action from the default toolbar since
    it can already be toggled in various ways
- More documentation
- Some cleaning

3 years agoAdd Selection Mode
Felix Ernst [Sun, 12 Sep 2021 13:33:39 +0000 (15:33 +0200)]
Add Selection Mode

The selection mode action is a checkable toggle action named
"Select Files and Folders" which has "Space" as the default
shortcut.

In selection mode a bottom bar with contextual actions is shown.
These should mostly mirror the actions which are available through
the right-click context menu aka DolphinContextMenu.

Resizing of the window might make a overflow button appear in the
bottom selection mode bar.

This commit makes press and hold in the view activate selection
mode. This behaviour is not triggered if the press and hold is
used to either start a rubberband selection or a drag operation
within a short time. The length of the short timeframe is defined
by a QStyleHint. This is currently not implemented in touch
because I can't test it.

Mix the selection mode bars' background colors using a nice
combination of colors from the current color scheme

BUG: 427202

3 years agoGIT_SILENT Update Appstream for new release
Albert Astals Cid [Wed, 10 Aug 2022 21:33:39 +0000 (23:33 +0200)]
GIT_SILENT Update Appstream for new release

(cherry picked from commit c9ab65174bd8b568c27e3366b5a0e27a112f5a51)

3 years agoUpdate copyright and maintainership info
Elvis Angelaccio [Thu, 9 Jun 2022 16:39:29 +0000 (18:39 +0200)]
Update copyright and maintainership info

3 years agoSVN_SILENT made messages (.desktop file) - always resolve ours
l10n daemon script [Wed, 3 Aug 2022 01:49:02 +0000 (01:49 +0000)]
SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

3 years agoSync QT_MIN_VERSION with KF's REQUIRED_QT_VERSION
Laurent Montel [Mon, 1 Aug 2022 17:18:16 +0000 (19:18 +0200)]
Sync QT_MIN_VERSION with KF's REQUIRED_QT_VERSION

In KF we already looking for 5.15.2
and looking something lower than that
is a bit meaningless

3 years agoInstall dolphinpart actions as standalone file
Alexander Lohnau [Mon, 1 Aug 2022 16:35:35 +0000 (16:35 +0000)]
Install dolphinpart actions as standalone file

This will allow Konqueror to use it without relying on the KPart being loaded using KService

3 years agoRemove service type file for vcs plugins
Nicolas Fella [Sat, 30 Jul 2022 15:47:40 +0000 (17:47 +0200)]
Remove service type file for vcs plugins

We don't support old-style plugins any more, so no need to install this

3 years agoRemove AUTHORS file
Nicolas Fella [Mon, 25 Jul 2022 22:24:28 +0000 (00:24 +0200)]
Remove AUTHORS file

It is horribly out of date and not very useful

3 years agoSVN_SILENT made messages (.desktop file) - always resolve ours
l10n daemon script [Mon, 25 Jul 2022 01:46:13 +0000 (01:46 +0000)]
SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

3 years agoSVN_SILENT made messages (.desktop file) - always resolve ours
l10n daemon script [Sat, 23 Jul 2022 01:50:13 +0000 (01:50 +0000)]
SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

3 years agoSVN_SILENT made messages (.desktop file) - always resolve ours
l10n daemon script [Wed, 20 Jul 2022 01:45:24 +0000 (01:45 +0000)]
SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

3 years agoRemove references to KServiceTypeTrader in comments
Nicolas Fella [Mon, 18 Jul 2022 20:42:39 +0000 (22:42 +0200)]
Remove references to KServiceTypeTrader in comments

3 years agoRemove unused includes
Nicolas Fella [Mon, 18 Jul 2022 20:38:43 +0000 (22:38 +0200)]
Remove unused includes

3 years agoKItemListHeaderWidget: Use QHeaderView font
Kai Uwe Broulik [Tue, 12 Jul 2022 16:20:12 +0000 (18:20 +0200)]
KItemListHeaderWidget: Use QHeaderView font

Makes it consistent with "real" tab widgets.

3 years agoSVN_SILENT made messages (.desktop file) - always resolve ours
l10n daemon script [Fri, 15 Jul 2022 01:51:02 +0000 (01:51 +0000)]
SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

3 years agoPort from KNewFileMenu::setPopupFiles to KNewFileMenu::setWorkingDirectory
Nicolas Fella [Tue, 14 Dec 2021 20:47:20 +0000 (21:47 +0100)]
Port from KNewFileMenu::setPopupFiles to KNewFileMenu::setWorkingDirectory

The former is deprecated

3 years agoAdd "Show statusbar" menu entry in "Settings"
Kai Uwe Broulik [Tue, 5 Jul 2022 19:02:56 +0000 (21:02 +0200)]
Add "Show statusbar" menu entry in "Settings"

Makes this setting more accessible and makes it consistent with other
KDE applications. Since Dolphin has a separate status bar on each view
container and doesn't use kxmlgui's statusbar, we don't get this menu
entry automatically.

3 years agoOpen >5 terminals dialog: use action terms instead of Yes/No buttons
Friedrich W. H. Kossebau [Sun, 3 Jul 2022 16:59:27 +0000 (18:59 +0200)]
Open >5 terminals dialog: use action terms instead of Yes/No buttons

Yes/No buttons in dialogs are discouraged (not only) by KDE HIG in favour
of actions terms.

3 years agoOpen >5 items dialog: use action terms instead of Yes/No buttons
Friedrich W. H. Kossebau [Sun, 3 Jul 2022 16:45:38 +0000 (18:45 +0200)]
Open >5 items dialog: use action terms instead of Yes/No buttons

Yes/No buttons in dialogs are discouraged (not only) by KDE HIG in favour
of actions terms.

3 years agoSVN_SILENT made messages (.desktop file) - always resolve ours
l10n daemon script [Wed, 13 Jul 2022 01:48:42 +0000 (01:48 +0000)]
SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

3 years agoGIT_SILENT Upgrade release service version to 22.11.70.
Albert Astals Cid [Tue, 12 Jul 2022 21:42:01 +0000 (23:42 +0200)]
GIT_SILENT Upgrade release service version to 22.11.70.

3 years agoportalize drag urls
Harald Sitter [Tue, 3 May 2022 11:57:09 +0000 (13:57 +0200)]
portalize drag urls

this enables sandboxed application to receive drop events

3 years agoSVN_SILENT made messages (.desktop file) - always resolve ours
l10n daemon script [Sun, 10 Jul 2022 01:53:09 +0000 (01:53 +0000)]
SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

3 years agodolphintabwidget.cpp piority of boolean operators
Marius P [Sat, 9 Jul 2022 12:40:28 +0000 (15:40 +0300)]
dolphintabwidget.cpp piority of boolean operators

Fix PVS-Studio issue "warning: V648 Priority of the '&&' operation is higher than that of the '||' operation.".
Fix clangd issue.

3 years agoSVN_SILENT made messages (.desktop file) - always resolve ours
l10n daemon script [Sat, 9 Jul 2022 01:52:00 +0000 (01:52 +0000)]
SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

3 years agoGIT_SILENT made messages (after extraction)
l10n daemon script [Sat, 9 Jul 2022 00:48:35 +0000 (00:48 +0000)]
GIT_SILENT made messages (after extraction)

3 years agoImprove goActions test
Felix Ernst [Thu, 7 Jul 2022 13:32:28 +0000 (13:32 +0000)]
Improve goActions test

This merge request fixes up a little oversight by me. I will merge this as soon as the pipeline passes.

------------------

Some lines verified that nothing is selected when navigating to a
folder that was not acted on yet. These verifications didn't test
anything meaningful because the folder in question was empty.

This commit adds a file and a folder to the test folder so that
testing if nothing is selected means something.

3 years agoAdd two autotests
Felix Ernst [Thu, 7 Jul 2022 10:41:39 +0000 (10:41 +0000)]
Add two autotests

- The first test makes sure that the width of the places panel
    doesn't change no matter what other panels are shown or hidden.
    There used to be bugs about this.
- The second test is kind of an integration test. It makes sure
    that the go actions work correctly. On two occasions we had
    the regression here that after going "Up" in the file system
    hierarchy the folder one emerged from didn't have keyboard
    focus which makes peeking into multiple folders tiresome.
    The test also makes sure that going back and forward works
    as expected and there are some sanity checks about which
    go actions are enabled, which items are selected and that
    using tabs doesn't interfere with any of that.

3 years agoShow "Loading canceled" placeholder when loading was canceled
Kai Uwe Broulik [Tue, 5 Jul 2022 11:00:34 +0000 (13:00 +0200)]
Show "Loading canceled" placeholder when loading was canceled

Rather than "Folder empty", which is misleading as we didn't
actually load anything.

3 years agoDon't reinterpret_cast QEvent
Kai Uwe Broulik [Tue, 5 Jul 2022 11:18:45 +0000 (13:18 +0200)]
Don't reinterpret_cast QEvent

We know that we'll be a `QHelpEvent` from `QEvent::ToolTip`, so do a
static_cast from the event handler (where it's obvious from context),
and then pass it along to `tryShowNameToolTip`.

3 years agoViewPropertiesDialog: use action terms instead of Yes/No buttons
Friedrich W. H. Kossebau [Sun, 3 Jul 2022 17:01:58 +0000 (19:01 +0200)]
ViewPropertiesDialog: use action terms instead of Yes/No buttons

Yes/No buttons in dialogs are discouraged (not only) by KDE HIG
in favour of actions terms.

3 years agoSVN_SILENT made messages (.desktop file) - always resolve ours
l10n daemon script [Sun, 3 Jul 2022 01:59:38 +0000 (01:59 +0000)]
SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

3 years agoGIT_SILENT made messages (after extraction)
l10n daemon script [Sun, 3 Jul 2022 00:50:27 +0000 (00:50 +0000)]
GIT_SILENT made messages (after extraction)

3 years agoSVN_SILENT made messages (.desktop file) - always resolve ours
l10n daemon script [Sat, 2 Jul 2022 02:06:49 +0000 (02:06 +0000)]
SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

3 years agoGIT_SILENT made messages (after extraction)
l10n daemon script [Sat, 2 Jul 2022 00:52:30 +0000 (00:52 +0000)]
GIT_SILENT made messages (after extraction)

3 years agoGIT_SILENT Update Appstream for new release
Heiko Becker [Fri, 1 Jul 2022 18:40:50 +0000 (20:40 +0200)]
GIT_SILENT Update Appstream for new release

(cherry picked from commit 8887f09b22068fdd0b1e5d6d7f6c4116966c6455)

3 years agoRemove defunc & now deprecated SHOW_DEPRECATIONS flag
Friedrich W. H. Kossebau [Tue, 28 Jun 2022 21:25:10 +0000 (23:25 +0200)]
Remove defunc & now deprecated SHOW_DEPRECATIONS flag

ecm_set_disabled_deprecation_versions() in versions < 5.96 was brokwn
when it comes to SHOW_DEPRECATIONS, warnings for newer deprecations
were disabled if the flag was set or not.
Starting with ECM 5.96 the macro now enables warnings by default,
so the flag is no longer needed.

GIT_SILENT

3 years agoUse edit-clear-history icon
Alain Laporte [Tue, 28 Jun 2022 05:31:06 +0000 (07:31 +0200)]
Use edit-clear-history icon

More semantically (and visually) appropriate icon

3 years agoSVN_SILENT made messages (.desktop file) - always resolve ours
l10n daemon script [Sat, 25 Jun 2022 02:01:46 +0000 (02:01 +0000)]
SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

3 years agodo not open excessive tab
Andrey Butirsky [Tue, 24 May 2022 13:24:24 +0000 (16:24 +0300)]
do not open excessive tab

even if directory of the file to be created is not the top-most opened in
TreeView

BUG: 440663

3 years agoformatting
Andrey Butirsky [Tue, 14 Jun 2022 18:14:05 +0000 (21:14 +0300)]
formatting

3 years agoRemove duplicate headers between cpp/h
Laurent Montel [Mon, 20 Jun 2022 05:09:01 +0000 (07:09 +0200)]
Remove duplicate headers between cpp/h

3 years agoGIT_SILENT made messages (after extraction)
l10n daemon script [Mon, 20 Jun 2022 00:49:44 +0000 (00:49 +0000)]
GIT_SILENT made messages (after extraction)

3 years agoDon't consider drops on a row as drops on the row's item
Felix Ernst [Thu, 16 Jun 2022 09:11:36 +0000 (09:11 +0000)]
Don't consider drops on a row as drops on the row's item

Since d3839617193e92463806580699caa595c892b8a6 in details view mode
clicking anywhere within the row is considered a click on the item.
That commit also changed it so that dropping files anywhere inside
a row would make it so the files are received by the folder of that
row.

This commit reverts the drop behaviour to be identical to the old
one.

I am having trouble explaining why this is better because one can
look at it in different ways. Bottom line is that one doesn't
really feel like one is dropping files inside a folder unless the
mouse cursor is actually directly above a folder's icon or name.

Another argument is that it is normal behaviour to just throw files
onto an application and the files then being opened by it.
Having potentially large parts of the view area covered by the rows
of folders means that there has to be more of a conscious effort to
not drop the files inside one of the folders by accident while with
this commit one has to aim precisely onto a folder to do it
intentionally.

CCBUG: 453700

3 years agoSVN_SILENT made messages (.desktop file) - always resolve ours
l10n daemon script [Thu, 16 Jun 2022 01:56:58 +0000 (01:56 +0000)]
SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

3 years agoCleanup config-dolphin.h includes
Ahmad Samir [Sat, 11 Jun 2022 17:23:30 +0000 (19:23 +0200)]
Cleanup config-dolphin.h includes

3 years agoUse cmakedefine01
Ahmad Samir [Sat, 11 Jun 2022 17:16:13 +0000 (19:16 +0200)]
Use cmakedefine01

This way we get a build time warning if the var isn't defined at all, e.g.
a missing check_include_files() CMake call.

3 years agoUse one config-dolphin.h.cmake configuration file
Ahmad Samir [Sat, 11 Jun 2022 17:09:45 +0000 (19:09 +0200)]
Use one config-dolphin.h.cmake configuration file

3 years agoFix rare ToolTipManager crash on exit
Dāvis Mosāns [Sun, 12 Jun 2022 01:55:12 +0000 (02:55 +0100)]
Fix rare ToolTipManager crash on exit

If tooltips are enabled and you hover over item
while immediately closing Dolphin sometimes it would crash
because native parent might have been destroyed before
DolphinView

3 years agoGIT_SILENT made messages (after extraction)
l10n daemon script [Tue, 14 Jun 2022 00:52:42 +0000 (00:52 +0000)]
GIT_SILENT made messages (after extraction)

3 years agoSVN_SILENT made messages (.desktop file) - always resolve ours
l10n daemon script [Mon, 13 Jun 2022 02:41:50 +0000 (02:41 +0000)]
SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

3 years agoGIT_SILENT made messages (after extraction)
l10n daemon script [Mon, 13 Jun 2022 01:14:51 +0000 (01:14 +0000)]
GIT_SILENT made messages (after extraction)

3 years agoBump KF5_MIN_VERSION after e9bd295b make 5.92 necessary
Méven Car [Sun, 12 Jun 2022 13:22:17 +0000 (07:22 -0600)]
Bump KF5_MIN_VERSION after e9bd295b make 5.92 necessary

3 years agoFix install/load plugins from kf<version>
Laurent Montel [Sat, 11 Jun 2022 11:34:22 +0000 (13:34 +0200)]
Fix install/load plugins from kf<version>

3 years agoSVN_SILENT made messages (.desktop file) - always resolve ours
l10n daemon script [Thu, 9 Jun 2022 02:11:47 +0000 (02:11 +0000)]
SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

3 years agoGIT_SILENT made messages (after extraction)
l10n daemon script [Thu, 9 Jun 2022 01:00:49 +0000 (01:00 +0000)]
GIT_SILENT made messages (after extraction)

3 years agoKItemListView fix valgrind issue "Conditional jump or move depends on uninitialised...
Marius P [Sun, 5 Jun 2022 04:36:01 +0000 (07:36 +0300)]
KItemListView fix valgrind issue "Conditional jump or move depends on uninitialised value"

KItemListView::setAlternateBackgrounds(bool) (kitemlistview.cpp:489)
In C++, a data member of an object is not automatically initialized to "zero".
In this case a bool had random values such as the integer 255.

3 years agoSVN_SILENT made messages (.desktop file) - always resolve ours
l10n daemon script [Tue, 7 Jun 2022 02:25:10 +0000 (02:25 +0000)]
SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

3 years agoGIT_SILENT made messages (after extraction)
l10n daemon script [Tue, 7 Jun 2022 01:02:15 +0000 (01:02 +0000)]
GIT_SILENT made messages (after extraction)

3 years agoSVN_SILENT made messages (.desktop file) - always resolve ours
l10n daemon script [Mon, 6 Jun 2022 01:43:37 +0000 (01:43 +0000)]
SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

3 years agoGIT_SILENT Update Appstream for new release
Heiko Becker [Sat, 4 Jun 2022 08:17:18 +0000 (10:17 +0200)]
GIT_SILENT Update Appstream for new release

(cherry picked from commit d0fc5bcd3d5c66611ec706c810103920e47c6038)

3 years agoGIT_SILENT Update Appstream for new release
Heiko Becker [Sat, 7 May 2022 09:23:41 +0000 (11:23 +0200)]
GIT_SILENT Update Appstream for new release

(cherry picked from commit 716d814019b077246fd60c59630e4dfd1c9e1f89)

3 years agoWe depend against qt5.15
Laurent Montel [Thu, 2 Jun 2022 05:55:08 +0000 (07:55 +0200)]
We depend against qt5.15

3 years agoSVN_SILENT made messages (.desktop file) - always resolve ours
l10n daemon script [Thu, 2 Jun 2022 01:44:29 +0000 (01:44 +0000)]
SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

3 years agoAdd Qt6 CI support
Laurent Montel [Tue, 31 May 2022 19:15:47 +0000 (21:15 +0200)]
Add Qt6 CI support

3 years agoGIT_SILENT made messages (after extraction)
l10n daemon script [Wed, 1 Jun 2022 00:56:17 +0000 (00:56 +0000)]
GIT_SILENT made messages (after extraction)

3 years agoIt's enabled by default in qt6
Laurent Montel [Tue, 31 May 2022 19:13:09 +0000 (21:13 +0200)]
It's enabled by default in qt6

3 years agoWe depend against kf5.91 => remove check
Laurent Montel [Tue, 31 May 2022 19:12:01 +0000 (21:12 +0200)]
We depend against kf5.91 => remove check

3 years agoFix building KF6 with PackageKit-Qt
Ahmad Samir [Sat, 7 May 2022 14:59:05 +0000 (16:59 +0200)]
Fix building KF6 with PackageKit-Qt

3 years agoFix build with Qt6 QFont::setWeight()
Ahmad Samir [Thu, 5 May 2022 20:16:51 +0000 (22:16 +0200)]
Fix build with Qt6 QFont::setWeight()

In Qt5 it takes an int, in Qt6 it takes a QFont::Weight.

3 years agoAdd missing includes needed to build with KF6
Ahmad Samir [Fri, 6 May 2022 16:17:41 +0000 (18:17 +0200)]
Add missing includes needed to build with KF6

Apparently KPluginMetaData was implicitly included by something else.

3 years agoKServiceTypeTrader has been deprecated since KService 5.90
Ahmad Samir [Fri, 6 May 2022 16:15:33 +0000 (18:15 +0200)]
KServiceTypeTrader has been deprecated since KService 5.90

3 years agoFix version macro with respect to finding "KFileItemAction/Plugin" services
Ahmad Samir [Fri, 6 May 2022 16:12:57 +0000 (18:12 +0200)]
Fix version macro with respect to finding "KFileItemAction/Plugin" services

GIT_SILENT

3 years agoPort away from deprecated KNewStuff API
Ahmad Samir [Fri, 6 May 2022 15:36:12 +0000 (17:36 +0200)]
Port away from deprecated KNewStuff API

3 years agoMerge two relevant ifdef blocks
Ahmad Samir [Fri, 6 May 2022 15:26:15 +0000 (17:26 +0200)]
Merge two relevant ifdef blocks

GIT_SILENT

3 years agoFix building kfileitemmodeltest with KF6
Ahmad Samir [Thu, 5 May 2022 20:15:14 +0000 (22:15 +0200)]
Fix building kfileitemmodeltest with KF6

- Fix kio_version.h include
- Explicitly create a QSet for QCOMPARE

3 years agoPort away from copying QEvent when building with Qt6
Ahmad Samir [Thu, 5 May 2022 20:12:42 +0000 (22:12 +0200)]
Port away from copying QEvent when building with Qt6

Copying QEvent in Qt6 isn't allowed, instead use clone().

3 years agoKdelibs4ConfigMigrator is deprecated in KF6
Ahmad Samir [Thu, 5 May 2022 20:09:31 +0000 (22:09 +0200)]
Kdelibs4ConfigMigrator is deprecated in KF6

3 years agoPort away from deprecated ThumbCreator API
Ahmad Samir [Thu, 5 May 2022 20:07:03 +0000 (22:07 +0200)]
Port away from deprecated ThumbCreator API

Configurability of individual preview plugins has been deprecated since KIO
5.87.

3 years agoMigrate old custom view font config entries
Ahmad Samir [Thu, 5 May 2022 18:31:30 +0000 (20:31 +0200)]
Migrate old custom view font config entries

3 years agoSimplify custom font settings
Ahmad Samir [Thu, 5 May 2022 16:32:34 +0000 (18:32 +0200)]
Simplify custom font settings

Instead of having 3 separate config keys, use the KConfig QFont
de/serilaization.

3 years agokfileitemmodel: sortRoleCompare: allow to sort by access time.
Méven Car [Mon, 30 May 2022 21:26:09 +0000 (23:26 +0200)]
kfileitemmodel: sortRoleCompare: allow to sort by access time.

We had all sorts of weird behavior when sorting by access time.
The comparison was simply missing in sortRoleCompare.

3 years agoGIT_SILENT made messages (after extraction)
l10n daemon script [Tue, 31 May 2022 00:55:26 +0000 (00:55 +0000)]
GIT_SILENT made messages (after extraction)

3 years agoAllow OpenTerminalHere to work for recentlyused:/ and recentdocuments:/
Méven Car [Sun, 29 May 2022 10:11:08 +0000 (12:11 +0200)]
Allow OpenTerminalHere to work for recentlyused:/ and recentdocuments:/

3 years agoSVN_SILENT made messages (.desktop file) - always resolve ours
l10n daemon script [Sun, 29 May 2022 01:46:43 +0000 (01:46 +0000)]
SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

3 years agoSVN_SILENT made messages (.desktop file) - always resolve ours
l10n daemon script [Sat, 28 May 2022 02:27:04 +0000 (02:27 +0000)]
SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

3 years agoGIT_SILENT made messages (after extraction)
l10n daemon script [Sat, 28 May 2022 01:06:47 +0000 (01:06 +0000)]
GIT_SILENT made messages (after extraction)

3 years agoRemove hover highlight before opening view context menu
Felix Ernst [Thu, 26 May 2022 08:38:15 +0000 (10:38 +0200)]
Remove hover highlight before opening view context menu

If one was fast to open the right-click context menu on the row of
an item in details view mode, the hover highlight would persist
while the context menu for the view was open.

This one-liner makes it so the highlight on the row is always
removed before the right-click context menu for the view is opened
so it is as clear as possible that the newly opened context menu
has no relation to the fileItem.

3 years agoFix paste on row while in details view mode
Felix Ernst [Tue, 24 May 2022 12:46:45 +0000 (14:46 +0200)]
Fix paste on row while in details view mode

Before this change, right-clicking the row of an unselected item
in details view mode would be in a weird state:
- It didn't really count as a click on the item because the item
    didn't get selected by this click before opening the context
    menu.
- It didn't really count as a click on the view background either
    because the actions that showed up depended on the item in
    that row.

This commit fixes this by considering a right-click in the same row
as an unselected item as a click on the view background.
The behaviour of right-clicking the icon or name of a file directly
is unchanged.

This fixes the following bugs:
- The Paste action that shows up when right-clicking in the
    unselected row of a folder now works (instead of doing
    nothing). It now pastes the clipboard contents onto the view
    background.
- When right-clicking the unselected row of a file (not a folder)
    a Paste action once again shows up.

3 years agoExtend selection rectangle to left edge
Travis Burrows [Thu, 26 May 2022 12:38:22 +0000 (12:38 +0000)]
Extend selection rectangle to left edge

This commit changes it so the sizes of selection rectangles and hover
highlights in compact and details view mode is identical for all items.

Before this commit, selection rectangles in lists would have varying
indentation of the left edge of the selection rectangle depending on
the preview image's width-to-height ratio. This would cause a sort of
"ragged edge" in both compact and details list view when multiple items
were selected.

This commit doesn't change anything about icon view mode.

BUG: 453046

3 years agoChange wording "Leading Column Padding" to "Side Padding"
Jin Liu [Thu, 26 May 2022 08:31:12 +0000 (08:31 +0000)]
Change wording "Leading Column Padding" to "Side Padding"

Since it actually adds padding on both left and right sides,
"Side Padding" might be more accurate.

This change is also propagated to variable and method names.

BUG: 453172

3 years agofix: Dolphin right click and compress doesn't scroll
Andrey Butirsky [Thu, 9 Sep 2021 14:59:36 +0000 (17:59 +0300)]
fix: Dolphin right click and compress doesn't scroll

For newly created items being selected, we had updateViewState() called
twice, and the first call blocked work execution needed in the other one