Peter Penz [Wed, 2 Apr 2008 19:49:04 +0000 (19:49 +0000)]
Thanks to David Faure the 'Copy To' and 'Move To' menus in the context menu can also be used by Dolphin now :-) In opposite to Konqueror the sub menus are turned off per default.
Minor issue: the Dolphin context menu should take care about the protocol capabilities (copy, move, delete, ...) like in konq_popupmenu (I'll fix this before 4.1).
Sebastian Trueg [Tue, 1 Apr 2008 12:27:06 +0000 (12:27 +0000)]
Implemented tagging of multiple files at the same time.
The result is always an intersection of the tags of all files.
Another possibility would be to only change the clicked tag. Feedback?
Sebastian Trueg [Tue, 1 Apr 2008 09:19:34 +0000 (09:19 +0000)]
Removed minimum size hint since we have zooming anyway.
One problem persists: the heightForWidth method does not take zooming
into account. Anyway, the tagcloud would probably benefit from being
implemented using QGraphicsView (any volounteers? ;)
Sebastian Trueg [Mon, 31 Mar 2008 19:37:55 +0000 (19:37 +0000)]
Load existing comments as plain text to allow editing of html comments.
Maybe in the future it would be nice to have a rich text editor here which
also handles semantic stuff like automatic annotations.
Peter Penz [Sun, 30 Mar 2008 08:44:52 +0000 (08:44 +0000)]
Revert last commit; the issue seems to be reproducible only in combination with 'Sort by Type' and we have to find the real root cause instead of bypassing a wrong layout.
Peter Penz [Sat, 29 Mar 2008 19:40:26 +0000 (19:40 +0000)]
QListView might return a wrong x-position if the decoration size decreases. I temporary bypassed this in Dolphin, as I'm not 100 % sure whether it is really a QListView issue or related to KFileItemDelegate. To reproduce this issue with Qt-only quite a lot effort is needed -> I'll wait until Qt4.4 final is released...
Peter Penz [Sat, 29 Mar 2008 14:54:56 +0000 (14:54 +0000)]
Move the pasteIntoFolder() method from the contextmenu into DolphinView. This allows to show the information inside the statusbar, that the paste operation has been completed (also some code duplication can be prevented by the way).
Peter Penz [Sat, 29 Mar 2008 07:44:03 +0000 (07:44 +0000)]
The paste operation should ignore the current selection to behave similar as Konqueror and other file managers. Only if a context menu for a folder is opened, a pasting should be done into this folder.
Some internal cleanups are still required (see TODO comments), so that after finishing the operation an indication can be given to the user in the statusbar (must go for breakfast now, otherwise I'll eat my keyboard...).
Peter Penz [Fri, 28 Mar 2008 06:32:41 +0000 (06:32 +0000)]
* minor coding style fixes
* replaced "Free disk space could not be determined" by "Unknown size", as the string would be too long fitting into the space information widget
Jeff Mitchell [Fri, 28 Mar 2008 01:21:19 +0000 (01:21 +0000)]
This value was still wrong, because I mixed up kibibytes and kilobytes. Assuming KDiskFreeSpace is really returning kB = 1000 bytes instead of kiB as according to Si rules,
this value should now be correct (as opposed to the original code which assumed it was actually returning kibibytes, or my incorrect fix which multiplied the kibibyte value by
a kilobyte factor to pass into convertSize.
Jeff Mitchell [Thu, 27 Mar 2008 20:36:05 +0000 (20:36 +0000)]
If KDiskFreeSpace doesn't work for some reason it never emits foundMountPoint, and since Dolphin never checked for done(), it'd sit there waiting on the job.
David Faure [Tue, 25 Mar 2008 21:39:05 +0000 (21:39 +0000)]
Use new key in .protocol files, archiveMimetype, to know which kioslave can handle which type of archive in a generic way.
Used that in dolphin and in konqueror (and in the filetypes config module, to show the right default value for those mimetypes).
This way Urs can extend this mechanism with the p7zip kioslave in the future.
CCMAIL: uwolfer@kde.org, peter.penz@gmx.at
Peter Penz [Sun, 23 Mar 2008 17:40:14 +0000 (17:40 +0000)]
The background for the image previews is already filled, so there is no need adding a border with the background color again (this also fixes a one-pixel-issue that shaded the right/bottom border in a wrong way).
Peter Penz [Sun, 23 Mar 2008 15:52:31 +0000 (15:52 +0000)]
Show hovered items in the Information panel also when items are selected. If the cursor is above the viewport in this case, show the selection information again.
Peter Penz [Sun, 23 Mar 2008 01:56:18 +0000 (01:56 +0000)]
Performance boost for previews that are already available in the cache: apply the previews in larger blocks instead of applying them immediately after getting the signal 'gotPreview' from the PreviewJob. Now the previews in Konqueror and Dolphin are as fast as in the good old KDE 3 days :-)
Sebastian Trueg [Fri, 21 Mar 2008 21:05:05 +0000 (21:05 +0000)]
This is the first step towards a better looking and more usable metadata GUI.
- A nicer comment widget shows a popup to edit the comment.
- A tag cloud replaces the ugly tagwidget from libnepomuk.
The plan is to use Dolphin as a testbed to optimize the look and then
move at least the tagcloud to libnepomuk to make it available for all apps
since this is a common feature.
So please test it and provide feedback. The layout is still cluttered. So we
also need feedback on that. And of course on the usability.
Apart from the GUI Dolphin now uses the mass metadata update job to perform
metadata updates on many files in an async KJob without blocking the GUI.
This is another candidate for public API at some point.
Peter Penz [Thu, 20 Mar 2008 16:58:59 +0000 (16:58 +0000)]
QListView does not support having a margin for grids. Originally it has been tried to bypass this by overwriting QListView::visualRect(), but this has some side effects (see #155378 and #155575). The clean approach is to return a proper size hint in the file item delegate.
Currently a custom item delegate has been made for Dolphin, but we'll discuss whether it makes sense providing this feature already in KFileItemDelegate...
Robert Knight [Tue, 18 Mar 2008 19:16:52 +0000 (19:16 +0000)]
Bump the priority of Dolphin an application for the inode/directory mimetype. This fixes a problem where Konqueror would be preferred over Dolphin if KDE 3 and KDE 4 were both installed because the kfmclient_dir.desktop file from KDE 3 had a higher priority than Dolphin.
Peter Penz [Sat, 15 Mar 2008 17:17:30 +0000 (17:17 +0000)]
When selecting 100 files in Dolphin and the Information Panel is shown, MetaDataWidget::setFiles() blocks Dolphin for around 15 seconds. Maybe we should delegate this to a KJob... In the meantime we temporary just reset the widgets (hoping that "meantime" means < KDE 4.1 ;-)).
Peter Penz [Thu, 13 Mar 2008 21:48:24 +0000 (21:48 +0000)]
Don't force that the preview size must be >= the icon size. This gets confusing when the user uses the Zoom In/Zoom Out feature inside a view a lot (e. g. by Ctrl + scroll wheel). This is because decreasing the preview size would also decrease the icon size, but when increasing the preview size again the icon size remains... I even got confused myself by this "feature" although I knew the reason for it ;-)
Peter Penz [Thu, 13 Mar 2008 21:31:34 +0000 (21:31 +0000)]
Remove the semitransparent effect for hidden items in the IconManager, it just takes too much time at this part of the code. David Faure suggested some alternative ideas, I hope I can try them before KDE 4.1. Currently it is more important to keep the performance high.
Peter Penz [Wed, 12 Mar 2008 16:49:55 +0000 (16:49 +0000)]
As the Qt-issue 160611 is solved in Qt4.4 and Fredrik has improved KFileItemDelegate, it is not necessary anymore drawing a custom drag & drop indication.
Bugfix for konqueror for in dolphin: open in new tab/window opens one of the selected files
(See email sent to kfm-devel for details)
CCMAIL:kfm-devel@kde.org
Peter Penz [Sun, 2 Mar 2008 10:13:28 +0000 (10:13 +0000)]
fixed problems with wrong space information (I'll backport the fix to 4.0.x on Tuesday - I'm currently out of office and don't have access to my 4.0.x repository)
Peter Penz [Tue, 26 Feb 2008 06:33:21 +0000 (06:33 +0000)]
When a grouping per date is done, per default the granularity is one month. This patch increases the granularity for the last month:
- "Weeks" are used for the last 4 weeks excluding the current week.
- "Days" are used for the current week.
Additionally some cleanups of the code has been done, as the method DolphinModel::data() was too long already.
No backport will be done as new strings are introduced. The patch has been reviewed by Rafael Fernández López.