Peter Penz [Wed, 28 Oct 2009 07:18:00 +0000 (07:18 +0000)]
After some discussions at http://reviewboard.kde.org/r/1938 it turned out that moving KMetaDataWidget and KMetaDataConfigurationDialog to kdelibs should be postponed to KDE 4.5. The main reason is that adding application specific properties is not possible with the current API in a generic way. Also the topic how to hide properties application specific is an open point...
So now all adjustments from the review have been adapted to the Dolphin code. After KDE 4.4 has been released some refactoring will be done so that the open topics above are handled in a nice way.
Do not zoom the icons if the user presses Control and the left mouse
button while using the mouse wheel. The user is probably trying to
scroll the view during a rubberband selection in that case.
Also simplify the code a bit by handling the icon zooming in
DolphinView::eventFilter().
Peter Penz [Fri, 23 Oct 2009 21:06:33 +0000 (21:06 +0000)]
Imported Adam Kidders search configuration widgets from playground/base/nepomuk/search_widgets_test. I adjusted some names of classes and members and also changed some parts of the implementation, but conceptually the concept is 1:1 like provided by Adam in playground.
Currently the UI works quite well, but the creating of the query string has not been integrated yet.
Andrew Coles [Mon, 19 Oct 2009 20:26:54 +0000 (20:26 +0000)]
Proof-reading - two minor changes:
- Texts is generally taken as a bulk term, i.e. one searches through text,
rather than searches through texts;
- File Name -> Filename, standard-usage term.
Peter Penz [Mon, 19 Oct 2009 18:55:50 +0000 (18:55 +0000)]
Fixed possible crash when switching between 2 views. In this case DolphinView::itemView() can temporary be 0 and it is important that no signals/slot connection is existing for the (by deleteLater()) deleted instance.
Thanks a lot to Frank Reininghaus for the analysis!
Peter Penz [Sat, 17 Oct 2009 15:05:50 +0000 (15:05 +0000)]
* move classes for searching into an own folder (new classes will be added soon)
* Postpone the creation of the searchcompleter, until the editor gets focused. This improves the startup time of Dolphin (reading all available tags is an expensive operation).
Peter Penz [Sat, 17 Oct 2009 12:23:38 +0000 (12:23 +0000)]
* get rid of MetaDataWidget::openConfigurationDialog()
* allow to hide specific data for applications
* check whether Nepomuk has been activated (the check with #idfef HAVE_NEPOMUK is not sufficient in the case if Nepomok is available but not activated)
Make sure that the faked mouse event in
DolphinViewAutoScroller::scrollViewport() gets the right keyboard
modifiers. This fixes the problem that the previous selection is lost
when several Ctrl-rubber band selections are made and the view scrolls
or the mouse pointer gets close to the edge of the viewport.
Peter Penz [Sun, 11 Oct 2009 17:43:30 +0000 (17:43 +0000)]
The text of the paste-action is modified dynamically by Dolphin (e. g. to "Paste One Folder"). To prevent that the size of the toolbar changes due to the long text, the text "Paste" is used when the action is shown in the toolbar.
Peter Penz [Sat, 10 Oct 2009 21:28:37 +0000 (21:28 +0000)]
Reactivate showing of general meta information. This is also done as part of the LoadFilesThread and is no special case anymore like in the old code base.
Peter Penz [Sat, 10 Oct 2009 20:12:58 +0000 (20:12 +0000)]
Reactivate reading of the meta data for the rating, comments and tags. All expensive operations are done in a separate thread to assure that the Dolphin UI never gets blocked.
Peter Penz [Sat, 10 Oct 2009 14:13:50 +0000 (14:13 +0000)]
Start of refactoring so that the metadata widget can be moved outside of Dolphin for other applications. The temporary removed code will be integrated again within the next 10 days (-> currently no meta data is shown and cannot be updated).
Matthias Fuchs [Mon, 5 Oct 2009 18:46:35 +0000 (18:46 +0000)]
Adds autocompletition to the dolphin-search-box. So far existing tags and commands like "and", "or" and "-" (for not) are offered as completition-suggestions.
David Faure [Fri, 2 Oct 2009 10:55:59 +0000 (10:55 +0000)]
Make "most local url" determination asynchronous so that it doesn't block the GUI for a long time
(e.g. when accessing the non-existing sftp://192.168.1.100/home)
and only run this job if the terminal panel is shown (or at the time when it is made visible).
Sorry kdebase users, you get to update kdelibs again.
BUG: 202176
Fix deadlock when changing the rating and the comment of the same
object, in that order. The harmless looking setEnabled() call two lines
down from here triggers a convoluted chain of (q)events that eventually
ends up calling a method that tries to lock the mutex itself.
Peter Penz [Sun, 13 Sep 2009 14:49:26 +0000 (14:49 +0000)]
Originally it was intended to move the SVN plugin from Dolphin to kdevplatform, but kdevplatform most probably won't get released with KDE 4.4. So for KDE 4.4 Dolphin will temporary contain the plugin in it's own codebase. As soon as kdevplatform will get released the SVN plugin will get moved to kdevplatform.
Still open: KServiceTypeTrader::query does not find the "FileViewVersionControlPlugin", I could not find the root cause for this yet (old cache?)
Peter Penz [Fri, 11 Sep 2009 19:50:40 +0000 (19:50 +0000)]
Fixed minor regression introduced with the column view refactoring: When switching the view mode in a folder showing previews, the previews get lost after switching.
The KFilePreviewGenerator initialized in the ViewExtensionsFactory wants a valid icon size to accept previews. Fixed + Q_ASSERT added to prevent such a mistake in future.
Peter Penz [Sun, 30 Aug 2009 19:17:08 +0000 (19:17 +0000)]
Move the selection listener from DolphinView to ViewExtensionsFactory. The statusbar and information panel are now informed correctly about selection changes also when using the column view.
Peter Penz [Sun, 30 Aug 2009 18:39:03 +0000 (18:39 +0000)]
Move the VersionControlObserver from the DolphinView to the ViewExtensionsFactory. This automatically enables also the column view to be able handling version controlled files.
Peter Penz [Sat, 29 Aug 2009 09:42:21 +0000 (09:42 +0000)]
Move code for initializing and handling view extensions to the new class ViewExtensionsFactory. Beside making DolphinView less complex this will allow the column view to share the view extension code instead of (partly) duplicating it as it has been done before.
Currently only the tooltips- and filepreview-handling have been moved into ViewExtensionsFactory, a further cleanup will be done later.
Peter Penz [Fri, 28 Aug 2009 21:53:18 +0000 (21:53 +0000)]
Restore filtering of items. The DolphinView just tells the controller about the filter, the views (1:1 iconView + detailView, 1:n columnView) connect to the filter-changed signal and apply it to their proxy model.