David Faure [Wed, 13 Feb 2008 18:07:34 +0000 (18:07 +0000)]
Provide the dolphinpart view modes (Icons, Details, Columns) in konqueror's View Modes menu.
(this is done using a Q_PROPERTY in the dolphin part and a signal; the available view modes for creating the menu in the first place are listed in dolphinpart.desktop)
Konqueror: cleaned up the old (complex) handling of view modes as N toolbar buttons from M services grouped by library.
Dolphin: moved view mode handling to DolphinViewActionHandler, removes duplication between part and mainwindow.
BUG: 157424
David Faure [Mon, 11 Feb 2008 12:34:48 +0000 (12:34 +0000)]
Factorize all the view-related action handling to DolphinViewActionHandler, to remove code duplication between mainwindow and part, and to remove my code-splitting with the static createFooAction methods in the view.
David Faure [Mon, 28 Jan 2008 11:33:49 +0000 (11:33 +0000)]
Centralize three more actions so that they are available in DolphinPart: 'Show preview' 'Show hidden files' 'Categorized sorting'
Found a way of sharing the actions with even less code duplication, discussed it with Peter, but this will be for after 4.0.1
David Faure [Tue, 22 Jan 2008 01:22:56 +0000 (01:22 +0000)]
Move the code handling the additional-info-actions to DolphinView; simplify signal from DolphinView (it has the info anyway).
The fact that the last additional-info doesn't show up in the icon view is in fact a KFileItemDelegate bug, not a bug in this code :)
David Faure [Tue, 22 Jan 2008 00:43:51 +0000 (00:43 +0000)]
restore previous behavior: additional info actions are not mutually exclusive.
(although requesting size and type at the same time doesn't show the type...)
David Faure [Mon, 21 Jan 2008 19:08:52 +0000 (19:08 +0000)]
Revert the moving of the action to the DolphinView instance, this doesn't work with splitted views.
(Each view would need its own action collection, but then DolphinView would have to become
a KXMLGUIClient, and the GUI would flicker when switching views).
Instead, use the same solution as the other shared actions: static method in DolphinView (for now),
slot in the mainwindow (and for the more complex actions than this one, shared code in DolphinView)
Peter Penz [Fri, 18 Jan 2008 20:13:14 +0000 (20:13 +0000)]
Backport:
* Always take the root of an URL as root for the treeview (using a matching Places-URL leads to serious usability issues - see bug #150941 for details).
* Don't reset the horizontal scrollbar position when expanding/reloading the tree.
Peter Penz [Thu, 17 Jan 2008 18:12:11 +0000 (18:12 +0000)]
Treeview fixes (backport):
* don't jump to the selected folder when expanding a sub tree within the treeview widget
* don't reset the root of non-local URLs when there is no Places-URL available
Peter Penz [Wed, 9 Jan 2008 21:52:38 +0000 (21:52 +0000)]
Backport: Only increase the height of the statusbar for long texts if the message type is not DolphinStatusBar::Default (otherwise the layout of the icons view might get changed when hovering items).
Jakob Petsovits [Fri, 4 Jan 2008 03:28:27 +0000 (03:28 +0000)]
ARGH!
No, but really, we can't ship Dolphin with a missing
toolbar icon. And no, I have no clue why it won't use
that "pics" folder that I was generating for that icon.
Urs Wolfer [Thu, 3 Jan 2008 15:25:23 +0000 (15:25 +0000)]
Re-compress svgz files with:
find . -name "*.svgz" -exec advdef -z -4 '{}' \;
That saves around 6MB in trunk without any restrictions.
Also correct the svn mimetype for all svgz files which had a wrong one (which is thy reason why my fist commit failed...) with:
svn propset svn:mime-type 'application/octet-stream'
Urs Wolfer [Wed, 2 Jan 2008 00:10:07 +0000 (00:10 +0000)]
Optimize PNG files again.
Last optimization has been done almost two years ago. There a lot of new files in trunk (e.g all Oxygen stuff).
It's not the correct time to do that again (before the release).
This run saves again around 10MB of diskspace without any restrictions.
* Better item appearance (selected and hover) on systemsettings.
* Keyboard navigation improved in dolphin, and now is possible to navigate with keyboard in systemsettings (it was not possible before).
* No rubberband or multiple selection on systemsettings.
* Single or double click for item activation depends on the system state on systemsettings.
* On KCategoryDrawer now titles are drawn with more margin, as happens on DolphinCategoryDrawer. This gives more consistency to its look.
David Faure [Thu, 20 Dec 2007 20:44:58 +0000 (20:44 +0000)]
If we should open the URL right away, then let's do it right away.
We can tell konqueror afterwards by using the openUrlNotify() signal.
Note: this design bit is a bit strange; the controller has urlChanged() and requestUrlChange(),
but they are both channeled to DolphinView::urlChanged(), which means the recipient has
to figure out if the url change was already done or not, with "if (m_view->url() != url)".
Wouldn't it be simpler to just have both signals coming out of DolphinView?
(but some receivers like the view container don't seem to care which one was emitted... strange)
Now the konsole part is autodestructed when no tabs do exist. This makes the desired effect on dolphin when typing "exit" on the terminal, the dock will be hidden.
The order is important, also is important to accept the event on the move event. While on the dock tree view we were always getting a forbidden cursor with no
possibility to drop, now we can nicely drop :)
Revert the whole code regarding the discussed issue. Columns view still show the "forbidden" cursor, so nothing is fixed while reverted. The drop-indicator is shown on
files too... so something needs a fix here. Shouldn't be hard anyway
Keep consistent all views. Peter, if you decide to revert the change that David did on dolphiniconsview, do the revert here too. It really makes things very clear this
way. Anyway, detailed and columns view were buggy since it did never accept the dragging events, so you were never able to drop on the detailed or column view.
Give visual feedback when dragging with the cursor also. If you are not able to drop to an item (for example, a txt file) the cursor also changes to "forbidden" with the
categorized view.
The drag&drop helper did not make the difference between the different kind of views. The only view that draws the hover indicator with rounded corners is the icon view
mode. For that reason, the drop marker with the detailed view was drawn with rounded corners. For making it consistent, we draw the drop indicator as the hover effect
indicator, so the only one that draws rounded corners is the icon one.
Peter Penz [Sun, 16 Dec 2007 12:23:49 +0000 (12:23 +0000)]
Only browse through zip and tar files if they are local (otherwise a cryptic error message will occur). We really must make this behavior configurable in KDE 4.1 - I'd suggest that per default no browsing through zip and tar is done (with an option turning this on again)
When collapsing nodes that made the scrollbar bigger, it didnt became smaller. I've debugged on event() method to find out which event was the one called. It seems
QEvent::MetaCall is always called when we want and is not as impressive called as paintEvent(), so there we go. This will fix another problem that when a second expanded
cached node should make the horizontal scrollbar bigger it didn't till the tree view lost the focus or was resized. Everything fixed :)
Peter Penz [Sun, 16 Dec 2007 11:28:52 +0000 (11:28 +0000)]
fixes for the terminal panel:
* assure that the correct directory is entered when reopening the terminal
* let the terminal be focused also when reopening it
The latest fix still had the same problem when dragging went out of the viewport and entered again. Non droppable places (e.g. files) were still drawn with MouseOver
flag. This completely fixes the problem for all cases, the problem was the hovered cached index being updated at indexAt() method used for general purposes. Now it is
updated on the MouseMove method, and this gives consistence.
Fix the problem of the elements being rendered as hovered when a dragging was being done. Regarding your mail Peter, well some variables are bad-named, but their values
were correct :)
Peter Penz [Sat, 15 Dec 2007 17:11:13 +0000 (17:11 +0000)]
Fixed "Eike Hein"-details-view-issue:
1. Open a Dolphin window
2. Switch to Details view
3. Navigate to a folder with a dozen or so items
4. Size the window so that there is an empty space below
the items
5. Move the mouse pointer below the items
6. Click and hold the mouse button, and move the pointer
upward to select all items in the list using the rect.
While selecting in this manner, move the pointer so
high that it is above the list headers in the toolbar.
Then, while still holding the mouse button and being
outside the listview's rect, move the pointer left out
of the window. Now with the pointer outside of the
window, move the pointer down into the area below the
list items, so that the selection rectangle no longer
intersects with the items. Notice they're still all
selected.
Peter Penz [Sat, 15 Dec 2007 16:48:48 +0000 (16:48 +0000)]
Fixed issue that Ctrl+A inverted the selection instead doing a "Select All". It seems like a Qt issue, but I'm not 100 % sure - I'll try to make this reproducible with a Qt-only code after KDE 4.0 and submit a bug report to Trolltech...
projects / dolphin.git / log