David Faure [Mon, 10 Nov 2008 13:48:43 +0000 (13:48 +0000)]
Fix "two instances of the DragAndDropHelper" singleton: Vir found the reason, draganddrophelper.cpp was compiled
both into libdolphinprivate and into dolphin.
Also fix missing newline in copyright header.
Peter Penz [Sat, 8 Nov 2008 16:22:30 +0000 (16:22 +0000)]
* implement the DragAndDropHelper as singleton derived from QObject, so that emitting of signals is possible
* show an information message in the statusbar, if items are dragged into the same directory
TODO: although the signal seems to get connected correctly, the slot DolphinMainWindow::showInformationMessage() is not invoked when the signal is emitted -> will debug this later, it is important that the new string is added before the message freeze
If the elastic band ventures beyond the logical top-left of the view (NOTE: not the viewport), then startIndex will likely be invalid, resulting in broken selection behaviour. Prevent this.
Peter Penz [Wed, 5 Nov 2008 19:37:51 +0000 (19:37 +0000)]
Allow having a smaller text width for the icons view (Text size: "Small"), so that the same grid size can be achieved like in Konqueror for KDE 3. The default size for Dolphin will stay on "Medium".
Peter Penz [Mon, 3 Nov 2008 08:20:41 +0000 (08:20 +0000)]
* Show the total size of files in the statusbar (thanks to Bram Schoenmakers for the patch).
* Changed the format of the string to be consistent with the format used when doing a selection. Maybe it would be useful adjusting KIO::itemsSummaryString() instead using a custom output format. Currently KIO::itemsSummaryString() shows "20 Items (5 Files, 15 Folders) - (200 KiB Total)", which is quite confusing IMO, as the total size is only counted for the files. Dolphin currently shows: "15 Folders, 5 Files (200 KiB)"
Be better behaved in the presence of scroll events in the middle of an elastic band selection by storing the last selection elastic band in view (rather than viewport) coordinates.
If ignoreOldInfo, we should manually clear oldSelectionRect - an obscure bug where it is no longer possible to use rubber band selection(!) occurs otherwise!
Sometimes, the penultimate item in the bounds would get deselected when it shouldn't - this is because lastIndex is always included in the toggle range, even if it needn't be toggled. Fixed now - hopefully, there are no more "elastic band selection" bugs, now :)
Restore behaviour (I don't have an old version to check against, though!) - if CTRL is pressed when initiating elastic band, respect the item selection at that time while dragging the band.
KFileItem name() and text() needn't be the same, and we should prefer text(). Testcase - very (very) recent settings:/ in Konqueror. Thanks to dfaure for clairvoyant diagnosis!
If we commit a toggle range due to a change of parent, check to see if we should immediately form a new range with the current index. This stops child items from sometime being missed by the band.
Revert http://websvn.kde.org/?view=rev&revision=876107 - it introduced a massive performance regression and also didn't really fix the issue. Use new way that fixes the issue in a less direct but more general way.
Peter Penz [Fri, 24 Oct 2008 22:19:23 +0000 (22:19 +0000)]
* Move code from DolphinDropController to DragAndDropHelper.
* Move code which checks whether the dragging of a MIME type is supported to DragAndDropHelper. This allows adding an improved support for dropping compressed files from Ark to Dolphin later...
Peter Penz [Fri, 24 Oct 2008 21:12:11 +0000 (21:12 +0000)]
Provide a UI option for the "auto expand folders during drag operations" feature. The feature is not 100 % finished yet (dragging into a folder having a different view type does not work yet), but it's important to get in the UI string for the translators.
Peter Penz [Fri, 24 Oct 2008 19:52:28 +0000 (19:52 +0000)]
Assure that no reloading is done if KDirLister emits a redirection, only change the the URL. Thanks to David Faure and Albert Alstals Cid for the detailed analysis!
Peter Penz [Wed, 22 Oct 2008 20:52:45 +0000 (20:52 +0000)]
Don't draw a frame for previews in tooltips by code duplication: Now we had 3 different frame types in Dolphin (frames from KFilePreviewGenerator, no frame in the Information Panel and an outdated frame by code duplication from the old file preview generator).
Until we find a nice way to make the code for drawing frames in KFilePreviewGenerator public, better don't draw any frame at all.
Peter Penz [Thu, 16 Oct 2008 06:00:07 +0000 (06:00 +0000)]
fixed regression: don't change the state, otherwise when having a split view it is not possible dragging an item from the inactive to the active view (only the rubberband gets active in this case)
Peter Penz [Wed, 15 Oct 2008 21:23:42 +0000 (21:23 +0000)]
Assure that the item delegate draws the hover effect and the selection for the details view only above the icon + name. Open issue: The performance when selecting files by the rubberband is too slow (will be fixed before KDE 4.2).
Peter Penz [Wed, 15 Oct 2008 19:23:09 +0000 (19:23 +0000)]
First step for having a details view, where only the icon + name act as selectable area (not the whole width of the name column - similar to KDE3). Thanks to Simon St. James for the original patch!
Currently it is very confusing that although only the icon + name is selectable, still the selection and hovering is drawn above the whole column width. This will be fixed before KDE 4.2.
Peter Penz [Wed, 15 Oct 2008 06:03:41 +0000 (06:03 +0000)]
Assure that the docks get informed about an URL change before the GUI is setup (thanks to Frank Reininghaus for the patch!). This prevents that slots from the docks are called with invalid URLs.
David Faure [Mon, 13 Oct 2008 21:54:03 +0000 (21:54 +0000)]
Konq popupmenu fix: we don't show the "Create new" submenu over subdirs in an iconview because you wouldn't see the just-created file/dir,
but let's show it in the case of the hiearchical details view ("folders expandable" option), since you can indeed see the new file/dir in that case. Peter: problem solved with itemsExpandable().
CCMAIL: peter.penz@gmx.at
Peter Penz [Wed, 8 Oct 2008 21:46:25 +0000 (21:46 +0000)]
Improve performance of information panel. Depending on the used backend reading the meta information like rating, tags and comments can be slow (especially when e. g. selecting 1000 files at once having items that are not cached yet). The reading of the meta information is now forwarded to a separate thread, so that Dolphin never gets blocked.
Peter Penz [Wed, 8 Oct 2008 19:10:00 +0000 (19:10 +0000)]
Don't request any meta data, if the requested URL is equal to the currently shown URL. This is especially important when opening a directory, where the meta info has been requested twice (the first time on hovering a directory, the second time when opening - now when opening the directory no meta data is requested at all). Further performance improvements will follow...
Peter Penz [Tue, 7 Oct 2008 20:29:18 +0000 (20:29 +0000)]
If an URL cannot be listed, just let the view and the panels show the last listable URL. This prevents having an empty view and empty panels when typing a wrong URL.
Sascha Peilicke [Tue, 7 Oct 2008 08:26:07 +0000 (08:26 +0000)]
Small fix to the zoom slider bar, the old sliderMoved(int) signal is just fired when the user pressed a mouse button and drags the slider. It is however possible to change the slider position by clicking into it or (when focus follows mouse is enabled) by hovering on top of the slider and scrolling the mouse wheel. The zoom state was currently not updated in the latter 2 cases.
Peter Penz [Mon, 6 Oct 2008 16:39:13 +0000 (16:39 +0000)]
Provide more zoom levels. When zooming icons > KIconLoader::SizeHuge with sizes that are not available, the quality is still good in opposite to scaling smaller icons.
Peter Penz [Sun, 5 Oct 2008 21:17:06 +0000 (21:17 +0000)]
Provide a zoom slider in the status bar. It is configurable whether the zoom slider and/or the space information is shown in the statusbar (the GUI in the settings dialog will be provided during the next week).
Peter Penz [Sun, 5 Oct 2008 18:11:46 +0000 (18:11 +0000)]
update the statusbar and provide a progress information within the Dolphin KPart, so that Konqueror shows the same information as Dolphin (thanks to Simon St James for the patch!)
Peter Penz [Wed, 1 Oct 2008 21:39:35 +0000 (21:39 +0000)]
* adjusted Dolphin to use KonqOperations::doDrop() instead of using a custom implementation
* used new signals jobRecordingStarted() and jobRecordingFinished from FileUndoManager to inform the user in the statusbar when a recorded command has been finished
David Faure [Mon, 29 Sep 2008 21:00:34 +0000 (21:00 +0000)]
Fix connect.
But the one in dolphinviewcontainer (connecting to the kurlnavigator slot urlsDropped) still fails,
since it has no QDropEvent. Not sure what's the plan there.
CCMAIL: peter.penz@gmx.at
Peter Penz [Sun, 28 Sep 2008 18:38:00 +0000 (18:38 +0000)]
Use KonqOperations::doDrop() instead of a custom dropping code. Still some minor issues are open (Dolphin currently gets no feedback anymore when the operations have been finished), but they will be solved during the next week.
Peter Penz [Tue, 23 Sep 2008 10:54:55 +0000 (10:54 +0000)]
Make KFilePreviewGenerator independent from the view implementation, so that it is no requirement that a QAbstractItemView is used -> the view implementation can also be based on QGraphicsView like done in the FolderView Plasmoid.
Peter Penz [Mon, 22 Sep 2008 15:33:04 +0000 (15:33 +0000)]
try to align the x-position of the tooltip to the mouse-cursor if the tooltip can be shown below or above the item (thanks to Simon St James for the patch)
Peter Penz [Sun, 21 Sep 2008 21:24:54 +0000 (21:24 +0000)]
Experimental patch provided by Fredrik Höglund: Use Xrender to scale the preview pixmaps in the X server. This is accelerated in HW by the latest version of the NVidia driver and by the open source ATI, Intel and Nouveau drivers when they're using the EXA acceleration architecture. EXA will be the default in the upcoming 1.6 release of the server, which is scheduled for December.
projects / dolphin.git / log