Very interesting bug in Qt in which I will debug. For now, and since we need to release with the source version of Qt (not patched) we need this workaround. The problem
is that when you select by dragging with a rect a set of items, say (1, 2, 3) and you Ctrl+drag another set (5,6) the (1,2,3) selection is lost. If you do the same, that
is: select (1, 2, 3), now Ctrl+click on (4), it is not lost. Now, ctrl+drag another set (5, 6), the selection lost is (4). So we can say that the selection lost is the
last one done.
This is only a workaround and should be removed when fixed on Qt (I am going to debug it on Qt, to see where the fail is).
This workaround does not only fix KCategorizedView, but QListView also.
Peter Penz [Fri, 14 Dec 2007 11:45:11 +0000 (11:45 +0000)]
Fixed issue that when clicking on Open Office files that Dolphin handles the files as zip-folder. I'm not sure whether there might be a nicer way doing this, but at least for KDE 4.0 this should be sufficient.
Fix the bug reported by Will. Now this code is also more polite. This was a TODO and now is fixed :) Still a bug somewhere on Qt...
when you ctrl+selection rect (with mouse), it is lost the last selection done if they were done by groups. Going to dive more into
this problem, but it lives on Qt.
Now that we changed some needed stuff at naturalCompare() method, we can set the replacementchar to put "Others" category on the last place. Now, we can actually call it
"Others" since it is placed the last one, and it is not necessary to call it "Uncategorized" because it was placed the first one before.
Peter Penz [Thu, 6 Dec 2007 21:06:45 +0000 (21:06 +0000)]
Fixed wrong usage of QStyleOptionViewItem: caching of the file item in the constructor is too early (thanks to Fredrik for the hint!). This fixes 2 issues:
* the selection color of the details view now uses the correct selection color
* changing the colors of KDE results in updating the colors of all Dolphin views
Peter Penz [Tue, 4 Dec 2007 20:56:42 +0000 (20:56 +0000)]
Allow turning off the feature that additional information might be shown in the icons view. Per default the setting is still on, but for people who prefer browsing with the details view and only temporary switch to the icons view (e. g. for having a larger preview), this feature gets a showstopper (discussed with Eike Hein).
Got the OK from the translator team for adding the new string.
John Tapsell [Mon, 3 Dec 2007 10:32:27 +0000 (10:32 +0000)]
The first columns model and selection model should be the same as the view's model and selection model.
This means
1) We don't leak memory switching to and from column view
2) Selection is preserved when switching views
3) We don't have 2 models running for the root directory
Peter Penz [Sat, 1 Dec 2007 09:59:13 +0000 (09:59 +0000)]
Assure that the items of the details view are not expandable. We might think about enabling this in 4.1 optionally, so that especially Konqi can use this feature. But for this some adjustments in the drag & drop handling of the details view must be done first -> let's postpone this to 4.1.
Peter Penz [Fri, 30 Nov 2007 19:19:38 +0000 (19:19 +0000)]
Hide the "Sort by Rating" and "Sort by Tags" menu entries for KDE 4.0, as currently the performance is too slow. Nepomuk will support caching in future versions, so hopefully we can provide those entries again in KDE 4.1.
David Faure [Fri, 23 Nov 2007 11:50:00 +0000 (11:50 +0000)]
Move F10 (create directory) shortcut from konq to dolphinpart.
About all those filemanagement feature moves: I double checked and the other inode/directory parts are cervisia (need own file-related operations for VCS support), konsole (no gui), kfilereplacepart (no mkdir) and fsview (readonly). So better unbloat konq itself.
Peter Penz [Tue, 20 Nov 2007 22:36:21 +0000 (22:36 +0000)]
Allow using a common drag and drop pixmap also for the KCategorizedView. The code is currently encapsulated inside a DOLPHIN_DRAGANDDROP define, we'll clean this up when Qt 4.4 is out (-> KDE 4.1?)
Peter Penz [Tue, 20 Nov 2007 21:11:48 +0000 (21:11 +0000)]
Drag & drop fixes for all views: assure that a consistent pixmap for the drag object is used throughout all views (still open yet: KCategorizedView uses its custom code yet)
Peter Penz [Mon, 19 Nov 2007 20:24:33 +0000 (20:24 +0000)]
fixed issue that the space info is not updated sometimes (QProgressBar::setValue() uses QProgressBar::text() which returns m_text -> the text must be set first)
Peter Penz [Mon, 19 Nov 2007 19:58:00 +0000 (19:58 +0000)]
open the context-menu for the viewport if no selection is given although the mouse is above an item (this might happen if the shift-key is pressed during a right-button mouse click)
Peter Penz [Mon, 19 Nov 2007 17:44:21 +0000 (17:44 +0000)]
Icons view: assure that the vertical spacing does not grow as fast as the horizontal spacing. For the default settings this means that the viewport can now be reached easier than before, while not wasting too much vertical space.
Peter Penz [Sun, 18 Nov 2007 13:33:16 +0000 (13:33 +0000)]
Check whether the shift key is pressed when the "Move to Trash" action is executed. If this is the case, perform the "Delete" action instead (-> works like in Konqi now, thanks to David for the hint)
Peter Penz [Sun, 18 Nov 2007 13:24:43 +0000 (13:24 +0000)]
fix crash for the following use case:
- open a view with no selection
- press SHIFT + right mouse-click on an item
- a context menu will be opened although no item has been selected -> assertion gets triggered later
David Faure [Sat, 17 Nov 2007 00:08:54 +0000 (00:08 +0000)]
Fix "delete" and "move to trash" actions in dolphinpart; moved all logic for those out of konqueror.
Inside dolphin, the usual: moving code to DolphinView.
Pressing shift while clicking on "Move to Trash" in konq (dolphinpart) offers to delete, as in kde3 (this bit of logic might be good for dolphin itself too? see DolphinPart::slotTrashActivated)
CCMAIL: peter.penz@gmx.at
Peter Penz [Thu, 15 Nov 2007 22:20:40 +0000 (22:20 +0000)]
Bypass a layout issue in QListView::visualRect(), where the horizontal position of items might get calculated in a wrong manner when the item name is too long. I'll try create a patch for Qt but as Dolphin must also work with Qt 4.3.0 this workaround must get applied at least for KDE 4.0.
David Faure [Thu, 15 Nov 2007 14:59:02 +0000 (14:59 +0000)]
Implement renaming in dolphinpart.
No more rename action provided by konqueror, the part provides it now.
Had to move a bit of code around in dolphin, as discussed with Peter.
projects / dolphin.git / log