Peter Penz [Thu, 20 Mar 2008 16:58:59 +0000 (16:58 +0000)]
QListView does not support having a margin for grids. Originally it has been tried to bypass this by overwriting QListView::visualRect(), but this has some side effects (see #155378 and #155575). The clean approach is to return a proper size hint in the file item delegate.
Currently a custom item delegate has been made for Dolphin, but we'll discuss whether it makes sense providing this feature already in KFileItemDelegate...
Robert Knight [Tue, 18 Mar 2008 19:16:52 +0000 (19:16 +0000)]
Bump the priority of Dolphin an application for the inode/directory mimetype. This fixes a problem where Konqueror would be preferred over Dolphin if KDE 3 and KDE 4 were both installed because the kfmclient_dir.desktop file from KDE 3 had a higher priority than Dolphin.
Peter Penz [Sat, 15 Mar 2008 17:17:30 +0000 (17:17 +0000)]
When selecting 100 files in Dolphin and the Information Panel is shown, MetaDataWidget::setFiles() blocks Dolphin for around 15 seconds. Maybe we should delegate this to a KJob... In the meantime we temporary just reset the widgets (hoping that "meantime" means < KDE 4.1 ;-)).
Peter Penz [Thu, 13 Mar 2008 21:48:24 +0000 (21:48 +0000)]
Don't force that the preview size must be >= the icon size. This gets confusing when the user uses the Zoom In/Zoom Out feature inside a view a lot (e. g. by Ctrl + scroll wheel). This is because decreasing the preview size would also decrease the icon size, but when increasing the preview size again the icon size remains... I even got confused myself by this "feature" although I knew the reason for it ;-)
Peter Penz [Thu, 13 Mar 2008 21:31:34 +0000 (21:31 +0000)]
Remove the semitransparent effect for hidden items in the IconManager, it just takes too much time at this part of the code. David Faure suggested some alternative ideas, I hope I can try them before KDE 4.1. Currently it is more important to keep the performance high.
Peter Penz [Wed, 12 Mar 2008 16:49:55 +0000 (16:49 +0000)]
As the Qt-issue 160611 is solved in Qt4.4 and Fredrik has improved KFileItemDelegate, it is not necessary anymore drawing a custom drag & drop indication.
Bugfix for konqueror for in dolphin: open in new tab/window opens one of the selected files
(See email sent to kfm-devel for details)
CCMAIL:kfm-devel@kde.org
Peter Penz [Sun, 2 Mar 2008 10:13:28 +0000 (10:13 +0000)]
fixed problems with wrong space information (I'll backport the fix to 4.0.x on Tuesday - I'm currently out of office and don't have access to my 4.0.x repository)
Peter Penz [Tue, 26 Feb 2008 06:33:21 +0000 (06:33 +0000)]
When a grouping per date is done, per default the granularity is one month. This patch increases the granularity for the last month:
- "Weeks" are used for the last 4 weeks excluding the current week.
- "Days" are used for the current week.
Additionally some cleanups of the code has been done, as the method DolphinModel::data() was too long already.
No backport will be done as new strings are introduced. The patch has been reviewed by Rafael Fernández López.
Peter Penz [Sat, 23 Feb 2008 11:59:57 +0000 (11:59 +0000)]
fixed issue that when renaming "Open office.org writer documentation.pdf" that only "Open office" is selected and ".org writer documentation" is handled as extension
Peter Penz [Thu, 21 Feb 2008 18:45:22 +0000 (18:45 +0000)]
Fixed wrong comments. Discussed with David Faure: installing an event filter works for the icons-view and details-view, but not for the column-view which uses QListView child widgets internally... We decided to leave it as it is.
Peter Penz [Thu, 21 Feb 2008 14:01:40 +0000 (14:01 +0000)]
* Install an event-filter for the view implementations. Whenever a view implementation gets the focus, it should request it's activation.
* Let the metadata widget only get the focus by clicking.
* Tried to install a similar filter for the wheel-event code duplication in the view-implementations, but the event filter is invoked _after_ the view implementation gets the wheel event... -> added a note the the 3 implementations as hint.
Peter Penz [Thu, 21 Feb 2008 12:49:11 +0000 (12:49 +0000)]
Let the DolphinController be aware on which QAbstractItemView instance he is working. This allows to connect signals from the view implementations (icons view, details view, column view) directly to the slots of the DolphinController without a helper slot.
Peter Penz [Thu, 21 Feb 2008 11:56:31 +0000 (11:56 +0000)]
Prevent code duplication by moving the duplications into the DolphinController.
Maybe it might be a good idea to let the DolphinController be aware also about his QAbstractItemView -> it might be possible to directly connect signals of the dolphin view implementations with the controller. I'll check this...
(I did not backport this cleanup as I think it has too many changes to be handled as bugfix)
Bugfix: Currently, if you open dolphin, select a bunch of files, and right click and
select Open With > whatever, all the files are opened. Which is the right
thing. However, if you hit enter to open those selected files, no file is
opened. Currently, the file is only opened if there's only *one* file
selected. The attached patch fixes this problem.
Peter Penz [Sun, 17 Feb 2008 15:50:06 +0000 (15:50 +0000)]
* if the system font is changed during Dolphin is open, take care to update the used font of all views too (assuming that the user selected "system font" as font)
* store the font weight instead of a bool property "isBold"
Peter Penz [Sat, 16 Feb 2008 14:37:13 +0000 (14:37 +0000)]
Bypassed a bug in QTreeView::mouseMoveEvent() (see comment in code). Submitted a bug-report to Trolltech, bug tracker ID is still pending (will add the ID into the code as soon as I get it).
Peter Penz [Sat, 16 Feb 2008 13:16:59 +0000 (13:16 +0000)]
Provide an option for the details view to expand folders (= tree view), as this is required for Konqueror to get back this functionality from KDE 3. It is possible in Dolphin to enable this option too, but it is set to false per default.
Peter Penz [Fri, 15 Feb 2008 23:13:47 +0000 (23:13 +0000)]
Initially I thought it's better not having code as default value inside dolphin_generalsettings.kcfg. But the check for an empty home URL in DolphinMainWindow::init() must also be done when invoking GeneralSettings::setDefaults() in StartupSettingsPage, otherwise the home URL would get empty... Using QDir::homePath() as default-value inside the *.kcfg file prevents such issues.
Robert Knight [Fri, 15 Feb 2008 18:18:21 +0000 (18:18 +0000)]
Fix flicker when resizing the central view area in Dolphin. Only applicable with Qt 4.4 with alien widgets enabled. Any widgets passed to KDirLister::setMainWindow() become native widgets because of a call to QWidget::winId() inside KIO. This fix passes the top level Dolphin window to setMainWindow() (which is already a native window) instead of the item view widget.
David Faure [Fri, 15 Feb 2008 17:01:03 +0000 (17:01 +0000)]
Add unit test for #149736 (an old bug where a javascript handler closes the window on click - and crashed konqueror again in kde 4)
(the fix is r775367 in kdelibs)
(side node: kapp->setTopWidget call removed since it doesn't care for the icon anymore, only for some startupid stuff)
Peter Penz [Thu, 14 Feb 2008 22:57:00 +0000 (22:57 +0000)]
Bypass a temporary (?) regression (?) with the current Qt 4.4 beta version: it seems like QLayout::activate()/update() don't do a relayout anymore if the sizehint of a sub widget has been changed. I'll check this again with Qt 4.4.0.
David Faure [Wed, 13 Feb 2008 18:45:20 +0000 (18:45 +0000)]
Provide the dolphinpart view modes (Icons, Details, Columns) in konqueror's View Modes menu.
(this is done using a Q_PROPERTY in the dolphin part and a signal; the available view modes for creating the menu in the first place are listed in dolphinpart.desktop)
Konqueror: cleaned up the old (complex) handling of view modes as N toolbar buttons from M services grouped by library (240 lines less!).
Dolphin: moved view mode handling to DolphinViewActionHandler, removes duplication between part and mainwindow.
projects / dolphin.git / log