Peter Penz [Fri, 29 Aug 2008 14:50:44 +0000 (14:50 +0000)]
fixed crash when a tooltip-preview for a large file is generated and the mouse leaves the item before the preview has been applied (patch provided by Laurens Vanhove)
Booo... false alarm. After going to the XMLGUI code this is perfect. I also wonder why call to setAutoSaveSettings when using Save flag, and why createGUI when using Create flag, is what setupGUI
internally is doing indeed. So nah, going back and removing those unnecessary calls. Now user preferences on toolbar places and sizes of icons are obeyed.
Do not create with Save flag. OMG, this is a very bad problem of XMLGUI... if you set that flag (which needs to be done
before createGUI, it will go to setAutoSaveSettings from KMainWindow, which will apply the personal preferences of
toolbars etc... of a NON EXISTANT GUI !. So take out this parameter from here... since we are calling anyway
setAutoSaveSettings couple lines after. I wonder if we should encourage people to not use Save flag, or we should fix
this into XMLGUI.
Peter Penz [Tue, 26 Aug 2008 22:21:50 +0000 (22:21 +0000)]
Provide a common iconsize-widget for the settings dialog of the icons-, details- and column-view. The current version still requires some improvements (Labels on the left + right, preview, ...).
Peter Penz [Tue, 19 Aug 2008 06:33:28 +0000 (06:33 +0000)]
Removed fix for negative x-coordinate again and added a TODO. We must provide a solution that works for x and y, as Dolphin in KDE 4.2 offers very large item sizes.
Very rough initial attempt at previews-in-tooltip for Konqueror and Dolphin. Still needs extensive work in positioning, scaling/ padding items to fit, and timing things so that the previews are more likely to have been generated when the tooltip is positioned and displayed.
Peter Penz [Mon, 18 Aug 2008 19:30:25 +0000 (19:30 +0000)]
Column view + detail view: use different settings for preview and icon size like in the icon view for consistency. The setting dialogs will be adjusted later.
Diego Iastrubni [Fri, 15 Aug 2008 23:02:01 +0000 (23:02 +0000)]
For the URL control of Dolphin and Konqueror to be LTR on RTL desktops (those are URLs, and are not affected by the direction of the desktop).
Force the filterbar of Dolphin to be LTR as well, as again it deals with files/directories which are english/latin letters most of the time.
Change the location of the methods. Now the algorithm is only applied when needed (when the view is not flat, that is, the tree view is enabled, and you can select items from different level of
hierarchy). This patch was waiting in my hard disk for being committed...
Sascha Peilicke [Thu, 14 Aug 2008 10:12:32 +0000 (10:12 +0000)]
Fix for show_filter_bar action of tools-menu, which is not correctly set (when the corresponding option is checked in the startupsettingsview) at application start-up.
Peter Penz [Tue, 12 Aug 2008 19:43:55 +0000 (19:43 +0000)]
Disable the alternating row colors when the details view is inactive. This solves the problem that when having a split view that too less contrast is given to be aware about the activation state.
Peter Penz [Tue, 12 Aug 2008 18:36:49 +0000 (18:36 +0000)]
Provide functionality for auto-expanding folders (the whole patch has been provided by Simon St James). The setting is currently not offered in the GUI, as some minor remaining issues must be fixed.
Peter Penz [Tue, 5 Aug 2008 21:47:02 +0000 (21:47 +0000)]
Now the IconManager does not depend anymore from Dolphin classes. If at least a second application requests having this functionality, it could be moved to kdelibs (for sure an API review is necessary, d-pointer, improved documentation etc.). Maybe the FolderView Plasmoid wants this?
Peter Penz [Sun, 3 Aug 2008 10:01:53 +0000 (10:01 +0000)]
Prevent that Konqueror crashs if pressing F2 (= Rename) although no items are selected. TODO: disable the rename action (and other selection dependent actions) when no items are selected.
Peter Penz [Sat, 26 Jul 2008 13:46:58 +0000 (13:46 +0000)]
Provide a 'int selectedItemsCount() const' interface for performance reasons, so that code which just needs to know whether items have been selected does not need to invoke selectedItems().count(), which is quite expensive.
The space info widget now inherits KCapacityBar. Two things to check:
- Align vertically the text correctly
- Minimum width of the widget (not forcing it to 200)
Peter Penz [Mon, 30 Jun 2008 17:12:03 +0000 (17:12 +0000)]
* use existing KFileItem also for the selection instead of creating a new KFileItem from the URL
* don't invoke fileItem() if a multiple selection is provided
Peter Penz [Mon, 30 Jun 2008 16:37:08 +0000 (16:37 +0000)]
Move the "Find File..." action from DolphinMainWindow to DolphinViewActionHandler, so that is used in DolphinPart and hence also in Konqueror. Thanks to Bram for the patch!
Peter Penz [Sun, 29 Jun 2008 21:40:07 +0000 (21:40 +0000)]
The check whether there is a cut-selection when receiving a preview consumes 12 % (!) of the runtime in addToPreviewQueue(). The check is now done only once before starting the preview generation and when the clipboard data has been changed.
Peter Penz [Sun, 29 Jun 2008 21:04:43 +0000 (21:04 +0000)]
Move the block for resizing the preview, applying an item effect + border to the slot where the preview has been received. This reduces the blocking of the GUI for the following usecase:
- folder with 1000 items
- ~30 items are visible
Old approach:
- Show the 30 items as soon as possible.
- Receive preview and add it to the queue. This is done asynchronously 970 times (no UI blocking).
- Iterate through 970 items, resize, apply item effect + border and apply the preview to the model (-> blocking of UI thread for more than 3 seconds).
New approach:
- Show the 30 items as soon as possible.
- Receive preview, resize it, apply item effect + border and add it to the queue. This is done asynchronously 970 times (no UI blocking).
- Iterate through 970 items and apply the preview to the model (-> UI thread is blocked only very short).
projects / dolphin.git / log