Peter Penz [Fri, 26 Nov 2010 17:54:49 +0000 (17:54 +0000)]
Also reconnect signals for the directory lister when changing the view or the URL, as the directory lister might change in the case of the column view (based on a patch from Frank Reininghaus)
In the item view constructors, call setFocus() only after
m_extensionsFactory is initialised. This fixes a possible crash in
Konqueror when changing the settings or manipulating tabs.
Backup and restore the zoom level in
bug234600_overlappingIconsWhenZooming() such that it's the standard
value again in the following test. Also verify that the zoom level is
as expected after each call to DolphinView::setZoomLevel(int).
Make sure that an item's visualRect in the Details View is not wider
than the "Name" column. Fixes keyboard navigation problems if files
with very wide names are present in the current folder.
Peter Penz [Sat, 20 Nov 2010 11:29:54 +0000 (11:29 +0000)]
Use the inactive text color for all columns except the name column. This indicates for the user that hovering other columns does not change the actions context.
Peter Penz [Thu, 18 Nov 2010 16:18:07 +0000 (16:18 +0000)]
- When showing the trash content, use the details view with path as default view
- Assure that the original path is shown for the trash protocol within Dolphin
Verify that the pointer m_extensionsFactory is not 0 before
dereferencing it. Fixes a possible crash when initialising the
Details View in Konqueror, caused by an indirect resizing the of
columns before the DolphinDetailsView constructor is finished.
Peter Penz [Thu, 11 Nov 2010 19:19:40 +0000 (19:19 +0000)]
Remove the "Remove folder restriction" button from the Filter Panel as discussed with Sebastian Trüg. This will be replaced by the "From Here" and "Everywhere" buttons later.
Peter Penz [Wed, 10 Nov 2010 22:27:06 +0000 (22:27 +0000)]
Don't try to apply the services-settings, if they have not even been shown. This fixes the issue that the version-control settings get reset when changing another setting.
2. Remove some debug output from DolphinDetailsViewTest - it seems
that the test failure I saw on cdash.org is due to a failing kioslave,
which is probably not Dolphin's fault.
Peter Penz [Mon, 8 Nov 2010 16:13:10 +0000 (16:13 +0000)]
Use KFileItem::mostLocalUrl() instead of KFileItem::url() for the "Path" column. This assures that a path is shown also for the nepomuksearch:/ protocol.
Peter Penz [Fri, 5 Nov 2010 17:32:46 +0000 (17:32 +0000)]
Take care to listen for changes of the settings-widgets after loadSettings() is invoked, otherwise it is possible that a change is accidently indicated.
Peter Penz [Thu, 4 Nov 2010 17:27:11 +0000 (17:27 +0000)]
Interface cleanup: The DolphinView should not expose QAbstractItemView-specific things like QItemSelectionModel. Just providing interfaces for KFileItem and KUrl will make it easier in future to change the view-implementations internally to QML-specific itemviews or whatever.
Peter Penz [Mon, 1 Nov 2010 12:31:44 +0000 (12:31 +0000)]
Assure that always the search-box is shown instead of the URL-navigator if a Nepomuk-URL is requested. We still have to think about how to show queries that cannot be represented by the facet-widget, but at least it is sure that this kind of information should not be shown by the URL navigator.
Peter Penz [Fri, 29 Oct 2010 15:12:59 +0000 (15:12 +0000)]
Don't do an automatic horizontal scrolling, if the user has adjusted the horizontal scrollbar. The autoscrolling gets reactivated again if the vertical scrollbar has been moved by the user.
Peter Penz [Wed, 27 Oct 2010 20:11:46 +0000 (20:11 +0000)]
- Allow to disable the automatic horizontal scrolling of the Folders Panel
- Remember the 'Show Hidden Files' setting
- Improve the autoscroll behavior
- Fix issue that expanding folders might not increase the horizontal width
- Fix issue that the selected item might get hidden by the horizontal scrollbar
Peter Penz [Tue, 26 Oct 2010 13:11:37 +0000 (13:11 +0000)]
Apply the facets-patch written by Sebastian Trüg, which allows to filter search results in a very comfortable way. A lot of finetuning is necessary (e.g. the custom filter-prototypes from Dolphin will get removed etc). This will be done during the next weeks.
I've seen the test fail due to timeout at
http://my.cdash.org/index.php?project=kdebase&date=
Maybe some debug output helps to find the cause for this.
Add a second Dolphin unit test (for a regression in DolphinDetailsView
which has been fixed recently). This commit also adds a new class
TestHelper which provides some funtionality that most Dolphin unit
tests will need. I hope that this makes implementing additional tests
as easy as possible :-)
Add a first unit test for Dolphin, which verifies that the fix for one
of the problems related to Dolphin's modifications to QTreeView works
as it should.
This is only a small start, but I hope that we can cover at least the
basic functionality of DolphinView, the three item views and possibly
a couple of other classes with a rather stable API soon.
David Faure [Fri, 15 Oct 2010 00:15:13 +0000 (00:15 +0000)]
Enable dropping of raw data, like one could do in KDE3. It's actually working fine with text data for instance,
only image data is still an issue due to bugs in Qt. This will be in KDE 4.6.
CCBUG: 159337
Peter Penz [Wed, 13 Oct 2010 15:25:58 +0000 (15:25 +0000)]
The &-shortcut from another action is not set until the action has been shown at least once. To bypass this issue in the context-menu when pressing SHIFT, the text and &-shortcut is applied manually.
Peter Penz [Sun, 10 Oct 2010 17:11:55 +0000 (17:11 +0000)]
Update the statusbar also during loading the items, not only after the loading has been completed. This fixes the issue that no current item-count is shown when doing a search.