Peter Penz [Sat, 29 Mar 2008 14:54:56 +0000 (14:54 +0000)]
Move the pasteIntoFolder() method from the contextmenu into DolphinView. This allows to show the information inside the statusbar, that the paste operation has been completed (also some code duplication can be prevented by the way).
Peter Penz [Sat, 29 Mar 2008 07:44:03 +0000 (07:44 +0000)]
The paste operation should ignore the current selection to behave similar as Konqueror and other file managers. Only if a context menu for a folder is opened, a pasting should be done into this folder.
Some internal cleanups are still required (see TODO comments), so that after finishing the operation an indication can be given to the user in the statusbar (must go for breakfast now, otherwise I'll eat my keyboard...).
Peter Penz [Fri, 28 Mar 2008 06:32:41 +0000 (06:32 +0000)]
* minor coding style fixes
* replaced "Free disk space could not be determined" by "Unknown size", as the string would be too long fitting into the space information widget
Jeff Mitchell [Fri, 28 Mar 2008 01:21:19 +0000 (01:21 +0000)]
This value was still wrong, because I mixed up kibibytes and kilobytes. Assuming KDiskFreeSpace is really returning kB = 1000 bytes instead of kiB as according to Si rules,
this value should now be correct (as opposed to the original code which assumed it was actually returning kibibytes, or my incorrect fix which multiplied the kibibyte value by
a kilobyte factor to pass into convertSize.
Jeff Mitchell [Thu, 27 Mar 2008 20:36:05 +0000 (20:36 +0000)]
If KDiskFreeSpace doesn't work for some reason it never emits foundMountPoint, and since Dolphin never checked for done(), it'd sit there waiting on the job.
David Faure [Tue, 25 Mar 2008 21:39:05 +0000 (21:39 +0000)]
Use new key in .protocol files, archiveMimetype, to know which kioslave can handle which type of archive in a generic way.
Used that in dolphin and in konqueror (and in the filetypes config module, to show the right default value for those mimetypes).
This way Urs can extend this mechanism with the p7zip kioslave in the future.
CCMAIL: uwolfer@kde.org, peter.penz@gmx.at
Peter Penz [Sun, 23 Mar 2008 17:40:14 +0000 (17:40 +0000)]
The background for the image previews is already filled, so there is no need adding a border with the background color again (this also fixes a one-pixel-issue that shaded the right/bottom border in a wrong way).
Peter Penz [Sun, 23 Mar 2008 15:52:31 +0000 (15:52 +0000)]
Show hovered items in the Information panel also when items are selected. If the cursor is above the viewport in this case, show the selection information again.
Peter Penz [Sun, 23 Mar 2008 01:56:18 +0000 (01:56 +0000)]
Performance boost for previews that are already available in the cache: apply the previews in larger blocks instead of applying them immediately after getting the signal 'gotPreview' from the PreviewJob. Now the previews in Konqueror and Dolphin are as fast as in the good old KDE 3 days :-)
Sebastian Trueg [Fri, 21 Mar 2008 21:05:05 +0000 (21:05 +0000)]
This is the first step towards a better looking and more usable metadata GUI.
- A nicer comment widget shows a popup to edit the comment.
- A tag cloud replaces the ugly tagwidget from libnepomuk.
The plan is to use Dolphin as a testbed to optimize the look and then
move at least the tagcloud to libnepomuk to make it available for all apps
since this is a common feature.
So please test it and provide feedback. The layout is still cluttered. So we
also need feedback on that. And of course on the usability.
Apart from the GUI Dolphin now uses the mass metadata update job to perform
metadata updates on many files in an async KJob without blocking the GUI.
This is another candidate for public API at some point.
Peter Penz [Thu, 20 Mar 2008 16:58:59 +0000 (16:58 +0000)]
QListView does not support having a margin for grids. Originally it has been tried to bypass this by overwriting QListView::visualRect(), but this has some side effects (see #155378 and #155575). The clean approach is to return a proper size hint in the file item delegate.
Currently a custom item delegate has been made for Dolphin, but we'll discuss whether it makes sense providing this feature already in KFileItemDelegate...
Robert Knight [Tue, 18 Mar 2008 19:16:52 +0000 (19:16 +0000)]
Bump the priority of Dolphin an application for the inode/directory mimetype. This fixes a problem where Konqueror would be preferred over Dolphin if KDE 3 and KDE 4 were both installed because the kfmclient_dir.desktop file from KDE 3 had a higher priority than Dolphin.
Peter Penz [Sat, 15 Mar 2008 17:17:30 +0000 (17:17 +0000)]
When selecting 100 files in Dolphin and the Information Panel is shown, MetaDataWidget::setFiles() blocks Dolphin for around 15 seconds. Maybe we should delegate this to a KJob... In the meantime we temporary just reset the widgets (hoping that "meantime" means < KDE 4.1 ;-)).
Peter Penz [Thu, 13 Mar 2008 21:48:24 +0000 (21:48 +0000)]
Don't force that the preview size must be >= the icon size. This gets confusing when the user uses the Zoom In/Zoom Out feature inside a view a lot (e. g. by Ctrl + scroll wheel). This is because decreasing the preview size would also decrease the icon size, but when increasing the preview size again the icon size remains... I even got confused myself by this "feature" although I knew the reason for it ;-)
Peter Penz [Thu, 13 Mar 2008 21:31:34 +0000 (21:31 +0000)]
Remove the semitransparent effect for hidden items in the IconManager, it just takes too much time at this part of the code. David Faure suggested some alternative ideas, I hope I can try them before KDE 4.1. Currently it is more important to keep the performance high.
Peter Penz [Wed, 12 Mar 2008 16:49:55 +0000 (16:49 +0000)]
As the Qt-issue 160611 is solved in Qt4.4 and Fredrik has improved KFileItemDelegate, it is not necessary anymore drawing a custom drag & drop indication.
Bugfix for konqueror for in dolphin: open in new tab/window opens one of the selected files
(See email sent to kfm-devel for details)
CCMAIL:kfm-devel@kde.org
Peter Penz [Sun, 2 Mar 2008 10:13:28 +0000 (10:13 +0000)]
fixed problems with wrong space information (I'll backport the fix to 4.0.x on Tuesday - I'm currently out of office and don't have access to my 4.0.x repository)
Peter Penz [Tue, 26 Feb 2008 06:33:21 +0000 (06:33 +0000)]
When a grouping per date is done, per default the granularity is one month. This patch increases the granularity for the last month:
- "Weeks" are used for the last 4 weeks excluding the current week.
- "Days" are used for the current week.
Additionally some cleanups of the code has been done, as the method DolphinModel::data() was too long already.
No backport will be done as new strings are introduced. The patch has been reviewed by Rafael Fernández López.
Peter Penz [Sat, 23 Feb 2008 11:59:57 +0000 (11:59 +0000)]
fixed issue that when renaming "Open office.org writer documentation.pdf" that only "Open office" is selected and ".org writer documentation" is handled as extension
Peter Penz [Thu, 21 Feb 2008 18:45:22 +0000 (18:45 +0000)]
Fixed wrong comments. Discussed with David Faure: installing an event filter works for the icons-view and details-view, but not for the column-view which uses QListView child widgets internally... We decided to leave it as it is.
Peter Penz [Thu, 21 Feb 2008 14:01:40 +0000 (14:01 +0000)]
* Install an event-filter for the view implementations. Whenever a view implementation gets the focus, it should request it's activation.
* Let the metadata widget only get the focus by clicking.
* Tried to install a similar filter for the wheel-event code duplication in the view-implementations, but the event filter is invoked _after_ the view implementation gets the wheel event... -> added a note the the 3 implementations as hint.
Peter Penz [Thu, 21 Feb 2008 12:49:11 +0000 (12:49 +0000)]
Let the DolphinController be aware on which QAbstractItemView instance he is working. This allows to connect signals from the view implementations (icons view, details view, column view) directly to the slots of the DolphinController without a helper slot.
Peter Penz [Thu, 21 Feb 2008 11:56:31 +0000 (11:56 +0000)]
Prevent code duplication by moving the duplications into the DolphinController.
Maybe it might be a good idea to let the DolphinController be aware also about his QAbstractItemView -> it might be possible to directly connect signals of the dolphin view implementations with the controller. I'll check this...
(I did not backport this cleanup as I think it has too many changes to be handled as bugfix)
Bugfix: Currently, if you open dolphin, select a bunch of files, and right click and
select Open With > whatever, all the files are opened. Which is the right
thing. However, if you hit enter to open those selected files, no file is
opened. Currently, the file is only opened if there's only *one* file
selected. The attached patch fixes this problem.
projects / dolphin.git / log