Peter Penz [Wed, 31 Jan 2007 22:03:35 +0000 (22:03 +0000)]
Queue error messages so that a currently shown error message is not replaced until the user confirmed the reading. If there are no pending error messages and a timeout has been exceeded, the currently shown error messages automatically fades out as soon as the user triggered another action. This behavior should correspond to Ellens suggestions (I hope :-)).
Peter Penz [Tue, 30 Jan 2007 19:38:44 +0000 (19:38 +0000)]
Improvements for error messages:
- increase/decrease size on demand and hide progress bar or space information if required
- provide close button
TODO: the code is far from being finished (e. g. no queueing of pending error messages, close button looks fugly, ...), but I decided to commit the changes to prevent getting an inconsistent state in combination with other commits...
Peter Penz [Fri, 26 Jan 2007 19:58:41 +0000 (19:58 +0000)]
Further optimizations: do a delayed update of the geometry. This leads to a reduced flickering/resizing when e. g. the view is split or the window is resized.
Peter Penz [Thu, 25 Jan 2007 22:28:04 +0000 (22:28 +0000)]
First step for making the details view usable again:
- accept drops
- Automatically resize the columns in a way that the whole available width is used by stretching the width of the 'Name' column. Qt4's QTreeView really rocks, only a few lines of code had been necessary to get this behavior :-)
Peter Penz [Thu, 25 Jan 2007 21:06:59 +0000 (21:06 +0000)]
David's patches come in faster than light: removed code duplication, as a proper default implementation is now available in KonqUndoManager::UiInterface::copiedFileWasModified().
Peter Penz [Thu, 25 Jan 2007 19:37:19 +0000 (19:37 +0000)]
Use custom implementation of KonqUndoManager::UiInterface for Dolphin. This allows that error messages are shown inside the status bar of Dolphin (otherwise a modal error dialog containing an "OK" button would be opened).
Peter Penz [Thu, 25 Jan 2007 17:56:29 +0000 (17:56 +0000)]
Cleanup of URL drop handling (simplified code, modifier keys work again). After further minor cleanups it looks like KonqOperations::doDrop() can be used later on :-)
Peter Penz [Thu, 25 Jan 2007 16:56:52 +0000 (16:56 +0000)]
Use KNewMenu instead of custom implementation of Dolphin. TODO: currently errors are indicated automatically in a message box KNewMenu. In Dolphin modal dialogs having only an "OK" button are not used -> it would be nice if Dolphin could handle the errors in a custom way.
Peter Penz [Tue, 23 Jan 2007 18:33:43 +0000 (18:33 +0000)]
Minor adjustments and cleanups in the statusbar:
- prevent a flickering of the space information if a folder has been changed
- assure that no progress bar and space information is shown if an error is displayed currently
Peter Penz [Sun, 21 Jan 2007 22:12:49 +0000 (22:12 +0000)]
- Fixed crash when showing "Open With..." items of the context menu: the model index from the proxy model was used instead of the model index from the KDirModel.
- Use QMenu::addSeparator() instead of QMenu::insertSeparator().
Peter Penz [Sun, 21 Jan 2007 21:20:37 +0000 (21:20 +0000)]
Cleanup of DolphinContextMenu:
- don't use any deprecated methods anymore
- temporary deactivated the "Open With..." submenu. There's a crash in KDirModel when invoking KFileItem::mimetype(); although the same code worked with an older version of kdelibs, I assume this is a Dolphin issue -> I'll do some further analyses...
Peter Penz [Thu, 18 Jan 2007 06:32:21 +0000 (06:32 +0000)]
Replaced Dolphins UndoManager and DolphinCommand by KonqUndoManager and KonqOperations. There are still some minor open issues left (renaming of multiple selected files, no undo support for KonqOperations::mkdir(), redo, ...), but all in all it absolutely makes sense to use a shared code for those operations.
Peter Penz [Mon, 15 Jan 2007 18:28:19 +0000 (18:28 +0000)]
Minor performance improvement. As Dominic Battre pointed out correctly, it is not necessary to calculate the value of both numbers, it is enough to compare the weight.
Peter Penz [Fri, 12 Jan 2007 21:21:06 +0000 (21:21 +0000)]
Fixed issue in method naturalCompare: strings having numbers with the same amount of digits got the same weight. E. g. naturalCompare("Item 10", "Item 11") returned 0 instead of a value < 0.
Peter Penz [Fri, 12 Jan 2007 20:24:23 +0000 (20:24 +0000)]
Natural sorting fix: assure that directories are sorted always before files as Ellen has recommended. One minor issue is left: when the sort order is descending, the natural sorting result is:
item 10.jpg
item 11.jpg
item 2.jpg
item 1.jpg
instead of
item 11.jpg
item 10.jpg
item 2.jpg
item 1.jpg
Peter Penz [Sun, 7 Jan 2007 21:28:41 +0000 (21:28 +0000)]
Fixed issue that the view properties have not been used for the home directory when starting Dolphin. Also some (very minor) updates have been done regarding the coding guidelines (I'm a nasty nitpicker ;-)).
Peter Penz [Sun, 7 Jan 2007 21:10:52 +0000 (21:10 +0000)]
Remember the position and size of the docks by using QMainWindow::saveState() and QMainWindow::restoreState(). I assume that in KDE 4 there will be a generic mechanism to store the position and size of docks like done for toolbars -> this is only a temporary solution to have a usable version of Dolphin in the meantime.
Peter Penz [Sun, 7 Jan 2007 09:47:05 +0000 (09:47 +0000)]
Allow that Dolphin can also be used with global view properties. Per default Dolphin remembers the view properties for each directory, but from the feedback I've got there is a not ignorable amount of people who prefer having global view properties instead.
Holger Freyther [Sun, 24 Dec 2006 00:03:40 +0000 (00:03 +0000)]
-Use QSortFilterProxyModel for filtering instead of KDirList::setFilterName
-Map DolphinView::Sorting to a column of the KDirModel and sort this column
-Reimplement QAbstractItemModel::sort(int,SortOrder) to keep track of the
sorted column and order as dolphin uses this in the config dialogs. We will
now work correctly if a view changes sorting.
Holger Freyther [Sat, 23 Dec 2006 12:52:53 +0000 (12:52 +0000)]
The answer is either clear() or filterChanged(). Anyone knows this better?
I have decided to use clar as this is the most conservative choiche I could
make. Actually I would love to call QSortFilterProxyModelPrivate::sort as
the mapping does not change, as we do not filter rows ATM...
Peter Penz [Wed, 20 Dec 2006 20:50:32 +0000 (20:50 +0000)]
- Performance optimization in DolphinView::loadDirectory() (don't store the view properties for each property individually)
- Get rid of methods which are not used anymore due to moving to KDirModel.
- Respect GeneralSettings::globalViewProps() setting when storing view properties.
Peter Penz [Wed, 20 Dec 2006 19:10:39 +0000 (19:10 +0000)]
Let the user chose whether view properties should be remembered for each directory or whether they should be valid globally. Per default the view properties are remembered for each directory. For testing purposes the MIME type information is shown per default in the icons mode (thanks to Fredrik for the cool implementation in KFileItemDelegate!).
Peter Penz [Sun, 17 Dec 2006 13:47:45 +0000 (13:47 +0000)]
Use KonqMimeData for the cut- and copy-operation instead of using bool property inside DolphinMainWindow. This assures that cut- and copy-operations also work within multiple Dolphin main windows.
Peter Penz [Fri, 15 Dec 2006 01:56:57 +0000 (01:56 +0000)]
Update for using a proxy model: prevent accessing the model by model() and doing a cast do KDirModel afterwards. Instead the access to the KDirModel is done by a member variable. Still the proxy model does not seem to work and leads to a crash as soon as the QListView should work with the proxy model -> in the meantime in line 112 from DolphinView.cpp the KDirModel is used instead of the proxy model.
Peter Penz [Thu, 14 Dec 2006 23:49:30 +0000 (23:49 +0000)]
Use QSortFilterProxyModel for sorting KFileItems (thanks to Fredrik for this hint!). TODO: the implementation does not work yet, as QSortFilerProxyModel::lessThan() is not invoked; I'm too tired currently for finding the root of this ;-)
Peter Penz [Wed, 13 Dec 2006 07:41:11 +0000 (07:41 +0000)]
Instead of having a the 3 view modes "icons", "details" and "previews" only 2 view modes are used now: "icons" and "details". Whether a preview is shown or not is part of the directory view properties. This also means that it will be possible to show previews in the "details" view in future releases.
Peter Penz [Fri, 8 Dec 2006 23:41:08 +0000 (23:41 +0000)]
Cleanup of signal/slot handling between the dolphin view and the main window: now the main window listens to the signals from the dolphin view and connects to private slots (previously the dolphin view connected to public slots of the main window). Also prevent naming all slots by the prefix 'slot', describe instead what the method does.
Peter Penz [Thu, 7 Dec 2006 20:51:05 +0000 (20:51 +0000)]
Apply the view properties to sub directories without using a modal window. This allows the user to proceed with the work during the view properties are applied.
Peter Penz [Mon, 4 Dec 2006 06:37:20 +0000 (06:37 +0000)]
First step of cleaning up the view properties: inheriting of viewproperties does not work with the current approach of directoryviewpropertysettings.kcfg (2 nodes would be required for each directory, only one is used at the moment). Therefor the valid_for_subdirs property has been removed and the implementation model will be adjusted to match 1:1 to the users model. TODO: improve the viewpropertiesdialog be able to apply viewproperties recursively to sub directories.
Kevin Ottens [Wed, 29 Nov 2006 18:09:26 +0000 (18:09 +0000)]
Get ride of the sidebar and use dockwidgets instead.
Default is now three panes, but the dockwidgets can be stacked, etc. to
the user convenience.
There's a slight loss in feature since I disabled dockwidgets hiding,
it's simply because some rework is still needed in kdelibs and Qt to
make them work correctly.
Holger Freyther [Wed, 29 Nov 2006 09:30:41 +0000 (09:30 +0000)]
Changes to Undo/Redo in regard to ProgressIndicator
It was not important to know where the operation was
executed, it is important where undo/redo was clicked
and this solely indicates where the progress should be
shown.
Now undo/redo get the MainWindow and can pass that to
ProgressIndicator.
I'm about to revive m_progressIndicator again
Holger Freyther [Wed, 29 Nov 2006 00:20:32 +0000 (00:20 +0000)]
Do not crash with the null pointer, this is a hack/workaround as we
will switch to KonqUndoManager anyway. The difficulty is we would
need one UndoManager for DolphinMainWindow which we won't do/have with
KonqUndoManager so I avoid wasting my time cleaning up this bit, so
progress information might be a bit wrong in regards to the amount of
total steps...
Holger Freyther [Wed, 29 Nov 2006 00:02:19 +0000 (00:02 +0000)]
Make it (almost) possible to have more than one Dolphin KMainWindow
Create a DolphinApplication, holding DolphinMainWindows and update
the code to use the DolphinView to get the MainWindow, or get a ptr
to the MainWindow directly. Or if all windows are effected go through
the DolphinApplication to update every mainwindow.
The UndowManager and ProgressIndicator have a rather strange relationship
and will need some more attention but as UndoManager will be killed
anyway I have skipped this.
More cleanup, debugging and thinking is needed.
projects / dolphin.git / log