Peter Penz [Wed, 28 Feb 2007 19:38:25 +0000 (19:38 +0000)]
Don't use assertions here. The result of the preview might have been done although the model has changed (e. g. by changed the folder during a preview job is working) -> it's possible to get an invalid model index.
Peter Penz [Wed, 28 Feb 2007 19:17:26 +0000 (19:17 +0000)]
Jippie: file previews are generated again! Thanks to Fredrik for giving me a hint how to do it (if I would have known that it is so easy, I'd have implemented it already some weeks ago...). It's very nice that the details view now also is able to show previews (Kudos to Interview & KDirModel).
Peter Penz [Wed, 28 Feb 2007 06:32:56 +0000 (06:32 +0000)]
Instead of using the ListMode of the icon view for the left to right alignment, still use the IconMode and adjust the alignment properties. Minor issue open: it seems that KFileItemDelegate currently does not care about the alignment properties of QStyleOptionViewItem, it always centers the the icons + text; I'll have a look on this...
Peter Penz [Tue, 27 Feb 2007 20:46:21 +0000 (20:46 +0000)]
The icons view and details view don't use hardcoded (test-) values anymore, instead the settings for fonts, grid size, ... are read out. The settings dialogs itself will be reworked later if it is clear what should be configurable in which manner. At least the current settings dialog allows to play with the new capabilities we got by KFileItemDelegate, just lets see what we can improve later on...
Peter Penz [Sun, 25 Feb 2007 22:42:47 +0000 (22:42 +0000)]
As Aaron suggested: use the global setting for "Show Delete command" instead of using a custom Dolphin setting. I hope I used the reworked KConfig classes in a correct manner (setGroup() has been marked as deprecated, Konqueror still uses those deprecated methods).
Peter Penz [Sun, 25 Feb 2007 20:51:05 +0000 (20:51 +0000)]
Implemented one of the most often requested features for Dolphin: allow that the command 'Delete' is shown in the context menu to bypass the trash. Like in Konqueror the default setting is that the 'Delete' command is not shown. TODO: currently this is a custom setting of Dolphin. Konqueror uses the global settings from KDE for this -> should this be changed to use the global setting instead?
Oscar Blumberg [Thu, 22 Feb 2007 16:45:53 +0000 (16:45 +0000)]
* Starts to add Nepomuk supports to dolphin (currently, only annotations are supported)
* Little changes in InfoSidebarPage (no more multiple label for infos & Q3Layout>QLayout)
* Support infos for multiple files (only total size, what else ?)
Peter Penz [Sun, 18 Feb 2007 11:20:32 +0000 (11:20 +0000)]
View properties dialog: Allow to reset all view properties (the timestamp is used for this). Additionally it is possible for the user to specify whether the current view properties should be the default for new directories.
Peter Penz [Sat, 17 Feb 2007 20:04:06 +0000 (20:04 +0000)]
Improve usability of the viewproperties dialog: use 2 radiobuttons instead of one checkbox to make clear where the view properties are applied. Separate the apply-to-group visually from the 'Use as default for new folders' checkbox.
Peter Penz [Sat, 17 Feb 2007 18:25:46 +0000 (18:25 +0000)]
Allow the pasting of a text clipboard content to the URL navigator by pressing the middle mouse button. Although this is quite a hidden feature, I think it makes happy a lot of people who just want to paste a URL available as text to the URL navigator without switching from the breadcrump view to the traditional view.
Very nice "side effect": the URL navigator is now completely flicker free when changing URLs because of using the whole available width :-)
TODO: I'm not 100 % sure whether checking the middle mousebutton by 'if (event->button() == Qt::MidButton) { ... }' is the right approach (maybe there is a more generic way to check the 'paste button').
Peter Penz [Sat, 17 Feb 2007 14:46:54 +0000 (14:46 +0000)]
Prevent a flickering of the URL navigator buttons by reusing existing buttons (before all items have been deleted and recreated). The flickering is still not solved to 100 %, but a lot better than before. @Aaron: I did not change anything inside the logic of the code -> the net protocol code works the same as in our internal KDE3 working prototype of Dolphin
Peter Penz [Sat, 17 Feb 2007 10:31:52 +0000 (10:31 +0000)]
Cleanup of the URL navigator, so that the DolphinMainWindow and the DolphinView are not used anymore. This will make it easier for us later on when moving the URL navigator outside Dolphin to make it accessable for other parts. Currently the bookmarks are still accessed by DolphinSettings, but this will be cleaned up later...
Peter Penz [Fri, 16 Feb 2007 17:03:02 +0000 (17:03 +0000)]
Reanimated drag & drop support again after introducing the DolphinController. It is now also possible to move the items inside an icon view like discussed on kde-devel/kde-usability.
Peter Penz [Wed, 14 Feb 2007 21:54:24 +0000 (21:54 +0000)]
Step one for having DolphinParts for the icons and details view, which can be used by Konqueror. TODO: currently dropping of items is deactivated, as I want to wait for Davids feedback whether the direction is ok.
Peter Penz [Mon, 5 Feb 2007 23:17:15 +0000 (23:17 +0000)]
Only group the directories before items if the KDirModel::Name column is sorted. If the sorting is done e. g. by the date column, it is confusing when still directories are seperated from items.
Peter Penz [Wed, 31 Jan 2007 22:03:35 +0000 (22:03 +0000)]
Queue error messages so that a currently shown error message is not replaced until the user confirmed the reading. If there are no pending error messages and a timeout has been exceeded, the currently shown error messages automatically fades out as soon as the user triggered another action. This behavior should correspond to Ellens suggestions (I hope :-)).
Peter Penz [Tue, 30 Jan 2007 19:38:44 +0000 (19:38 +0000)]
Improvements for error messages:
- increase/decrease size on demand and hide progress bar or space information if required
- provide close button
TODO: the code is far from being finished (e. g. no queueing of pending error messages, close button looks fugly, ...), but I decided to commit the changes to prevent getting an inconsistent state in combination with other commits...
Peter Penz [Fri, 26 Jan 2007 19:58:41 +0000 (19:58 +0000)]
Further optimizations: do a delayed update of the geometry. This leads to a reduced flickering/resizing when e. g. the view is split or the window is resized.
Peter Penz [Thu, 25 Jan 2007 22:28:04 +0000 (22:28 +0000)]
First step for making the details view usable again:
- accept drops
- Automatically resize the columns in a way that the whole available width is used by stretching the width of the 'Name' column. Qt4's QTreeView really rocks, only a few lines of code had been necessary to get this behavior :-)
Peter Penz [Thu, 25 Jan 2007 21:06:59 +0000 (21:06 +0000)]
David's patches come in faster than light: removed code duplication, as a proper default implementation is now available in KonqUndoManager::UiInterface::copiedFileWasModified().
Peter Penz [Thu, 25 Jan 2007 19:37:19 +0000 (19:37 +0000)]
Use custom implementation of KonqUndoManager::UiInterface for Dolphin. This allows that error messages are shown inside the status bar of Dolphin (otherwise a modal error dialog containing an "OK" button would be opened).
Peter Penz [Thu, 25 Jan 2007 17:56:29 +0000 (17:56 +0000)]
Cleanup of URL drop handling (simplified code, modifier keys work again). After further minor cleanups it looks like KonqOperations::doDrop() can be used later on :-)
Peter Penz [Thu, 25 Jan 2007 16:56:52 +0000 (16:56 +0000)]
Use KNewMenu instead of custom implementation of Dolphin. TODO: currently errors are indicated automatically in a message box KNewMenu. In Dolphin modal dialogs having only an "OK" button are not used -> it would be nice if Dolphin could handle the errors in a custom way.
Peter Penz [Tue, 23 Jan 2007 18:33:43 +0000 (18:33 +0000)]
Minor adjustments and cleanups in the statusbar:
- prevent a flickering of the space information if a folder has been changed
- assure that no progress bar and space information is shown if an error is displayed currently
Peter Penz [Sun, 21 Jan 2007 22:12:49 +0000 (22:12 +0000)]
- Fixed crash when showing "Open With..." items of the context menu: the model index from the proxy model was used instead of the model index from the KDirModel.
- Use QMenu::addSeparator() instead of QMenu::insertSeparator().
Peter Penz [Sun, 21 Jan 2007 21:20:37 +0000 (21:20 +0000)]
Cleanup of DolphinContextMenu:
- don't use any deprecated methods anymore
- temporary deactivated the "Open With..." submenu. There's a crash in KDirModel when invoking KFileItem::mimetype(); although the same code worked with an older version of kdelibs, I assume this is a Dolphin issue -> I'll do some further analyses...
Peter Penz [Thu, 18 Jan 2007 06:32:21 +0000 (06:32 +0000)]
Replaced Dolphins UndoManager and DolphinCommand by KonqUndoManager and KonqOperations. There are still some minor open issues left (renaming of multiple selected files, no undo support for KonqOperations::mkdir(), redo, ...), but all in all it absolutely makes sense to use a shared code for those operations.
Peter Penz [Mon, 15 Jan 2007 18:28:19 +0000 (18:28 +0000)]
Minor performance improvement. As Dominic Battre pointed out correctly, it is not necessary to calculate the value of both numbers, it is enough to compare the weight.
Peter Penz [Fri, 12 Jan 2007 21:21:06 +0000 (21:21 +0000)]
Fixed issue in method naturalCompare: strings having numbers with the same amount of digits got the same weight. E. g. naturalCompare("Item 10", "Item 11") returned 0 instead of a value < 0.
Peter Penz [Fri, 12 Jan 2007 20:24:23 +0000 (20:24 +0000)]
Natural sorting fix: assure that directories are sorted always before files as Ellen has recommended. One minor issue is left: when the sort order is descending, the natural sorting result is:
item 10.jpg
item 11.jpg
item 2.jpg
item 1.jpg
instead of
item 11.jpg
item 10.jpg
item 2.jpg
item 1.jpg
Peter Penz [Sun, 7 Jan 2007 21:28:41 +0000 (21:28 +0000)]
Fixed issue that the view properties have not been used for the home directory when starting Dolphin. Also some (very minor) updates have been done regarding the coding guidelines (I'm a nasty nitpicker ;-)).
Peter Penz [Sun, 7 Jan 2007 21:10:52 +0000 (21:10 +0000)]
Remember the position and size of the docks by using QMainWindow::saveState() and QMainWindow::restoreState(). I assume that in KDE 4 there will be a generic mechanism to store the position and size of docks like done for toolbars -> this is only a temporary solution to have a usable version of Dolphin in the meantime.
projects / dolphin.git / log