Peter Penz [Sat, 16 Feb 2008 14:37:13 +0000 (14:37 +0000)]
Bypassed a bug in QTreeView::mouseMoveEvent() (see comment in code). Submitted a bug-report to Trolltech, bug tracker ID is still pending (will add the ID into the code as soon as I get it).
Peter Penz [Sat, 16 Feb 2008 13:16:59 +0000 (13:16 +0000)]
Provide an option for the details view to expand folders (= tree view), as this is required for Konqueror to get back this functionality from KDE 3. It is possible in Dolphin to enable this option too, but it is set to false per default.
Peter Penz [Fri, 15 Feb 2008 23:13:47 +0000 (23:13 +0000)]
Initially I thought it's better not having code as default value inside dolphin_generalsettings.kcfg. But the check for an empty home URL in DolphinMainWindow::init() must also be done when invoking GeneralSettings::setDefaults() in StartupSettingsPage, otherwise the home URL would get empty... Using QDir::homePath() as default-value inside the *.kcfg file prevents such issues.
Robert Knight [Fri, 15 Feb 2008 18:18:21 +0000 (18:18 +0000)]
Fix flicker when resizing the central view area in Dolphin. Only applicable with Qt 4.4 with alien widgets enabled. Any widgets passed to KDirLister::setMainWindow() become native widgets because of a call to QWidget::winId() inside KIO. This fix passes the top level Dolphin window to setMainWindow() (which is already a native window) instead of the item view widget.
David Faure [Fri, 15 Feb 2008 17:01:03 +0000 (17:01 +0000)]
Add unit test for #149736 (an old bug where a javascript handler closes the window on click - and crashed konqueror again in kde 4)
(the fix is r775367 in kdelibs)
(side node: kapp->setTopWidget call removed since it doesn't care for the icon anymore, only for some startupid stuff)
Peter Penz [Thu, 14 Feb 2008 22:57:00 +0000 (22:57 +0000)]
Bypass a temporary (?) regression (?) with the current Qt 4.4 beta version: it seems like QLayout::activate()/update() don't do a relayout anymore if the sizehint of a sub widget has been changed. I'll check this again with Qt 4.4.0.
David Faure [Wed, 13 Feb 2008 18:45:20 +0000 (18:45 +0000)]
Provide the dolphinpart view modes (Icons, Details, Columns) in konqueror's View Modes menu.
(this is done using a Q_PROPERTY in the dolphin part and a signal; the available view modes for creating the menu in the first place are listed in dolphinpart.desktop)
Konqueror: cleaned up the old (complex) handling of view modes as N toolbar buttons from M services grouped by library (240 lines less!).
Dolphin: moved view mode handling to DolphinViewActionHandler, removes duplication between part and mainwindow.
David Faure [Wed, 13 Feb 2008 18:07:34 +0000 (18:07 +0000)]
Provide the dolphinpart view modes (Icons, Details, Columns) in konqueror's View Modes menu.
(this is done using a Q_PROPERTY in the dolphin part and a signal; the available view modes for creating the menu in the first place are listed in dolphinpart.desktop)
Konqueror: cleaned up the old (complex) handling of view modes as N toolbar buttons from M services grouped by library.
Dolphin: moved view mode handling to DolphinViewActionHandler, removes duplication between part and mainwindow.
BUG: 157424
David Faure [Mon, 11 Feb 2008 12:44:46 +0000 (12:44 +0000)]
Forwardport 773570:
Factorize all the view-related action handling to DolphinViewActionHandler, to remove code duplication between mainwindow and part, and to remove my code-splitting with the static createFooAction methods in the view.
David Faure [Mon, 11 Feb 2008 12:34:48 +0000 (12:34 +0000)]
Factorize all the view-related action handling to DolphinViewActionHandler, to remove code duplication between mainwindow and part, and to remove my code-splitting with the static createFooAction methods in the view.
Peter Penz [Thu, 7 Feb 2008 07:27:06 +0000 (07:27 +0000)]
Fixed issue that the "Show Full Location" action is not synchronized with the editable state of the URL navigator (thanks to David Benjamin for the patch).
Peter Penz [Sat, 2 Feb 2008 20:53:35 +0000 (20:53 +0000)]
Improve the selection toggle: Instead of a delay of one second until appearing, let it appear immediately but provide a smooth fade-in effect. This makes it usable from the start but is less obtrusive for the eyes.
Peter Penz [Wed, 30 Jan 2008 22:39:42 +0000 (22:39 +0000)]
Don't offer a Move Here/Copy Here/Link Here menu when dropping items above the trash, just move the things into the trash instead. TODO: as the inline comment already says KonqOperations::doDrop() should be used as longterm solution...
David Faure [Mon, 28 Jan 2008 11:33:49 +0000 (11:33 +0000)]
Centralize three more actions so that they are available in DolphinPart: 'Show preview' 'Show hidden files' 'Categorized sorting'
Found a way of sharing the actions with even less code duplication, discussed it with Peter, but this will be for after 4.0.1
Peter Penz [Sat, 26 Jan 2008 21:45:28 +0000 (21:45 +0000)]
Blend in a toggle button when hovering items. This allows selecting items without using the rubberband or Ctrl/Shift-keys in the single-click mode. Any feedback from users is highly welcome (I think people will either love or hate this feature, I'm really not sure -> it can be turned off too).
Peter Penz [Sat, 26 Jan 2008 12:48:03 +0000 (12:48 +0000)]
* increase the performance of item previews: each item view provides an icon size hint -> the preview and item effects are only applied to the current size, not to the maximum of 128 x 128 pixels
* make the icons of hidden files semitransparent like in KDE3
David Faure [Tue, 22 Jan 2008 01:22:56 +0000 (01:22 +0000)]
Move the code handling the additional-info-actions to DolphinView; simplify signal from DolphinView (it has the info anyway).
The fact that the last additional-info doesn't show up in the icon view is in fact a KFileItemDelegate bug, not a bug in this code :)
David Faure [Tue, 22 Jan 2008 00:43:51 +0000 (00:43 +0000)]
restore previous behavior: additional info actions are not mutually exclusive.
(although requesting size and type at the same time doesn't show the type...)
David Faure [Mon, 21 Jan 2008 19:31:07 +0000 (19:31 +0000)]
forwardport 764429:
Revert the moving of the action to the DolphinView instance, this doesn't work with splitted views.
(Each view would need its own action collection, but then DolphinView would have to become
a KXMLGUIClient, and the GUI would flicker when switching views).
Instead, use the same solution as the other shared actions: static method in DolphinView (for now),
slot in the mainwindow (and for the more complex actions than this one, shared code in DolphinView)
David Faure [Mon, 21 Jan 2008 19:08:52 +0000 (19:08 +0000)]
Revert the moving of the action to the DolphinView instance, this doesn't work with splitted views.
(Each view would need its own action collection, but then DolphinView would have to become
a KXMLGUIClient, and the GUI would flicker when switching views).
Instead, use the same solution as the other shared actions: static method in DolphinView (for now),
slot in the mainwindow (and for the more complex actions than this one, shared code in DolphinView)
Peter Penz [Mon, 21 Jan 2008 16:51:31 +0000 (16:51 +0000)]
Split the "General Settings" into "Startup Settings" and "General Settings" for having a cleaner layout. Still some fine tuning and code cleanups have to be done...
Peter Penz [Mon, 21 Jan 2008 16:07:45 +0000 (16:07 +0000)]
Make it configurable whether a browsing through archives should be done. The default setting is 'off'. TODO: cleanup the "General Settings" dialog and split it as "General" and "Startup".
Peter Penz [Mon, 21 Jan 2008 14:16:31 +0000 (14:16 +0000)]
Cleanup: let the DolphinView be aware about the used action collection. This will allow us cleaning up some code in DolphinMainWindow and will make it easier sharing code with DolphinPart.