]> cloud.milkyroute.net Git - dolphin.git/commit
Fix ascending/descending choosers getting unchecked when re-selecting the same sort...
authorNate Graham <nate@kde.org>
Sat, 24 Aug 2019 20:33:00 +0000 (14:33 -0600)
committerNate Graham <nate@kde.org>
Mon, 9 Sep 2019 13:17:17 +0000 (07:17 -0600)
commit60d6a3bdbcd44360e1c6ae1c82239ecf6d60ded7
tree940e4c7d8cff5f186eba70ad407b527f95fe71c0
parenta6403716439ae72bfdf86a14af94ea9d212f08ee
Fix ascending/descending choosers getting unchecked when re-selecting the same sort order

Summary:
When you select the same sort order that's already selected, the currently-checked
sort order description (the human-readable ascending/descending items) gets unchecked
in `slotSortTriggered()` yet the ascending/descending items items only get checked in
`slotSortOrderChanged()`. Because the order hasn't gotten changed, neither one gets
checked again.

This patch fixes the problem by not unchecking them in the first place.

BUG: 411223
FIXED-IN: 19.08.2

Test Plan:
1. Right-click > Sort By > Click the currently-selected sort order
2. Right-click > Sort By > See that the item for the current ascending/descending setting has not been changed

Reviewers: elvisangelaccio, #dolphin

Reviewed By: elvisangelaccio, #dolphin

Subscribers: broulik, meven, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D23412
src/views/dolphinviewactionhandler.cpp