From 084cf94a31e7bccbcc9c25d31e6e9893db38d696 Mon Sep 17 00:00:00 2001 From: Loren Burkholder Date: Fri, 1 Dec 2023 10:51:05 -0500 Subject: [PATCH] Remove the menu from the split button when splitscreen is closed --- src/dolphinmainwindow.cpp | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp index 967d4560f..ccd80151b 100644 --- a/src/dolphinmainwindow.cpp +++ b/src/dolphinmainwindow.cpp @@ -2552,14 +2552,20 @@ void DolphinMainWindow::updateSplitActions() popoutSplitAction->setToolTip(i18nc("@info", "Move right split view to a new window")); } popoutSplitAction->setEnabled(true); - m_splitViewAction->addAction(popoutSplitAction); + if (!m_splitViewAction->menu()) { + m_splitViewAction->setMenu(new QMenu); + m_splitViewAction->addAction(popoutSplitAction); + } } else { m_splitViewAction->setText(i18nc("@action:intoolbar Split view", "Split")); m_splitViewAction->setToolTip(i18nc("@info", "Split view")); m_splitViewAction->setIcon(QIcon::fromTheme(QStringLiteral("view-right-new"))); popoutSplitAction->setText(i18nc("@action:intoolbar Move active split view to a new window", "Pop out")); popoutSplitAction->setEnabled(false); - m_splitViewAction->removeAction(popoutSplitAction); + if (m_splitViewAction->menu()) { + m_splitViewAction->removeAction(popoutSplitAction); + m_splitViewAction->setMenu(nullptr); + } } // Update state from toolbar action -- 2.47.3