From 16f413ccd786f4ab37a3ea931624a76d5434fe2c Mon Sep 17 00:00:00 2001 From: Akseli Lahtinen Date: Fri, 28 Feb 2025 17:43:20 +0000 Subject: [PATCH] Fix crash when opening new tab with search When new tab is opened and it has a search started, it tries to set the location URL to a navigator that is not yet necessarily assigned in memory: This is because the new tab is not active. The locationUrl will be changed properly when tab is activated. BUG:500101 --- src/dolphinviewcontainer.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/dolphinviewcontainer.cpp b/src/dolphinviewcontainer.cpp index 40df2bc7d..dcf159cda 100644 --- a/src/dolphinviewcontainer.cpp +++ b/src/dolphinviewcontainer.cpp @@ -942,7 +942,12 @@ void DolphinViewContainer::startSearching() const QUrl url = m_searchBox->urlForSearching(); if (url.isValid() && !url.isEmpty()) { m_view->setViewPropertiesContext(QStringLiteral("search")); - m_urlNavigatorConnected->setLocationUrl(url); + // If we open a new tab that has a search assigned to it, we can't + // update the urlNavigator, since there is none connected to that tab. + // See BUG:500101 + if (m_urlNavigatorConnected) { + m_urlNavigatorConnected->setLocationUrl(url); + } } } -- 2.47.3