From 1c22a23d90ab404c6f8c5135b6bd8a5a54cd5916 Mon Sep 17 00:00:00 2001 From: Shivodit Gill Date: Fri, 25 Nov 2022 10:58:07 +0000 Subject: [PATCH] Fixed build-time deprecation warning about KStandardGuiItem::yes() While building dolphin, a warning comes up about KStandardGuiItem::yes() being deprecated, and that another action verb should be using instead. This commit fixes the warning by replacing KStandardGuiItem::yes() with a KGuiItem constructor in the file src/views/dolphinview.cpp. The icon for the "Rename and Hide" button has also been changed from a check mark (dialog-ok) to an eye with a cross (view-hidden) to make the button look more unique and grab the attention of the user. --- src/views/dolphinview.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/views/dolphinview.cpp b/src/views/dolphinview.cpp index e8603858f..1da3ebf85 100644 --- a/src/views/dolphinview.cpp +++ b/src/views/dolphinview.cpp @@ -1906,8 +1906,7 @@ void DolphinView::slotRoleEditingFinished(int index, const QByteArray& role, con #ifndef Q_OS_WIN //Confirm hiding file/directory by renaming inline if (!hiddenFilesShown() && newName.startsWith(QLatin1Char('.')) && !oldItem.name().startsWith(QLatin1Char('.'))) { - KGuiItem yesGuiItem(KStandardGuiItem::yes()); - yesGuiItem.setText(i18nc("@action:button", "Rename and Hide")); + KGuiItem yesGuiItem(i18nc("@action:button", "Rename and Hide"), QStringLiteral("view-hidden")); #if KWIDGETSADDONS_VERSION >= QT_VERSION_CHECK(5, 100, 0) const auto code = KMessageBox::questionTwoActions(this, -- 2.47.3