From 27dca0285e8b14227163cd2d342b1055fc165845 Mon Sep 17 00:00:00 2001 From: Nate Graham Date: Wed, 29 Jan 2025 11:57:09 -0700 Subject: [PATCH 1/1] Make "Empty trash" icons red This is a destructive action, and the HIG specifies that icons for destructive actions should be colored red. The current icons are black, inconsistent, and semantically incorrect. edit-delete is red in the Breeze icon theme, and also more semantically correct since the items in the trash will be deleted. Let's use this icon instead. --- src/dolphincontextmenu.cpp | 2 +- src/dolphinnavigatorswidgetaction.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/dolphincontextmenu.cpp b/src/dolphincontextmenu.cpp index 413ab96a0..e2f7e326b 100644 --- a/src/dolphincontextmenu.cpp +++ b/src/dolphincontextmenu.cpp @@ -121,7 +121,7 @@ void DolphinContextMenu::addTrashContextMenu() { Q_ASSERT(m_context & TrashContext); - QAction *emptyTrashAction = addAction(QIcon::fromTheme(QStringLiteral("trash-empty")), i18nc("@action:inmenu", "Empty Trash"), [this]() { + QAction *emptyTrashAction = addAction(QIcon::fromTheme(QStringLiteral("edit-delete")), i18nc("@action:inmenu", "Empty Trash"), [this]() { Trash::empty(m_mainWindow); }); emptyTrashAction->setEnabled(!Trash::isEmpty()); diff --git a/src/dolphinnavigatorswidgetaction.cpp b/src/dolphinnavigatorswidgetaction.cpp index 36217ed09..e1254e019 100644 --- a/src/dolphinnavigatorswidgetaction.cpp +++ b/src/dolphinnavigatorswidgetaction.cpp @@ -225,7 +225,7 @@ QPushButton *DolphinNavigatorsWidgetAction::emptyTrashButton(DolphinNavigatorsWi QPushButton *DolphinNavigatorsWidgetAction::newEmptyTrashButton(const DolphinUrlNavigator *urlNavigator, QWidget *parent) const { - auto emptyTrashButton = new QPushButton(QIcon::fromTheme(QStringLiteral("user-trash")), i18nc("@action:button", "Empty Trash"), parent); + auto emptyTrashButton = new QPushButton(QIcon::fromTheme(QStringLiteral("edit-delete")), i18nc("@action:button", "Empty Trash"), parent); emptyTrashButton->setToolTip(i18n("Empties Trash to create free space")); emptyTrashButton->setFlat(true); -- 2.47.3