From 44fe65d42110cc200bcb2ce494a026c6a6292c2d Mon Sep 17 00:00:00 2001 From: lzwind lzwind Date: Tue, 29 Jul 2025 13:18:25 +0000 Subject: [PATCH] settings: Fix memory leak in PanelSettingsPage constructor Replace heap-allocated KFormat objects with stack-allocated formatter. No functionality change. --- src/settings/interface/panelsettingspage.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/settings/interface/panelsettingspage.cpp b/src/settings/interface/panelsettingspage.cpp index 3cd153656..efa41e6c5 100644 --- a/src/settings/interface/panelsettingspage.cpp +++ b/src/settings/interface/panelsettingspage.cpp @@ -28,8 +28,9 @@ PanelSettingsPage::PanelSettingsPage(QWidget *parent) { QFormLayout *topLayout = new QFormLayout(this); - QString m_longDateTime = (new KFormat)->formatRelativeDateTime(QDateTime(QDate(2024, 02, 28), QTime(10, 0)), QLocale::LongFormat); - QString m_shortDateTime = (new KFormat)->formatRelativeDateTime(QDateTime(QDate(2024, 02, 28), QTime(10, 0)), QLocale::ShortFormat); + KFormat formatter; + QString m_longDateTime = formatter.formatRelativeDateTime(QDateTime(QDate(2024, 02, 28), QTime(10, 0)), QLocale::LongFormat); + QString m_shortDateTime = formatter.formatRelativeDateTime(QDateTime(QDate(2024, 02, 28), QTime(10, 0)), QLocale::ShortFormat); m_showPreview = new QCheckBox(i18nc("@option:check", "Show previews"), this); m_autoPlayMedia = new QCheckBox(i18nc("@option:check", "Auto-play media files"), this); -- 2.47.3