From 5ed12ed44a7169855d46486d17c3e18697c3c4ae Mon Sep 17 00:00:00 2001 From: Harald Sitter Date: Wed, 20 Jan 2021 15:29:04 +0100 Subject: [PATCH] don't crash when building without baloo show_information_panel is only created when building with baloo. only access it when built with baloo, otherwise always report the panel as off. this fixes a nullptr deref because action() would return a nullptr since show_information_panel isn't a thing in all build configurations (full disclosure: I can't reproduce the crash, nor did I build without baloo) BUG: 431730 --- src/dolphinmainwindow.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp index 5a5319383..71d3ca033 100644 --- a/src/dolphinmainwindow.cpp +++ b/src/dolphinmainwindow.cpp @@ -258,7 +258,11 @@ bool DolphinMainWindow::isFoldersPanelEnabled() const bool DolphinMainWindow::isInformationPanelEnabled() const { +#ifdef HAVE_BALOO return actionCollection()->action(QStringLiteral("show_information_panel"))->isChecked(); +#else + return false; +#endif } void DolphinMainWindow::openFiles(const QStringList& files, bool splitView) -- 2.47.3