From 78c8b36dd84a94916835d702ea4a9e8eda65e8ef Mon Sep 17 00:00:00 2001 From: Robert Jennings Date: Wed, 25 Apr 2018 12:35:29 +0200 Subject: [PATCH] Update window title after closing split view Summary: In dolphintabpage.cpp: Through the connections set up in createViewContainer(), m_primaryViewContainer->setActive(true), at line 98, ends up triggering slotViewActivated(). Because m_primaryViewActive is true, oldActiveView is not set to the view needed in this particular situation. Both oldActiveView and newActiveView end up pointing to the same view and the connections are not set up. BUG: 385111 FIXED-IN: 18.04.1 Test Plan: 1. Open split view 2. Make left panel active 3. Close split view 4. Navigate to various directories Window title now updates to show current directory Also tried with multiple tabs/combinations Reviewers: #dolphin, ngraham Reviewed By: #dolphin, ngraham Subscribers: elvisangelaccio, ngraham Differential Revision: https://phabricator.kde.org/D12446 --- src/dolphintabpage.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/dolphintabpage.cpp b/src/dolphintabpage.cpp index 342d6f6de..a96c8b6a3 100644 --- a/src/dolphintabpage.cpp +++ b/src/dolphintabpage.cpp @@ -94,6 +94,7 @@ void DolphinTabPage::setSplitViewEnabled(bool enabled, const QUrl &secondaryUrl) // If the primary view is active, we have to swap the pointers // because the secondary view will be the new primary view. qSwap(m_primaryViewContainer, m_secondaryViewContainer); + m_primaryViewActive = false; } m_primaryViewContainer->setActive(true); view->close(); -- 2.47.3