From 8cea647ce11dbc8bb009f8a16adaaa94be3dcfb1 Mon Sep 17 00:00:00 2001 From: Nathaniel Graham Date: Tue, 12 Dec 2017 22:52:21 -0700 Subject: [PATCH] Change "Empty Search" to just "Search" to handle searches with no search text Summary: BUG: 387854 The pre-defined searches (Documents, Videos, etc) all default to no search text. https://cgit.kde.org/dolphin.git/commit/?id=702429ac8e64a5aff4e110a56f526b96ecb795fd changed their window title from "baloosearch - /" to "Empty Search", but the search isn't really empty; it just lacks a search string. It's still looking for documents, or videos, or whatever. Test Plan: Is it too late to get this into 5.12? Tested in KDE Neon. Before: {F5545170} After: {F5545171} Reviewers: #dolphin, elvisangelaccio, broulik Reviewed By: broulik Differential Revision: https://phabricator.kde.org/D9305 --- src/dolphinmainwindow.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp index 067d4a6e1..7b3d63fd6 100644 --- a/src/dolphinmainwindow.cpp +++ b/src/dolphinmainwindow.cpp @@ -1003,7 +1003,7 @@ void DolphinMainWindow::setUrlAsCaption(const QUrl& url) if (m_activeViewContainer->isSearchModeEnabled()) { if(m_activeViewContainer->currentSearchText().isEmpty()){ - setWindowTitle(i18n("Empty Search")); + setWindowTitle(i18n("Search")); } else { const auto searchText = i18n("Search for %1", m_activeViewContainer->currentSearchText()); setWindowTitle(searchText); -- 2.47.3