From 91ea1e29eebda1f9a12c5a09b9df140353f48242 Mon Sep 17 00:00:00 2001 From: =?utf8?q?M=C3=A9ven=20Car?= Date: Tue, 5 May 2020 07:31:54 +0200 Subject: [PATCH] Sort by file size according to DetailsModeSettings::directorySizeCount Test Plan: Sort by file size in details view. Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29424 --- src/kitemviews/kfileitemmodel.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/kitemviews/kfileitemmodel.cpp b/src/kitemviews/kfileitemmodel.cpp index 5e9603ba1..ac3c33e22 100644 --- a/src/kitemviews/kfileitemmodel.cpp +++ b/src/kitemviews/kfileitemmodel.cpp @@ -1770,12 +1770,12 @@ int KFileItemModel::sortRoleCompare(const ItemData* a, const ItemData* b, const QVariant valueA, valueB; if (DetailsModeSettings::directorySizeCount()) { + valueA = a->values.value("count"); + valueB = b->values.value("count"); + } else { // use dir size then valueA = a->values.value("size"); valueB = b->values.value("size"); - } else { - valueA = a->values.value("count"); - valueB = b->values.value("count"); } if (valueA.isNull() && valueB.isNull()) { result = 0; -- 2.47.3