From 949da1fb3117c736e4f2f5182126dde1a758c719 Mon Sep 17 00:00:00 2001 From: Elvis Angelaccio Date: Sun, 7 Oct 2018 21:37:35 +0200 Subject: [PATCH 1/1] [DolphinMainWindowTest] Attempt to fix testOpenInNewTabTile() on the CI Both icon `name()`s are empty on the CI, which probably doesn't have icons or something. This should hopefully fix it. --- src/tests/dolphinmainwindowtest.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/tests/dolphinmainwindowtest.cpp b/src/tests/dolphinmainwindowtest.cpp index 3fdabe7b8..673bccd44 100644 --- a/src/tests/dolphinmainwindowtest.cpp +++ b/src/tests/dolphinmainwindowtest.cpp @@ -188,9 +188,10 @@ void DolphinMainWindowTest::testOpenInNewTabTitle() tabWidget->openNewTab(QUrl::fromLocalFile(QDir::tempPath())); QCOMPARE(tabWidget->count(), 2); - qDebug() << "First tab:" << tabWidget->tabIcon(0).name() << "second tab:" << tabWidget->tabIcon(1).name(); - QVERIFY(tabWidget->tabIcon(0).name() != tabWidget->tabIcon(1).name()); QVERIFY(tabWidget->tabText(0) != tabWidget->tabText(1)); + if (!tabWidget->tabIcon(0).isNull() && !tabWidget->tabIcon(1).isNull()) { + QVERIFY(tabWidget->tabIcon(0).name() != tabWidget->tabIcon(1).name()); + } } void DolphinMainWindowTest::testNewFileMenuEnabled_data() -- 2.47.3