From a024e3e2aabf0f501707c8c5c0bdb25df6675b3a Mon Sep 17 00:00:00 2001 From: Peter Penz Date: Sun, 6 May 2012 22:07:08 +0200 Subject: [PATCH] Remove workaround to start/stop the resource watcher Using the latest resource-watcher from kde-runtime does not make this workaround necessary anymore. --- src/kitemviews/kfileitemmodelrolesupdater.cpp | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/kitemviews/kfileitemmodelrolesupdater.cpp b/src/kitemviews/kfileitemmodelrolesupdater.cpp index a1773840d..bbb01247d 100644 --- a/src/kitemviews/kfileitemmodelrolesupdater.cpp +++ b/src/kitemviews/kfileitemmodelrolesupdater.cpp @@ -323,6 +323,7 @@ void KFileItemModelRolesUpdater::slotItemsRemoved(const KItemRangeList& itemRang // Don't let the ResourceWatcher watch for removed items if (m_model->count() == 0) { m_nepomukResourceWatcher->setResources(QList()); + m_nepomukResourceWatcher->stop(); m_nepomukUriItems.clear(); } else { QList newResources; @@ -337,6 +338,10 @@ void KFileItemModelRolesUpdater::slotItemsRemoved(const KItemRangeList& itemRang } } m_nepomukResourceWatcher->setResources(newResources); + if (newResources.isEmpty()) { + Q_ASSERT(m_nepomukUriItems.isEmpty()); + m_nepomukResourceWatcher->stop(); + } } } #endif @@ -992,11 +997,11 @@ QHash KFileItemModelRolesUpdater::rolesData(const KFileIte uri = resource.resourceUri(); } if (!uri.isEmpty() && !m_nepomukUriItems.contains(uri)) { - // TODO: Calling stop()/start() is a workaround until - // ResourceWatcher has been fixed. - m_nepomukResourceWatcher->stop(); m_nepomukResourceWatcher->addResource(resource); - m_nepomukResourceWatcher->start(); + + if (m_nepomukUriItems.isEmpty()) { + m_nepomukResourceWatcher->start(); + } m_nepomukUriItems.insert(uri, item.url()); } -- 2.47.3