From a6fee698f6725d0a0bf28864c8dc7dd7bcda8983 Mon Sep 17 00:00:00 2001 From: Peter Penz Date: Wed, 17 Nov 2010 19:10:23 +0000 Subject: [PATCH] Move the "Show Menubar" entry from the top to the bottom. For users that have hidden the menubar on purpose having this as first item makes no sense. BUG: 257089 FIXED-IN: 4.6.0 svn path=/trunk/KDE/kdebase/apps/; revision=1198181 --- src/dolphincontextmenu.cpp | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/dolphincontextmenu.cpp b/src/dolphincontextmenu.cpp index ebda8b5a6..7b8f1db30 100644 --- a/src/dolphincontextmenu.cpp +++ b/src/dolphincontextmenu.cpp @@ -165,8 +165,6 @@ void DolphinContextMenu::openTrashContextMenu() { Q_ASSERT(m_context & TrashContext); - addShowMenubarAction(); - QAction* emptyTrashAction = new QAction(KIcon("trash-empty"), i18nc("@action:inmenu", "Empty Trash"), m_popup); KConfig trashConfig("trashrc", KConfig::SimpleConfig); emptyTrashAction->setEnabled(!trashConfig.group("Status").readEntry("Empty", true)); @@ -185,6 +183,8 @@ void DolphinContextMenu::openTrashContextMenu() QAction* propertiesAction = m_mainWindow->actionCollection()->action("properties"); m_popup->addAction(propertiesAction); + addShowMenubarAction(); + QAction *action = m_popup->exec(QCursor::pos()); if (action == emptyTrashAction) { const QString text(i18nc("@info", "Do you really want to empty the Trash? All items will be deleted.")); @@ -322,8 +322,6 @@ void DolphinContextMenu::openItemContextMenu() void DolphinContextMenu::openViewportContextMenu() { - addShowMenubarAction(); - // setup 'Create New' menu KNewFileMenu* newFileMenu = m_mainWindow->newFileMenu(); const DolphinView* view = m_mainWindow->activeViewContainer()->view(); @@ -365,6 +363,9 @@ void DolphinContextMenu::openViewportContextMenu() QAction* propertiesAction = m_popup->addAction(i18nc("@action:inmenu", "Properties")); propertiesAction->setIcon(KIcon("document-properties")); + + addShowMenubarAction(); + QAction* action = m_popup->exec(QCursor::pos()); if (action == propertiesAction) { const KUrl& url = m_mainWindow->activeViewContainer()->url(); @@ -409,8 +410,8 @@ void DolphinContextMenu::addShowMenubarAction() { KAction* showMenuBar = m_mainWindow->showMenuBarAction(); if (!m_mainWindow->menuBar()->isVisible()) { - m_popup->addAction(showMenuBar); m_popup->addSeparator(); + m_popup->addAction(showMenuBar); } } -- 2.47.3