From abb7799f7e007601a5f75ea85d9081bdb4d06a0a Mon Sep 17 00:00:00 2001 From: Elvis Angelaccio Date: Sat, 3 Dec 2016 18:04:24 +0100 Subject: [PATCH] Fix viewpropertiestest when GlobalViewProps is true The test was not saving its changes to the global settings, so it was passing on the CI only because the default value of GlobalViewProps is already false. If GlobalViewProps was set to true instead, testAutoSave() would fail because save() was not called and GlobalViewProps was not --- src/tests/viewpropertiestest.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/tests/viewpropertiestest.cpp b/src/tests/viewpropertiestest.cpp index 482e4127d..114afdc33 100644 --- a/src/tests/viewpropertiestest.cpp +++ b/src/tests/viewpropertiestest.cpp @@ -44,6 +44,7 @@ void ViewPropertiesTest::init() { m_globalViewProps = GeneralSettings::self()->globalViewProps(); GeneralSettings::self()->setGlobalViewProps(false); + GeneralSettings::self()->save(); // It is mandatory to create the test-directory inside the home-directory // of the user: ViewProperties does not write inside directories @@ -58,6 +59,7 @@ void ViewPropertiesTest::cleanup() m_testDir = 0; GeneralSettings::self()->setGlobalViewProps(m_globalViewProps); + GeneralSettings::self()->save(); } /** -- 2.47.3