From ca35c71f3dacf67d3763d0a218da713e40af5b36 Mon Sep 17 00:00:00 2001 From: Nicolas Fella Date: Fri, 28 Jan 2022 00:46:13 +0100 Subject: [PATCH] Improve placeholder message for unassigned tag When opening tags:/ we show 'No tags' when there are no tags found. When opening a tag that exists but doesn't have any files associated we show the same message, which isnt't appropriate. Instead show "No files tagged with 'foo'", which makes more sense --- src/views/dolphinview.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/views/dolphinview.cpp b/src/views/dolphinview.cpp index 0a9783fe1..5646fa982 100644 --- a/src/views/dolphinview.cpp +++ b/src/views/dolphinview.cpp @@ -2166,7 +2166,13 @@ void DolphinView::updatePlaceholderLabel() } else if (m_url.scheme() == QLatin1String("trash") && m_url.path() == QLatin1String("/")) { m_placeholderLabel->setText(i18n("Trash is empty")); } else if (m_url.scheme() == QLatin1String("tags")) { - m_placeholderLabel->setText(i18n("No tags")); + if (m_url.path() == QLatin1Char('/')) { + m_placeholderLabel->setText(i18n("No tags")); + } else { + const QString tagName = m_url.path().mid(1); // Remove leading / + m_placeholderLabel->setText(i18n("No files tagged with \"%1\"", tagName)); + } + } else if (m_url.scheme() == QLatin1String("recentlyused")) { m_placeholderLabel->setText(i18n("No recently used items")); } else if (m_url.scheme() == QLatin1String("smb")) { -- 2.47.3