From d00b531c74d509a03389485b116cda59162c73ea Mon Sep 17 00:00:00 2001 From: Albert Astals Cid Date: Sun, 29 Nov 2015 19:19:33 +0100 Subject: [PATCH] Call KLocalizedString::setApplicationDomain("dolphin"); dolphin is using -DTRANSLATION_DOMAIN=\"dolphin\" that is wrong for applications, apps need to use KLocalizedString::setApplicationDomain since that makes some other things like the transltators tab in the about dialog show. I have not removed -DTRANSLATION_DOMAIN=\"dolphin\" because on the other hand this code is also a library (i.e. the dolphin kpart). The "being pedandly correct" fix would be using -DTRANSLATION_DOMAIN=\"dolphin\" only to compile the files that are part of the kpart but that's prone to break at some point and using both KLocalizedString::setApplicationDomain and -DTRANSLATION_DOMAIN does not create any problem so i went that route CCMAIL: kfm-devel@kde.org --- src/main.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/main.cpp b/src/main.cpp index 0c5ac87f2..f51932913 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -48,6 +48,8 @@ extern "C" Q_DECL_EXPORT int kdemain(int argc, char **argv) migrate.setUiFiles(QStringList() << QStringLiteral("dolphinpart.rc") << QStringLiteral("dolphinui.rc")); migrate.migrate(); + KLocalizedString::setApplicationDomain("dolphin"); + KAboutData aboutData("dolphin", i18n("Dolphin"), QStringLiteral(DOLPHIN_VERSION_STRING), i18nc("@title", "File Manager"), KAboutLicense::GPL, -- 2.47.3