From d2783df3104dfc4575d3e8fc9077e3b21fd944c8 Mon Sep 17 00:00:00 2001 From: David Hallas Date: Sun, 29 Jul 2018 12:10:16 +0200 Subject: [PATCH] Fixes memory leak of KItemListHeader Summary: Fixes memory leak of KItemListHeader The KItemListHeader passed the listView parent object to the QObject base class, but that pointer seems to always be nullptr causing the KItemListHeader to not be memory managed by anything. Instead simple use the listView as parent pointer. Test Plan: This leak was found using Address Sanitizer Reviewers: elvisangelaccio Reviewed By: elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D14453 --- src/kitemviews/kitemlistheader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/kitemviews/kitemlistheader.cpp b/src/kitemviews/kitemlistheader.cpp index cfc2c2b72..a82af44e7 100644 --- a/src/kitemviews/kitemlistheader.cpp +++ b/src/kitemviews/kitemlistheader.cpp @@ -74,7 +74,7 @@ qreal KItemListHeader::preferredColumnWidth(const QByteArray& role) const } KItemListHeader::KItemListHeader(KItemListView* listView) : - QObject(listView->parent()), + QObject(listView), m_view(listView) { m_headerWidget = m_view->m_headerWidget; -- 2.47.3