From d56ae4eda3918e004738c7ed45ee96e250ebeb3c Mon Sep 17 00:00:00 2001 From: David Faure Date: Thu, 20 Dec 2007 20:44:58 +0000 Subject: [PATCH] If we should open the URL right away, then let's do it right away. We can tell konqueror afterwards by using the openUrlNotify() signal. Note: this design bit is a bit strange; the controller has urlChanged() and requestUrlChange(), but they are both channeled to DolphinView::urlChanged(), which means the recipient has to figure out if the url change was already done or not, with "if (m_view->url() != url)". Wouldn't it be simpler to just have both signals coming out of DolphinView? (but some receivers like the view container don't seem to care which one was emitted... strange) CCMAIL: peter.penz@gmx.at, ereslibre@kde.org CCBUG: 154053 svn path=/trunk/KDE/kdebase/apps/; revision=750996 --- src/dolphinpart.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/dolphinpart.cpp b/src/dolphinpart.cpp index 616351d04..981bb7028 100644 --- a/src/dolphinpart.cpp +++ b/src/dolphinpart.cpp @@ -319,8 +319,8 @@ void DolphinPart::slotUrlChanged(const KUrl& url) if (m_view->url() != url) { // If the view URL is not equal to 'url', then an inner URL change has // been done (e. g. by activating an existing column in the column view). - // From the hosts point of view this must be handled like changing the URL. - emit m_extension->openUrlRequestDelayed(url, KParts::OpenUrlArguments(), KParts::BrowserArguments()); + openUrl(url); + emit m_extension->openUrlNotify(); } } -- 2.47.3