From d8322161594cfa967ae80ea7b37f2e04393b0f1a Mon Sep 17 00:00:00 2001 From: Kai Uwe Broulik Date: Thu, 20 Jan 2022 12:38:47 +0100 Subject: [PATCH] [Tab Bar] Accept proposed action only ontop of a tab You cannot drop a file/folder onto the empty area of the tab bar, so show the appropriate "not allowed" cursor. --- src/dolphintabbar.cpp | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/dolphintabbar.cpp b/src/dolphintabbar.cpp index 67a61b031..4c1d9e44a 100644 --- a/src/dolphintabbar.cpp +++ b/src/dolphintabbar.cpp @@ -36,7 +36,13 @@ void DolphinTabBar::dragEnterEvent(QDragEnterEvent* event) const int index = tabAt(event->pos()); if (mimeData->hasUrls()) { - event->acceptProposedAction(); + if (index >= 0) { + event->acceptProposedAction(); + } else { + event->setDropAction(Qt::IgnoreAction); + // Still need to accept it to receive dragMoveEvent + event->accept(); + } updateAutoActivationTimer(index); } @@ -56,6 +62,11 @@ void DolphinTabBar::dragMoveEvent(QDragMoveEvent* event) const int index = tabAt(event->pos()); if (mimeData->hasUrls()) { + if (index >= 0) { + event->acceptProposedAction(); + } else { + event->setDropAction(Qt::IgnoreAction); + } updateAutoActivationTimer(index); } -- 2.47.3