From e20a6e59ea2313f9121f3fda5c9c5a4fa048605e Mon Sep 17 00:00:00 2001 From: Peter Penz Date: Fri, 3 Feb 2012 09:57:18 +0100 Subject: [PATCH] Folders Panel: Show expansion toggles for directories on ISO-images When counting the number of sub-directories consider unknown file types as potential directories. In the "worst case" an expansion toggle will be shown although the directory contains only files, however from a performance point of view this seems to be an acceptable compromise. BUG: 292642 FIXED-IN: 4.8.1 --- src/kitemviews/kfileitemmodelrolesupdater.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/kitemviews/kfileitemmodelrolesupdater.cpp b/src/kitemviews/kfileitemmodelrolesupdater.cpp index 0c204e474..14e7f00ff 100644 --- a/src/kitemviews/kfileitemmodelrolesupdater.cpp +++ b/src/kitemviews/kfileitemmodelrolesupdater.cpp @@ -839,7 +839,9 @@ int KFileItemModelRolesUpdater::subItemsCount(const QString& path) const } } - if (!showFoldersOnly || dirEntry->d_type == DT_DIR) { + // If only directories are counted, consider an unknown file type also + // as directory instead of trying to do an expensive stat() (see bug 292642). + if (!showFoldersOnly || dirEntry->d_type == DT_DIR || dirEntry->d_type == DT_UNKNOWN) { ++count; } } -- 2.47.3