From e30357343bdadd6bf6bb94e5adf54d8b840ef1bd Mon Sep 17 00:00:00 2001 From: Ismael Asensio Date: Mon, 7 Oct 2019 21:50:59 +0200 Subject: [PATCH] [dolphin/search] Avoid unnecesary reloads on setSearchPath Summary: Check in `setSearchPath()` if the `url` passed is already the `searchPath` This was causing an effect where reloading the same search URL results on buttons `From Here/Everywhere` toggling. See D24422 Test Plan: On your home folder press `Ctrl-F` several times Buttons `From Here/Everywhere` should now not toggle each time Reviewers: #dolphin, elvisangelaccio, meven, ngraham Reviewed By: #dolphin, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D24449 --- src/search/dolphinsearchbox.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/search/dolphinsearchbox.cpp b/src/search/dolphinsearchbox.cpp index f3dd20462..6a87edc9e 100644 --- a/src/search/dolphinsearchbox.cpp +++ b/src/search/dolphinsearchbox.cpp @@ -81,6 +81,10 @@ QString DolphinSearchBox::text() const void DolphinSearchBox::setSearchPath(const QUrl& url) { + if (url == m_searchPath) { + return; + } + m_searchPath = url; QFontMetrics metrics(m_fromHereButton->font()); -- 2.47.3