From ff9ae28445b4d8b6549003f28c2173acf9469f1b Mon Sep 17 00:00:00 2001 From: Nicolas Fella Date: Mon, 25 Nov 2019 20:54:08 +0100 Subject: [PATCH] Remove dead code Summary: The code appears to do nothing. Test Plan: builds, bookmarkmenu still works Reviewers: #dolphin, meven, elvisangelaccio Reviewed By: #dolphin, meven, elvisangelaccio Subscribers: meven, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25347 --- src/dolphinbookmarkhandler.cpp | 5 ----- src/dolphinbookmarkhandler.h | 3 +-- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/dolphinbookmarkhandler.cpp b/src/dolphinbookmarkhandler.cpp index bb8f641ec..ded83d6bb 100644 --- a/src/dolphinbookmarkhandler.cpp +++ b/src/dolphinbookmarkhandler.cpp @@ -54,11 +54,6 @@ DolphinBookmarkHandler::~DolphinBookmarkHandler() { } -void DolphinBookmarkHandler::fillControlMenu(QMenu* menu, KActionCollection* collection) -{ - m_bookmarkControlMenu.reset(new KBookmarkMenu(m_bookmarkManager, this, menu, collection)); -} - QString DolphinBookmarkHandler::currentTitle() const { return title(m_mainWindow->activeViewContainer()); diff --git a/src/dolphinbookmarkhandler.h b/src/dolphinbookmarkhandler.h index 6fd511d80..bafef41f8 100644 --- a/src/dolphinbookmarkhandler.h +++ b/src/dolphinbookmarkhandler.h @@ -36,7 +36,7 @@ class DolphinBookmarkHandler : public QObject, public KBookmarkOwner public: DolphinBookmarkHandler(DolphinMainWindow *mainWindow, KActionCollection *collection, QMenu *menu, QObject *parent); ~DolphinBookmarkHandler() override; - void fillControlMenu(QMenu *menu, KActionCollection *collection); + private: QString currentTitle() const override; QUrl currentUrl() const override; @@ -55,7 +55,6 @@ private: DolphinMainWindow* m_mainWindow; KBookmarkManager *m_bookmarkManager; QScopedPointer m_bookmarkMenu; - QScopedPointer m_bookmarkControlMenu; }; #endif // DOLPHINBOOKMARKHANDLER_H -- 2.47.3