src/tests/dolphindetailsviewtest.cpp

   1 /***************************************************************************
   2  *   Copyright (C) 2010 by Frank Reininghaus (frank78ac@googlemail.com)    *
   3  *                                                                         *
   4  *   This program is free software; you can redistribute it and/or modify  *
   5  *   it under the terms of the GNU General Public License as published by  *
   6  *   the Free Software Foundation; either version 2 of the License, or     *
   7  *   (at your option) any later version.                                   *
   8  *                                                                         *
   9  *   This program is distributed in the hope that it will be useful,       *
  10  *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
  11  *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
  12  *   GNU General Public License for more details.                          *
  13  *                                                                         *
  14  *   You should have received a copy of the GNU General Public License     *
  15  *   along with this program; if not, write to the                         *
  16  *   Free Software Foundation, Inc.,                                       *
  17  *   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA            *
  18  ***************************************************************************/
  19
  20 #include <qtest_kde.h>
  21
  22 #include "testhelper.h"
  23
  24 #include "views/dolphindetailsview.h"
  25 #include "views/dolphinview.h"
  26 #include "views/dolphinmodel.h"
  27 #include "views/dolphindirlister.h"
  28 #include "views/dolphinsortfilterproxymodel.h"
  29 #include "views/zoomlevelinfo.h"
  30
  31 #include <KTempDir>
  32
  33 #include <QtCore/QDir>
  34
  35 #include "kdebug.h"
  36
  37 class DolphinDetailsViewTest : public QObject
  38 {
  39     Q_OBJECT
  40
  41 private slots:
  42
  43     void initTestCase();
  44     void cleanupTestCase();
  45
  46     void bug234600_overlappingIconsWhenZooming();
  47
  48 private:
  49
  50     TestHelper* m_helper;
  51     DolphinView* m_view;
  52 };
  53
  54 void DolphinDetailsViewTest::initTestCase()
  55 {
  56     m_helper = new TestHelper;
  57     m_view = m_helper->view();
  58 }
  59
  60 void DolphinDetailsViewTest::cleanupTestCase()
  61 {
  62     delete m_helper;
  63 }
  64
  65 /**
  66  * When the icon size is changed, we have to make sure that the maximumSize given
  67  * to KFileItemDelegate for rendering each item is updated correctly. If this is not
  68  * done, the visualRects are clipped by the incorrect maximum size, and the icons
  69  * may overlap, see
  70  *
  71  * https://bugs.kde.org/show_bug.cgi?id=234600
  72  */
  73
  74 void DolphinDetailsViewTest::bug234600_overlappingIconsWhenZooming()
  75 {
  76     QStringList files;
  77     files << "a" << "b" << "c" << "d";
  78     m_helper->createFiles(files);
  79
  80     m_view->setMode(DolphinView::DetailsView);
  81     DolphinDetailsView* detailsView = qobject_cast<DolphinDetailsView*>(m_helper->itemView());
  82     QVERIFY(detailsView);
  83     m_view->resize(400, 400);
  84     m_view->show();
  85     QTest::qWaitForWindowShown(m_view);
  86
  87     // We have to make sure that the view has loaded the directory before we start the test.
  88     // TODO: This will be needed frequently. Maybe move to TestHelper.
  89     QSignalSpy finished(m_view, SIGNAL(finishedPathLoading(const KUrl&)));
  90     m_view->reload();
  91     while (finished.count() != 1) {
  92         QTest::qWait(50);
  93     }
  94
  95     QModelIndex index0 = detailsView->model()->index(0, 0);
  96     detailsView->setCurrentIndex(index0);
  97     QCOMPARE(detailsView->currentIndex(), index0);
  98
  99     // Setting the zoom level to the minimum value and triggering DolphinDetailsView::currentChanged(...)
 100     // should make sure that the bug is triggered.
 101     int zoomLevel = ZoomLevelInfo::minimumLevel();
 102     m_view->setZoomLevel(zoomLevel);
 103
 104     QModelIndex index1 = detailsView->model()->index(1, 0);
 105     detailsView->setCurrentIndex(index1);
 106     QCOMPARE(detailsView->currentIndex(), index1);
 107
 108     // Increase the zoom level successively to the maximum.
 109     while(zoomLevel < ZoomLevelInfo::maximumLevel()) {
 110         zoomLevel++;
 111         m_view->setZoomLevel(zoomLevel);
 112
 113         //Check for each zoom level that the height of each item is at least the icon size.
 114         QVERIFY(detailsView->visualRect(index1).height() >= ZoomLevelInfo::iconSizeForZoomLevel(zoomLevel));
 115     }
 116
 117     m_view->hide();
 118     m_helper->cleanupTestDir();
 119 }
 120
 121 QTEST_KDEMAIN(DolphinDetailsViewTest, GUI)
 122
 123 #include "dolphindetailsviewtest.moc"