src/tests/dolphinmainwindowtest.cpp

   1 /***************************************************************************
   2  *   Copyright (C) 2017 by Elvis Angelaccio <elvis.angelaccio@kde.org>     *
   3  *                                                                         *
   4  *   This program is free software; you can redistribute it and/or modify  *
   5  *   it under the terms of the GNU General Public License as published by  *
   6  *   the Free Software Foundation; either version 2 of the License, or     *
   7  *   (at your option) any later version.                                   *
   8  *                                                                         *
   9  *   This program is distributed in the hope that it will be useful,       *
  10  *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
  11  *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
  12  *   GNU General Public License for more details.                          *
  13  *                                                                         *
  14  *   You should have received a copy of the GNU General Public License     *
  15  *   along with this program; if not, write to the                         *
  16  *   Free Software Foundation, Inc.,                                       *
  17  *   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA            *
  18  ***************************************************************************/
  19
  20 #include "dolphinmainwindow.h"
  21 #include "dolphintabpage.h"
  22 #include "dolphintabwidget.h"
  23 #include "dolphinviewcontainer.h"
  24
  25 #include <KActionCollection>
  26
  27 #include <QSignalSpy>
  28 #include <QTest>
  29
  30 class DolphinMainWindowTest : public QObject
  31 {
  32     Q_OBJECT
  33
  34 private slots:
  35     void init();
  36     void testClosingTabsWithSearchBoxVisible();
  37     void testActiveViewAfterClosingSplitView_data();
  38     void testActiveViewAfterClosingSplitView();
  39     void testUpdateWindowTitleAfterClosingSplitView();
  40
  41 private:
  42     QScopedPointer<DolphinMainWindow> m_mainWindow;
  43 };
  44
  45 void DolphinMainWindowTest::init()
  46 {
  47     m_mainWindow.reset(new DolphinMainWindow());
  48 }
  49
  50 // See https://bugs.kde.org/show_bug.cgi?id=379135
  51 void DolphinMainWindowTest::testClosingTabsWithSearchBoxVisible()
  52 {
  53     m_mainWindow->openDirectories({ QUrl::fromLocalFile(QDir::homePath()) }, false);
  54     m_mainWindow->show();
  55     // Without this call the searchbox doesn't get FocusIn events.
  56     QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow.data()));
  57     QVERIFY(m_mainWindow->isVisible());
  58
  59     auto tabWidget = m_mainWindow->findChild<DolphinTabWidget*>("tabWidget");
  60     QVERIFY(tabWidget);
  61
  62     // Show search box on first tab.
  63     tabWidget->currentTabPage()->activeViewContainer()->setSearchModeEnabled(true);
  64
  65     tabWidget->openNewActivatedTab(QUrl::fromLocalFile(QDir::homePath()));
  66     QCOMPARE(tabWidget->count(), 2);
  67
  68     // Triggers the crash in bug #379135.
  69     tabWidget->closeTab();
  70     QCOMPARE(tabWidget->count(), 1);
  71 }
  72
  73 void DolphinMainWindowTest::testActiveViewAfterClosingSplitView_data()
  74 {
  75     QTest::addColumn<bool>("closeLeftView");
  76
  77     QTest::newRow("close left view") << true;
  78     QTest::newRow("close right view") << false;
  79 }
  80
  81 void DolphinMainWindowTest::testActiveViewAfterClosingSplitView()
  82 {
  83     m_mainWindow->openDirectories({ QUrl::fromLocalFile(QDir::homePath()) }, false);
  84     m_mainWindow->show();
  85     QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow.data()));
  86     QVERIFY(m_mainWindow->isVisible());
  87
  88     auto tabWidget = m_mainWindow->findChild<DolphinTabWidget*>("tabWidget");
  89     QVERIFY(tabWidget);
  90     QVERIFY(tabWidget->currentTabPage()->primaryViewContainer());
  91     QVERIFY(!tabWidget->currentTabPage()->secondaryViewContainer());
  92
  93     // Open split view.
  94     m_mainWindow->actionCollection()->action(QStringLiteral("split_view"))->trigger();
  95     QVERIFY(tabWidget->currentTabPage()->splitViewEnabled());
  96     QVERIFY(tabWidget->currentTabPage()->secondaryViewContainer());
  97
  98     // Make sure the right view is the active one.
  99     auto leftViewContainer = tabWidget->currentTabPage()->primaryViewContainer();
 100     auto rightViewContainer = tabWidget->currentTabPage()->secondaryViewContainer();
 101     QVERIFY(!leftViewContainer->isActive());
 102     QVERIFY(rightViewContainer->isActive());
 103
 104     QFETCH(bool, closeLeftView);
 105     if (closeLeftView) {
 106         // Activate left view.
 107         leftViewContainer->setActive(true);
 108         QVERIFY(leftViewContainer->isActive());
 109         QVERIFY(!rightViewContainer->isActive());
 110
 111         // Close left view. The secondary view (which was on the right) will become the primary one and must be active.
 112         m_mainWindow->actionCollection()->action(QStringLiteral("split_view"))->trigger();
 113         QVERIFY(!leftViewContainer->isActive());
 114         QVERIFY(rightViewContainer->isActive());
 115         QCOMPARE(rightViewContainer, tabWidget->currentTabPage()->activeViewContainer());
 116     } else {
 117         // Close right view. The left view will become active.
 118         m_mainWindow->actionCollection()->action(QStringLiteral("split_view"))->trigger();
 119         QVERIFY(leftViewContainer->isActive());
 120         QVERIFY(!rightViewContainer->isActive());
 121         QCOMPARE(leftViewContainer, tabWidget->currentTabPage()->activeViewContainer());
 122     }
 123 }
 124
 125 // Test case for bug #385111
 126 void DolphinMainWindowTest::testUpdateWindowTitleAfterClosingSplitView()
 127 {
 128     m_mainWindow->openDirectories({ QUrl::fromLocalFile(QDir::homePath()) }, false);
 129     m_mainWindow->show();
 130     QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow.data()));
 131     QVERIFY(m_mainWindow->isVisible());
 132
 133     auto tabWidget = m_mainWindow->findChild<DolphinTabWidget*>("tabWidget");
 134     QVERIFY(tabWidget);
 135     QVERIFY(tabWidget->currentTabPage()->primaryViewContainer());
 136     QVERIFY(!tabWidget->currentTabPage()->secondaryViewContainer());
 137
 138     // Open split view.
 139     m_mainWindow->actionCollection()->action(QStringLiteral("split_view"))->trigger();
 140     QVERIFY(tabWidget->currentTabPage()->splitViewEnabled());
 141     QVERIFY(tabWidget->currentTabPage()->secondaryViewContainer());
 142
 143     // Make sure the right view is the active one.
 144     auto leftViewContainer = tabWidget->currentTabPage()->primaryViewContainer();
 145     auto rightViewContainer = tabWidget->currentTabPage()->secondaryViewContainer();
 146     QVERIFY(!leftViewContainer->isActive());
 147     QVERIFY(rightViewContainer->isActive());
 148
 149     // Activate left view.
 150     leftViewContainer->setActive(true);
 151     QVERIFY(leftViewContainer->isActive());
 152     QVERIFY(!rightViewContainer->isActive());
 153
 154     // Close split view. The secondary view (which was on the right) will become the primary one and must be active.
 155     m_mainWindow->actionCollection()->action(QStringLiteral("split_view"))->trigger();
 156     QVERIFY(!leftViewContainer->isActive());
 157     QVERIFY(rightViewContainer->isActive());
 158     QCOMPARE(rightViewContainer, tabWidget->currentTabPage()->activeViewContainer());
 159
 160     // Change URL and make sure we emit the currentUrlChanged signal (which triggers the window title update).
 161     QSignalSpy currentUrlChangedSpy(tabWidget, &DolphinTabWidget::currentUrlChanged);
 162     tabWidget->currentTabPage()->activeViewContainer()->setUrl(QUrl::fromLocalFile(QDir::rootPath()));
 163     QCOMPARE(currentUrlChangedSpy.count(), 1);
 164 }
 165
 166 QTEST_MAIN(DolphinMainWindowTest)
 167
 168 #include "dolphinmainwindowtest.moc"