]> cloud.milkyroute.net Git - dolphin.git/blob - src/tests/dolphinmainwindowtest.cpp
Add clang-format and format code as in Frameworks
[dolphin.git] / src / tests / dolphinmainwindowtest.cpp
1 /*
2 * SPDX-FileCopyrightText: 2017 Elvis Angelaccio <elvis.angelaccio@kde.org>
3 *
4 * SPDX-License-Identifier: GPL-2.0-or-later
5 */
6
7 #include "dolphinmainwindow.h"
8 #include "dolphinnewfilemenu.h"
9 #include "dolphintabpage.h"
10 #include "dolphintabwidget.h"
11 #include "dolphinviewcontainer.h"
12 #include "kitemviews/kitemlistcontainer.h"
13 #include "testdir.h"
14
15 #include <KActionCollection>
16
17 #include <QScopedPointer>
18 #include <QSignalSpy>
19 #include <QStandardPaths>
20 #include <QTest>
21
22 class DolphinMainWindowTest : public QObject
23 {
24 Q_OBJECT
25
26 private Q_SLOTS:
27 void initTestCase();
28 void init();
29 void testClosingTabsWithSearchBoxVisible();
30 void testActiveViewAfterClosingSplitView_data();
31 void testActiveViewAfterClosingSplitView();
32 void testUpdateWindowTitleAfterClosingSplitView();
33 void testUpdateWindowTitleAfterChangingSplitView();
34 void testOpenInNewTabTitle();
35 void testNewFileMenuEnabled_data();
36 void testNewFileMenuEnabled();
37 void testWindowTitle_data();
38 void testWindowTitle();
39 void testPlacesPanelWidthResistance();
40 void testGoActions();
41 void cleanupTestCase();
42
43 private:
44 QScopedPointer<DolphinMainWindow> m_mainWindow;
45 };
46
47 void DolphinMainWindowTest::initTestCase()
48 {
49 QStandardPaths::setTestModeEnabled(true);
50 }
51
52 void DolphinMainWindowTest::init()
53 {
54 m_mainWindow.reset(new DolphinMainWindow());
55 }
56
57 // See https://bugs.kde.org/show_bug.cgi?id=379135
58 void DolphinMainWindowTest::testClosingTabsWithSearchBoxVisible()
59 {
60 m_mainWindow->openDirectories({QUrl::fromLocalFile(QDir::homePath())}, false);
61 m_mainWindow->show();
62 // Without this call the searchbox doesn't get FocusIn events.
63 QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow.data()));
64 QVERIFY(m_mainWindow->isVisible());
65
66 auto tabWidget = m_mainWindow->findChild<DolphinTabWidget *>("tabWidget");
67 QVERIFY(tabWidget);
68
69 // Show search box on first tab.
70 tabWidget->currentTabPage()->activeViewContainer()->setSearchModeEnabled(true);
71
72 tabWidget->openNewActivatedTab(QUrl::fromLocalFile(QDir::homePath()));
73 QCOMPARE(tabWidget->count(), 2);
74
75 // Triggers the crash in bug #379135.
76 tabWidget->closeTab();
77 QCOMPARE(tabWidget->count(), 1);
78 }
79
80 void DolphinMainWindowTest::testActiveViewAfterClosingSplitView_data()
81 {
82 QTest::addColumn<bool>("closeLeftView");
83
84 QTest::newRow("close left view") << true;
85 QTest::newRow("close right view") << false;
86 }
87
88 void DolphinMainWindowTest::testActiveViewAfterClosingSplitView()
89 {
90 m_mainWindow->openDirectories({QUrl::fromLocalFile(QDir::homePath())}, false);
91 m_mainWindow->show();
92 QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow.data()));
93 QVERIFY(m_mainWindow->isVisible());
94
95 auto tabWidget = m_mainWindow->findChild<DolphinTabWidget *>("tabWidget");
96 QVERIFY(tabWidget);
97 QVERIFY(tabWidget->currentTabPage()->primaryViewContainer());
98 QVERIFY(!tabWidget->currentTabPage()->secondaryViewContainer());
99
100 // Open split view.
101 m_mainWindow->actionCollection()->action(QStringLiteral("split_view"))->trigger();
102 QVERIFY(tabWidget->currentTabPage()->splitViewEnabled());
103 QVERIFY(tabWidget->currentTabPage()->secondaryViewContainer());
104
105 // Make sure the right view is the active one.
106 auto leftViewContainer = tabWidget->currentTabPage()->primaryViewContainer();
107 auto rightViewContainer = tabWidget->currentTabPage()->secondaryViewContainer();
108 QVERIFY(!leftViewContainer->isActive());
109 QVERIFY(rightViewContainer->isActive());
110
111 QFETCH(bool, closeLeftView);
112 if (closeLeftView) {
113 // Activate left view.
114 leftViewContainer->setActive(true);
115 QVERIFY(leftViewContainer->isActive());
116 QVERIFY(!rightViewContainer->isActive());
117
118 // Close left view. The secondary view (which was on the right) will become the primary one and must be active.
119 m_mainWindow->actionCollection()->action(QStringLiteral("split_view"))->trigger();
120 QVERIFY(!leftViewContainer->isActive());
121 QVERIFY(rightViewContainer->isActive());
122 QCOMPARE(rightViewContainer, tabWidget->currentTabPage()->activeViewContainer());
123 } else {
124 // Close right view. The left view will become active.
125 m_mainWindow->actionCollection()->action(QStringLiteral("split_view"))->trigger();
126 QVERIFY(leftViewContainer->isActive());
127 QVERIFY(!rightViewContainer->isActive());
128 QCOMPARE(leftViewContainer, tabWidget->currentTabPage()->activeViewContainer());
129 }
130 }
131
132 // Test case for bug #385111
133 void DolphinMainWindowTest::testUpdateWindowTitleAfterClosingSplitView()
134 {
135 m_mainWindow->openDirectories({QUrl::fromLocalFile(QDir::homePath())}, false);
136 m_mainWindow->show();
137 QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow.data()));
138 QVERIFY(m_mainWindow->isVisible());
139
140 auto tabWidget = m_mainWindow->findChild<DolphinTabWidget *>("tabWidget");
141 QVERIFY(tabWidget);
142 QVERIFY(tabWidget->currentTabPage()->primaryViewContainer());
143 QVERIFY(!tabWidget->currentTabPage()->secondaryViewContainer());
144
145 // Open split view.
146 m_mainWindow->actionCollection()->action(QStringLiteral("split_view"))->trigger();
147 QVERIFY(tabWidget->currentTabPage()->splitViewEnabled());
148 QVERIFY(tabWidget->currentTabPage()->secondaryViewContainer());
149
150 // Make sure the right view is the active one.
151 auto leftViewContainer = tabWidget->currentTabPage()->primaryViewContainer();
152 auto rightViewContainer = tabWidget->currentTabPage()->secondaryViewContainer();
153 QVERIFY(!leftViewContainer->isActive());
154 QVERIFY(rightViewContainer->isActive());
155
156 // Activate left view.
157 leftViewContainer->setActive(true);
158 QVERIFY(leftViewContainer->isActive());
159 QVERIFY(!rightViewContainer->isActive());
160
161 // Close split view. The secondary view (which was on the right) will become the primary one and must be active.
162 m_mainWindow->actionCollection()->action(QStringLiteral("split_view"))->trigger();
163 QVERIFY(!leftViewContainer->isActive());
164 QVERIFY(rightViewContainer->isActive());
165 QCOMPARE(rightViewContainer, tabWidget->currentTabPage()->activeViewContainer());
166
167 // Change URL and make sure we emit the currentUrlChanged signal (which triggers the window title update).
168 QSignalSpy currentUrlChangedSpy(tabWidget, &DolphinTabWidget::currentUrlChanged);
169 tabWidget->currentTabPage()->activeViewContainer()->setUrl(QUrl::fromLocalFile(QDir::rootPath()));
170 QCOMPARE(currentUrlChangedSpy.count(), 1);
171 }
172
173 // Test case for bug #402641
174 void DolphinMainWindowTest::testUpdateWindowTitleAfterChangingSplitView()
175 {
176 m_mainWindow->openDirectories({QUrl::fromLocalFile(QDir::homePath())}, false);
177 m_mainWindow->show();
178 QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow.data()));
179 QVERIFY(m_mainWindow->isVisible());
180
181 auto tabWidget = m_mainWindow->findChild<DolphinTabWidget *>("tabWidget");
182 QVERIFY(tabWidget);
183
184 // Open split view.
185 m_mainWindow->actionCollection()->action(QStringLiteral("split_view"))->trigger();
186 QVERIFY(tabWidget->currentTabPage()->splitViewEnabled());
187
188 auto leftViewContainer = tabWidget->currentTabPage()->primaryViewContainer();
189 auto rightViewContainer = tabWidget->currentTabPage()->secondaryViewContainer();
190
191 // Store old window title.
192 const auto oldTitle = m_mainWindow->windowTitle();
193
194 // Change URL in the right view and make sure the title gets updated.
195 rightViewContainer->setUrl(QUrl::fromLocalFile(QDir::rootPath()));
196 QVERIFY(m_mainWindow->windowTitle() != oldTitle);
197
198 // Activate back the left view and check whether the old title gets restored.
199 leftViewContainer->setActive(true);
200 QCOMPARE(m_mainWindow->windowTitle(), oldTitle);
201 }
202
203 // Test case for bug #397910
204 void DolphinMainWindowTest::testOpenInNewTabTitle()
205 {
206 m_mainWindow->openDirectories({QUrl::fromLocalFile(QDir::homePath())}, false);
207 m_mainWindow->show();
208 QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow.data()));
209 QVERIFY(m_mainWindow->isVisible());
210
211 auto tabWidget = m_mainWindow->findChild<DolphinTabWidget *>("tabWidget");
212 QVERIFY(tabWidget);
213
214 tabWidget->openNewTab(QUrl::fromLocalFile(QDir::tempPath()));
215 QCOMPARE(tabWidget->count(), 2);
216 QVERIFY(tabWidget->tabText(0) != tabWidget->tabText(1));
217 if (!tabWidget->tabIcon(0).isNull() && !tabWidget->tabIcon(1).isNull()) {
218 QCOMPARE(QStringLiteral("inode-directory"), tabWidget->tabIcon(0).name());
219 QCOMPARE(QStringLiteral("inode-directory"), tabWidget->tabIcon(1).name());
220 }
221 }
222
223 void DolphinMainWindowTest::testNewFileMenuEnabled_data()
224 {
225 QTest::addColumn<QUrl>("activeViewUrl");
226 QTest::addColumn<bool>("expectedEnabled");
227
228 QTest::newRow("home") << QUrl::fromLocalFile(QDir::homePath()) << true;
229 QTest::newRow("root") << QUrl::fromLocalFile(QDir::rootPath()) << false;
230 QTest::newRow("trash") << QUrl::fromUserInput(QStringLiteral("trash:/")) << false;
231 }
232
233 void DolphinMainWindowTest::testNewFileMenuEnabled()
234 {
235 QFETCH(QUrl, activeViewUrl);
236 m_mainWindow->openDirectories({activeViewUrl}, false);
237 m_mainWindow->show();
238 QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow.data()));
239 QVERIFY(m_mainWindow->isVisible());
240
241 auto newFileMenu = m_mainWindow->findChild<DolphinNewFileMenu *>("new_menu");
242 QVERIFY(newFileMenu);
243
244 QFETCH(bool, expectedEnabled);
245 QTRY_COMPARE(newFileMenu->isEnabled(), expectedEnabled);
246 }
247
248 void DolphinMainWindowTest::testWindowTitle_data()
249 {
250 QTest::addColumn<QUrl>("activeViewUrl");
251 QTest::addColumn<QString>("expectedWindowTitle");
252
253 // TODO: this test should enforce the english locale.
254 QTest::newRow("home") << QUrl::fromLocalFile(QDir::homePath()) << QStringLiteral("Home");
255 QTest::newRow("home with trailing slash") << QUrl::fromLocalFile(QStringLiteral("%1/").arg(QDir::homePath())) << QStringLiteral("Home");
256 QTest::newRow("trash") << QUrl::fromUserInput(QStringLiteral("trash:/")) << QStringLiteral("Trash");
257 }
258
259 void DolphinMainWindowTest::testWindowTitle()
260 {
261 QFETCH(QUrl, activeViewUrl);
262 m_mainWindow->openDirectories({activeViewUrl}, false);
263 m_mainWindow->show();
264 QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow.data()));
265 QVERIFY(m_mainWindow->isVisible());
266
267 QFETCH(QString, expectedWindowTitle);
268 QCOMPARE(m_mainWindow->windowTitle(), expectedWindowTitle);
269 }
270
271 /**
272 * The places panel will resize itself if any of the other widgets requires too much horizontal space
273 * but a user never wants the size of the places panel to change unless they resized it themselves explicitly.
274 */
275 void DolphinMainWindowTest::testPlacesPanelWidthResistance()
276 {
277 m_mainWindow->openDirectories({QUrl::fromLocalFile(QDir::homePath())}, false);
278 m_mainWindow->show();
279 m_mainWindow->resize(800, m_mainWindow->height()); // make sure the size is sufficient so a places panel resize shouldn't be necessary.
280 QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow.data()));
281 QVERIFY(m_mainWindow->isVisible());
282
283 QWidget *placesPanel = reinterpret_cast<QWidget *>(m_mainWindow->m_placesPanel);
284 QVERIFY2(QTest::qWaitFor(
285 [&]() {
286 return placesPanel && placesPanel->isVisible() && placesPanel->width() > 0;
287 },
288 5000),
289 "The test couldn't be initialised properly. The places panel should be visible.");
290 QTest::qWait(100);
291 const int initialPlacesPanelWidth = placesPanel->width();
292
293 m_mainWindow->actionCollection()->action(QStringLiteral("split_view"))->trigger(); // enable split view (starts animation)
294 QTest::qWait(300); // wait for animation
295 QCOMPARE(placesPanel->width(), initialPlacesPanelWidth);
296
297 m_mainWindow->actionCollection()->action(QStringLiteral("show_filter_bar"))->trigger();
298 QCOMPARE(placesPanel->width(), initialPlacesPanelWidth);
299
300 // Make all selection mode bars appear and test for each that this doesn't affect the places panel's width.
301 // One of the bottom bars (SelectionMode::BottomBar::GeneralContents) only shows up when at least one item is selected so we do that before we begin iterating.
302 m_mainWindow->actionCollection()->action(KStandardAction::name(KStandardAction::SelectAll))->trigger();
303 for (int selectionModeStates = SelectionMode::BottomBar::CopyContents; selectionModeStates != SelectionMode::BottomBar::RenameContents;
304 selectionModeStates++) {
305 const auto contents = static_cast<SelectionMode::BottomBar::Contents>(selectionModeStates);
306 m_mainWindow->slotSetSelectionMode(true, contents);
307 QTest::qWait(20); // give time for a paint/resize
308 QCOMPARE(placesPanel->width(), initialPlacesPanelWidth);
309 }
310
311 m_mainWindow->actionCollection()->action(KStandardAction::name(KStandardAction::Find))->trigger();
312 QCOMPARE(placesPanel->width(), initialPlacesPanelWidth);
313
314 #if HAVE_BALOO
315 m_mainWindow->actionCollection()->action(QStringLiteral("show_information_panel"))->setChecked(true); // toggle visible
316 QCOMPARE(placesPanel->width(), initialPlacesPanelWidth);
317 #endif
318
319 #if HAVE_TERMINAL
320 m_mainWindow->actionCollection()->action(QStringLiteral("show_terminal_panel"))->setChecked(true); // toggle visible
321 QCOMPARE(placesPanel->width(), initialPlacesPanelWidth);
322 #endif
323
324 m_mainWindow->actionCollection()->action(QStringLiteral("split_view"))->trigger(); // disable split view (starts animation)
325 QCOMPARE(placesPanel->width(), initialPlacesPanelWidth);
326
327 #if HAVE_BALOO
328 m_mainWindow->actionCollection()->action(QStringLiteral("show_information_panel"))->trigger(); // toggle invisible
329 QCOMPARE(placesPanel->width(), initialPlacesPanelWidth);
330 #endif
331
332 #if HAVE_TERMINAL
333 m_mainWindow->actionCollection()->action(QStringLiteral("show_terminal_panel"))->trigger(); // toggle invisible
334 QCOMPARE(placesPanel->width(), initialPlacesPanelWidth);
335 #endif
336
337 m_mainWindow->showMaximized();
338 QCOMPARE(placesPanel->width(), initialPlacesPanelWidth);
339
340 QTest::qWait(300); // wait for split view closing animation
341 QCOMPARE(placesPanel->width(), initialPlacesPanelWidth);
342 }
343
344 void DolphinMainWindowTest::testGoActions()
345 {
346 QScopedPointer<TestDir> testDir{new TestDir()};
347 testDir->createDir("a");
348 testDir->createDir("b");
349 testDir->createDir("b/b-1");
350 testDir->createFile("b/b-2");
351 testDir->createDir("c");
352 QUrl childDirUrl(QDir::cleanPath(testDir->url().toString() + "/b"));
353 m_mainWindow->openDirectories({childDirUrl}, false); // Open "b" dir
354 m_mainWindow->show();
355 QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow.data()));
356 QVERIFY(m_mainWindow->isVisible());
357 QVERIFY(!m_mainWindow->actionCollection()->action(KStandardAction::name(KStandardAction::Forward))->isEnabled());
358
359 m_mainWindow->actionCollection()->action(KStandardAction::name(KStandardAction::Up))->trigger();
360 /**
361 * Now, after going "up" in the file hierarchy (to "testDir"), the folder one has emerged from ("b") should have keyboard focus.
362 * This is especially important when a user wants to peek into multiple folders in quick succession.
363 */
364 QSignalSpy spyDirectoryLoadingCompleted(m_mainWindow->m_activeViewContainer->view(), &DolphinView::directoryLoadingCompleted);
365 QVERIFY(spyDirectoryLoadingCompleted.wait());
366 QVERIFY(QTest::qWaitFor([&]() {
367 return !m_mainWindow->actionCollection()->action(QStringLiteral("stop"))->isEnabled();
368 })); // "Stop" command should be disabled because it finished loading
369 QTest::qWait(500); // Somehow the item we emerged from doesn't have keyboard focus yet if we don't wait a split second.
370 const QUrl parentDirUrl = m_mainWindow->activeViewContainer()->url();
371 QVERIFY(parentDirUrl != childDirUrl);
372
373 // The item we just emerged from should now have keyboard focus but this doesn't necessarily mean that it is selected.
374 // To test if it has keyboard focus, we press "Down" to select "c" below and then "Up" so the folder "b" we just emerged from is actually selected.
375 m_mainWindow->actionCollection()->action(QStringLiteral("compact"))->trigger();
376 QTest::keyClick(m_mainWindow->activeViewContainer()->view()->m_container, Qt::Key::Key_Down, Qt::NoModifier);
377 QCOMPARE(m_mainWindow->m_activeViewContainer->view()->selectedItems().count(), 1);
378 QTest::keyClick(m_mainWindow->activeViewContainer()->view()->m_container, Qt::Key::Key_Up, Qt::NoModifier);
379 QCOMPARE(m_mainWindow->m_activeViewContainer->view()->selectedItems().count(), 1);
380 QTest::keyClick(m_mainWindow->activeViewContainer()->view()->m_container, Qt::Key::Key_Enter, Qt::NoModifier);
381 QVERIFY(spyDirectoryLoadingCompleted.wait());
382 QCOMPARE(m_mainWindow->activeViewContainer()->url(), childDirUrl);
383 QVERIFY(m_mainWindow->isUrlOpen(childDirUrl.toString()));
384
385 // Go back to the parent folder
386 m_mainWindow->actionCollection()->action(KStandardAction::name(KStandardAction::Back))->trigger();
387 QVERIFY(spyDirectoryLoadingCompleted.wait());
388 QTest::qWait(100); // Somehow the item we emerged from doesn't have keyboard focus yet if we don't wait a split second.
389 QCOMPARE(m_mainWindow->activeViewContainer()->url(), parentDirUrl);
390 QVERIFY(m_mainWindow->isUrlOpen(parentDirUrl.toString()));
391
392 // Open a new tab for the "b" child dir and verify that this doesn't interfere with anything.
393 QTest::keyClick(m_mainWindow->activeViewContainer()->view()->m_container, Qt::Key::Key_Enter, Qt::ControlModifier); // Open new inactive tab
394 QVERIFY(m_mainWindow->m_tabWidget->count() == 2);
395 QCOMPARE(m_mainWindow->activeViewContainer()->url(), parentDirUrl);
396 QVERIFY(m_mainWindow->isUrlOpen(parentDirUrl.toString()));
397 QVERIFY(!m_mainWindow->actionCollection()->action(QStringLiteral("undo_close_tab"))->isEnabled());
398
399 // Go forward to the child folder.
400 m_mainWindow->actionCollection()->action(KStandardAction::name(KStandardAction::Forward))->trigger();
401 QVERIFY(spyDirectoryLoadingCompleted.wait());
402 QCOMPARE(m_mainWindow->activeViewContainer()->url(), childDirUrl);
403 QCOMPARE(m_mainWindow->m_activeViewContainer->view()->selectedItems().count(), 0); // There was no action in this view yet that would warrant a selection.
404
405 // Go back to the parent folder.
406 m_mainWindow->actionCollection()->action(KStandardAction::name(KStandardAction::Back))->trigger();
407 QVERIFY(spyDirectoryLoadingCompleted.wait());
408 QTest::qWait(100); // Somehow the item we emerged from doesn't have keyboard focus yet if we don't wait a split second.
409 QCOMPARE(m_mainWindow->activeViewContainer()->url(), parentDirUrl);
410 QVERIFY(m_mainWindow->isUrlOpen(parentDirUrl.toString()));
411
412 // Close current tab and see if the "go" actions are correctly disabled in the remaining tab that was never active until now and shows the "b" dir
413 m_mainWindow->actionCollection()->action(KStandardAction::name(KStandardAction::Close))->trigger(); // Close current tab
414 QVERIFY(m_mainWindow->m_tabWidget->count() == 1);
415 QCOMPARE(m_mainWindow->activeViewContainer()->url(), childDirUrl);
416 QCOMPARE(m_mainWindow->m_activeViewContainer->view()->selectedItems().count(), 0); // There was no action in this tab yet that would warrant a selection.
417 QVERIFY(!m_mainWindow->actionCollection()->action(KStandardAction::name(KStandardAction::Back))->isEnabled());
418 QVERIFY(!m_mainWindow->actionCollection()->action(KStandardAction::name(KStandardAction::Forward))->isEnabled());
419 QVERIFY(m_mainWindow->actionCollection()->action(QStringLiteral("undo_close_tab"))->isEnabled());
420 }
421
422 void DolphinMainWindowTest::cleanupTestCase()
423 {
424 m_mainWindow->showNormal();
425 m_mainWindow->actionCollection()->action(QStringLiteral("split_view"))->setChecked(false); // disable split view (starts animation)
426
427 #if HAVE_BALOO
428 m_mainWindow->actionCollection()->action(QStringLiteral("show_information_panel"))->setChecked(false); // hide panel
429 #endif
430
431 #if HAVE_TERMINAL
432 m_mainWindow->actionCollection()->action(QStringLiteral("show_terminal_panel"))->setChecked(false); // hide panel
433 #endif
434
435 // Quit Dolphin to save the hiding of panels and make sure that normal Quit doesn't crash.
436 m_mainWindow->actionCollection()->action(KStandardAction::name(KStandardAction::Quit))->trigger();
437 }
438
439 QTEST_MAIN(DolphinMainWindowTest)
440
441 #include "dolphinmainwindowtest.moc"