2 * SPDX-FileCopyrightText: 2017 Elvis Angelaccio <elvis.angelaccio@kde.org>
4 * SPDX-License-Identifier: GPL-2.0-or-later
7 #include "dolphinmainwindow.h"
8 #include "dolphinnewfilemenu.h"
9 #include "dolphintabpage.h"
10 #include "dolphintabwidget.h"
11 #include "dolphinviewcontainer.h"
12 #include "kitemviews/kitemlistcontainer.h"
15 #include <KActionCollection>
17 #include <QScopedPointer>
19 #include <QStandardPaths>
22 class DolphinMainWindowTest
: public QObject
29 void testClosingTabsWithSearchBoxVisible();
30 void testActiveViewAfterClosingSplitView_data();
31 void testActiveViewAfterClosingSplitView();
32 void testUpdateWindowTitleAfterClosingSplitView();
33 void testUpdateWindowTitleAfterChangingSplitView();
34 void testOpenInNewTabTitle();
35 void testNewFileMenuEnabled_data();
36 void testNewFileMenuEnabled();
37 void testWindowTitle_data();
38 void testWindowTitle();
39 void testPlacesPanelWidthResistance();
41 void cleanupTestCase();
45 QScopedPointer
<DolphinMainWindow
> m_mainWindow
;
48 void DolphinMainWindowTest::initTestCase()
50 QStandardPaths::setTestModeEnabled(true);
53 void DolphinMainWindowTest::init()
55 m_mainWindow
.reset(new DolphinMainWindow());
58 // See https://bugs.kde.org/show_bug.cgi?id=379135
59 void DolphinMainWindowTest::testClosingTabsWithSearchBoxVisible()
61 m_mainWindow
->openDirectories({ QUrl::fromLocalFile(QDir::homePath()) }, false);
63 // Without this call the searchbox doesn't get FocusIn events.
64 QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow
.data()));
65 QVERIFY(m_mainWindow
->isVisible());
67 auto tabWidget
= m_mainWindow
->findChild
<DolphinTabWidget
*>("tabWidget");
70 // Show search box on first tab.
71 tabWidget
->currentTabPage()->activeViewContainer()->setSearchModeEnabled(true);
73 tabWidget
->openNewActivatedTab(QUrl::fromLocalFile(QDir::homePath()));
74 QCOMPARE(tabWidget
->count(), 2);
76 // Triggers the crash in bug #379135.
77 tabWidget
->closeTab();
78 QCOMPARE(tabWidget
->count(), 1);
81 void DolphinMainWindowTest::testActiveViewAfterClosingSplitView_data()
83 QTest::addColumn
<bool>("closeLeftView");
85 QTest::newRow("close left view") << true;
86 QTest::newRow("close right view") << false;
89 void DolphinMainWindowTest::testActiveViewAfterClosingSplitView()
91 m_mainWindow
->openDirectories({ QUrl::fromLocalFile(QDir::homePath()) }, false);
93 QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow
.data()));
94 QVERIFY(m_mainWindow
->isVisible());
96 auto tabWidget
= m_mainWindow
->findChild
<DolphinTabWidget
*>("tabWidget");
98 QVERIFY(tabWidget
->currentTabPage()->primaryViewContainer());
99 QVERIFY(!tabWidget
->currentTabPage()->secondaryViewContainer());
102 m_mainWindow
->actionCollection()->action(QStringLiteral("split_view"))->trigger();
103 QVERIFY(tabWidget
->currentTabPage()->splitViewEnabled());
104 QVERIFY(tabWidget
->currentTabPage()->secondaryViewContainer());
106 // Make sure the right view is the active one.
107 auto leftViewContainer
= tabWidget
->currentTabPage()->primaryViewContainer();
108 auto rightViewContainer
= tabWidget
->currentTabPage()->secondaryViewContainer();
109 QVERIFY(!leftViewContainer
->isActive());
110 QVERIFY(rightViewContainer
->isActive());
112 QFETCH(bool, closeLeftView
);
114 // Activate left view.
115 leftViewContainer
->setActive(true);
116 QVERIFY(leftViewContainer
->isActive());
117 QVERIFY(!rightViewContainer
->isActive());
119 // Close left view. The secondary view (which was on the right) will become the primary one and must be active.
120 m_mainWindow
->actionCollection()->action(QStringLiteral("split_view"))->trigger();
121 QVERIFY(!leftViewContainer
->isActive());
122 QVERIFY(rightViewContainer
->isActive());
123 QCOMPARE(rightViewContainer
, tabWidget
->currentTabPage()->activeViewContainer());
125 // Close right view. The left view will become active.
126 m_mainWindow
->actionCollection()->action(QStringLiteral("split_view"))->trigger();
127 QVERIFY(leftViewContainer
->isActive());
128 QVERIFY(!rightViewContainer
->isActive());
129 QCOMPARE(leftViewContainer
, tabWidget
->currentTabPage()->activeViewContainer());
133 // Test case for bug #385111
134 void DolphinMainWindowTest::testUpdateWindowTitleAfterClosingSplitView()
136 m_mainWindow
->openDirectories({ QUrl::fromLocalFile(QDir::homePath()) }, false);
137 m_mainWindow
->show();
138 QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow
.data()));
139 QVERIFY(m_mainWindow
->isVisible());
141 auto tabWidget
= m_mainWindow
->findChild
<DolphinTabWidget
*>("tabWidget");
143 QVERIFY(tabWidget
->currentTabPage()->primaryViewContainer());
144 QVERIFY(!tabWidget
->currentTabPage()->secondaryViewContainer());
147 m_mainWindow
->actionCollection()->action(QStringLiteral("split_view"))->trigger();
148 QVERIFY(tabWidget
->currentTabPage()->splitViewEnabled());
149 QVERIFY(tabWidget
->currentTabPage()->secondaryViewContainer());
151 // Make sure the right view is the active one.
152 auto leftViewContainer
= tabWidget
->currentTabPage()->primaryViewContainer();
153 auto rightViewContainer
= tabWidget
->currentTabPage()->secondaryViewContainer();
154 QVERIFY(!leftViewContainer
->isActive());
155 QVERIFY(rightViewContainer
->isActive());
157 // Activate left view.
158 leftViewContainer
->setActive(true);
159 QVERIFY(leftViewContainer
->isActive());
160 QVERIFY(!rightViewContainer
->isActive());
162 // Close split view. The secondary view (which was on the right) will become the primary one and must be active.
163 m_mainWindow
->actionCollection()->action(QStringLiteral("split_view"))->trigger();
164 QVERIFY(!leftViewContainer
->isActive());
165 QVERIFY(rightViewContainer
->isActive());
166 QCOMPARE(rightViewContainer
, tabWidget
->currentTabPage()->activeViewContainer());
168 // Change URL and make sure we emit the currentUrlChanged signal (which triggers the window title update).
169 QSignalSpy
currentUrlChangedSpy(tabWidget
, &DolphinTabWidget::currentUrlChanged
);
170 tabWidget
->currentTabPage()->activeViewContainer()->setUrl(QUrl::fromLocalFile(QDir::rootPath()));
171 QCOMPARE(currentUrlChangedSpy
.count(), 1);
174 // Test case for bug #402641
175 void DolphinMainWindowTest::testUpdateWindowTitleAfterChangingSplitView()
177 m_mainWindow
->openDirectories({ QUrl::fromLocalFile(QDir::homePath()) }, false);
178 m_mainWindow
->show();
179 QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow
.data()));
180 QVERIFY(m_mainWindow
->isVisible());
182 auto tabWidget
= m_mainWindow
->findChild
<DolphinTabWidget
*>("tabWidget");
186 m_mainWindow
->actionCollection()->action(QStringLiteral("split_view"))->trigger();
187 QVERIFY(tabWidget
->currentTabPage()->splitViewEnabled());
189 auto leftViewContainer
= tabWidget
->currentTabPage()->primaryViewContainer();
190 auto rightViewContainer
= tabWidget
->currentTabPage()->secondaryViewContainer();
192 // Store old window title.
193 const auto oldTitle
= m_mainWindow
->windowTitle();
195 // Change URL in the right view and make sure the title gets updated.
196 rightViewContainer
->setUrl(QUrl::fromLocalFile(QDir::rootPath()));
197 QVERIFY(m_mainWindow
->windowTitle() != oldTitle
);
199 // Activate back the left view and check whether the old title gets restored.
200 leftViewContainer
->setActive(true);
201 QCOMPARE(m_mainWindow
->windowTitle(), oldTitle
);
204 // Test case for bug #397910
205 void DolphinMainWindowTest::testOpenInNewTabTitle()
207 m_mainWindow
->openDirectories({ QUrl::fromLocalFile(QDir::homePath()) }, false);
208 m_mainWindow
->show();
209 QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow
.data()));
210 QVERIFY(m_mainWindow
->isVisible());
212 auto tabWidget
= m_mainWindow
->findChild
<DolphinTabWidget
*>("tabWidget");
215 tabWidget
->openNewTab(QUrl::fromLocalFile(QDir::tempPath()));
216 QCOMPARE(tabWidget
->count(), 2);
217 QVERIFY(tabWidget
->tabText(0) != tabWidget
->tabText(1));
218 if (!tabWidget
->tabIcon(0).isNull() && !tabWidget
->tabIcon(1).isNull()) {
219 QCOMPARE(QStringLiteral("inode-directory"), tabWidget
->tabIcon(0).name());
220 QCOMPARE(QStringLiteral("inode-directory"), tabWidget
->tabIcon(1).name());
224 void DolphinMainWindowTest::testNewFileMenuEnabled_data()
226 QTest::addColumn
<QUrl
>("activeViewUrl");
227 QTest::addColumn
<bool>("expectedEnabled");
229 QTest::newRow("home") << QUrl::fromLocalFile(QDir::homePath()) << true;
230 QTest::newRow("root") << QUrl::fromLocalFile(QDir::rootPath()) << false;
231 QTest::newRow("trash") << QUrl::fromUserInput(QStringLiteral("trash:/")) << false;
234 void DolphinMainWindowTest::testNewFileMenuEnabled()
236 QFETCH(QUrl
, activeViewUrl
);
237 m_mainWindow
->openDirectories({ activeViewUrl
}, false);
238 m_mainWindow
->show();
239 QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow
.data()));
240 QVERIFY(m_mainWindow
->isVisible());
242 auto newFileMenu
= m_mainWindow
->findChild
<DolphinNewFileMenu
*>("new_menu");
243 QVERIFY(newFileMenu
);
245 QFETCH(bool, expectedEnabled
);
246 QTRY_COMPARE(newFileMenu
->isEnabled(), expectedEnabled
);
249 void DolphinMainWindowTest::testWindowTitle_data()
251 QTest::addColumn
<QUrl
>("activeViewUrl");
252 QTest::addColumn
<QString
>("expectedWindowTitle");
254 // TODO: this test should enforce the english locale.
255 QTest::newRow("home") << QUrl::fromLocalFile(QDir::homePath()) << QStringLiteral("Home");
256 QTest::newRow("home with trailing slash") << QUrl::fromLocalFile(QStringLiteral("%1/").arg(QDir::homePath())) << QStringLiteral("Home");
257 QTest::newRow("trash") << QUrl::fromUserInput(QStringLiteral("trash:/")) << QStringLiteral("Trash");
260 void DolphinMainWindowTest::testWindowTitle()
262 QFETCH(QUrl
, activeViewUrl
);
263 m_mainWindow
->openDirectories({ activeViewUrl
}, false);
264 m_mainWindow
->show();
265 QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow
.data()));
266 QVERIFY(m_mainWindow
->isVisible());
268 QFETCH(QString
, expectedWindowTitle
);
269 QCOMPARE(m_mainWindow
->windowTitle(), expectedWindowTitle
);
273 * The places panel will resize itself if any of the other widgets requires too much horizontal space
274 * but a user never wants the size of the places panel to change unless they resized it themselves explicitly.
276 void DolphinMainWindowTest::testPlacesPanelWidthResistance()
278 m_mainWindow
->openDirectories({ QUrl::fromLocalFile(QDir::homePath()) }, false);
279 m_mainWindow
->show();
280 m_mainWindow
->resize(800, m_mainWindow
->height()); // make sure the size is sufficient so a places panel resize shouldn't be necessary.
281 QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow
.data()));
282 QVERIFY(m_mainWindow
->isVisible());
284 QWidget
*placesPanel
= reinterpret_cast<QWidget
*>(m_mainWindow
->m_placesPanel
);
285 QVERIFY2(QTest::qWaitFor([&](){ return placesPanel
&& placesPanel
->isVisible() && placesPanel
->width() > 0; }, 5000), "The test couldn't be initialised properly. The places panel should be visible.");
287 const int initialPlacesPanelWidth
= placesPanel
->width();
289 m_mainWindow
->actionCollection()->action(QStringLiteral("split_view"))->trigger(); // enable split view (starts animation)
290 QTest::qWait(300); // wait for animation
291 QCOMPARE(placesPanel
->width(), initialPlacesPanelWidth
);
293 m_mainWindow
->actionCollection()->action(QStringLiteral("show_filter_bar"))->trigger();
294 QCOMPARE(placesPanel
->width(), initialPlacesPanelWidth
);
296 // Make all selection mode bars appear and test for each that this doesn't affect the places panel's width.
297 // One of the bottom bars (SelectionMode::BottomBar::GeneralContents) only shows up when at least one item is selected so we do that before we begin iterating.
298 m_mainWindow
->actionCollection()->action(KStandardAction::name(KStandardAction::SelectAll
))->trigger();
299 for (int selectionModeStates
= SelectionMode::BottomBar::CopyContents
; selectionModeStates
!= SelectionMode::BottomBar::RenameContents
; selectionModeStates
++) {
300 const auto contents
= static_cast<SelectionMode::BottomBar::Contents
>(selectionModeStates
);
301 m_mainWindow
->slotSetSelectionMode(true, contents
);
302 QTest::qWait(20); // give time for a paint/resize
303 QCOMPARE(placesPanel
->width(), initialPlacesPanelWidth
);
306 m_mainWindow
->actionCollection()->action(KStandardAction::name(KStandardAction::Find
))->trigger();
307 QCOMPARE(placesPanel
->width(), initialPlacesPanelWidth
);
310 m_mainWindow
->actionCollection()->action(QStringLiteral("show_information_panel"))->setChecked(true); // toggle visible
311 QCOMPARE(placesPanel
->width(), initialPlacesPanelWidth
);
315 m_mainWindow
->actionCollection()->action(QStringLiteral("show_terminal_panel"))->setChecked(true); // toggle visible
316 QCOMPARE(placesPanel
->width(), initialPlacesPanelWidth
);
319 m_mainWindow
->actionCollection()->action(QStringLiteral("split_view"))->trigger(); // disable split view (starts animation)
320 QCOMPARE(placesPanel
->width(), initialPlacesPanelWidth
);
323 m_mainWindow
->actionCollection()->action(QStringLiteral("show_information_panel"))->trigger(); // toggle invisible
324 QCOMPARE(placesPanel
->width(), initialPlacesPanelWidth
);
328 m_mainWindow
->actionCollection()->action(QStringLiteral("show_terminal_panel"))->trigger(); // toggle invisible
329 QCOMPARE(placesPanel
->width(), initialPlacesPanelWidth
);
332 m_mainWindow
->showMaximized();
333 QCOMPARE(placesPanel
->width(), initialPlacesPanelWidth
);
335 QTest::qWait(300); // wait for split view closing animation
336 QCOMPARE(placesPanel
->width(), initialPlacesPanelWidth
);
339 void DolphinMainWindowTest::testGoActions()
341 QScopedPointer
<TestDir
> testDir
{new TestDir()};
342 testDir
->createDir("a");
343 testDir
->createDir("b");
344 testDir
->createDir("b/b-1");
345 testDir
->createFile("b/b-2");
346 testDir
->createDir("c");
347 QUrl
childDirUrl(QDir::cleanPath(testDir
->url().toString() + "/b"));
348 m_mainWindow
->openDirectories({ childDirUrl
}, false); // Open "b" dir
349 m_mainWindow
->show();
350 QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow
.data()));
351 QVERIFY(m_mainWindow
->isVisible());
352 QVERIFY(!m_mainWindow
->actionCollection()->action(KStandardAction::name(KStandardAction::Forward
))->isEnabled());
354 m_mainWindow
->actionCollection()->action(KStandardAction::name(KStandardAction::Up
))->trigger();
356 * Now, after going "up" in the file hierarchy (to "testDir"), the folder one has emerged from ("b") should have keyboard focus.
357 * This is especially important when a user wants to peek into multiple folders in quick succession.
359 QSignalSpy
spyDirectoryLoadingCompleted(m_mainWindow
->m_activeViewContainer
->view(), &DolphinView::directoryLoadingCompleted
);
360 QVERIFY(spyDirectoryLoadingCompleted
.wait());
361 QVERIFY(QTest::qWaitFor([&](){ return !m_mainWindow
->actionCollection()->action(QStringLiteral("stop"))->isEnabled(); })); // "Stop" command should be disabled because it finished loading
362 QTest::qWait(500); // Somehow the item we emerged from doesn't have keyboard focus yet if we don't wait a split second.
363 const QUrl parentDirUrl
= m_mainWindow
->activeViewContainer()->url();
364 QVERIFY(parentDirUrl
!= childDirUrl
);
366 // The item we just emerged from should now have keyboard focus but this doesn't necessarily mean that it is selected.
367 // To test if it has keyboard focus, we press "Down" to select "c" below and then "Up" so the folder "b" we just emerged from is actually selected.
368 m_mainWindow
->actionCollection()->action(QStringLiteral("compact"))->trigger();
369 QTest::keyClick(m_mainWindow
->activeViewContainer()->view()->m_container
, Qt::Key::Key_Down
, Qt::NoModifier
);
370 QCOMPARE(m_mainWindow
->m_activeViewContainer
->view()->selectedItems().count(), 1);
371 QTest::keyClick(m_mainWindow
->activeViewContainer()->view()->m_container
, Qt::Key::Key_Up
, Qt::NoModifier
);
372 QCOMPARE(m_mainWindow
->m_activeViewContainer
->view()->selectedItems().count(), 1);
373 QTest::keyClick(m_mainWindow
->activeViewContainer()->view()->m_container
, Qt::Key::Key_Enter
, Qt::NoModifier
);
374 QVERIFY(spyDirectoryLoadingCompleted
.wait());
375 QCOMPARE(m_mainWindow
->activeViewContainer()->url(), childDirUrl
);
376 QVERIFY(m_mainWindow
->isUrlOpen(childDirUrl
.toString()));
378 // Go back to the parent folder
379 m_mainWindow
->actionCollection()->action(KStandardAction::name(KStandardAction::Back
))->trigger();
380 QVERIFY(spyDirectoryLoadingCompleted
.wait());
381 QTest::qWait(100); // Somehow the item we emerged from doesn't have keyboard focus yet if we don't wait a split second.
382 QCOMPARE(m_mainWindow
->activeViewContainer()->url(), parentDirUrl
);
383 QVERIFY(m_mainWindow
->isUrlOpen(parentDirUrl
.toString()));
385 // Open a new tab for the "b" child dir and verify that this doesn't interfere with anything.
386 QTest::keyClick(m_mainWindow
->activeViewContainer()->view()->m_container
, Qt::Key::Key_Enter
, Qt::ControlModifier
); // Open new inactive tab
387 QVERIFY(m_mainWindow
->m_tabWidget
->count() == 2);
388 QCOMPARE(m_mainWindow
->activeViewContainer()->url(), parentDirUrl
);
389 QVERIFY(m_mainWindow
->isUrlOpen(parentDirUrl
.toString()));
390 QVERIFY(!m_mainWindow
->actionCollection()->action(QStringLiteral("undo_close_tab"))->isEnabled());
392 // Go forward to the child folder.
393 m_mainWindow
->actionCollection()->action(KStandardAction::name(KStandardAction::Forward
))->trigger();
394 QVERIFY(spyDirectoryLoadingCompleted
.wait());
395 QCOMPARE(m_mainWindow
->activeViewContainer()->url(), childDirUrl
);
396 QCOMPARE(m_mainWindow
->m_activeViewContainer
->view()->selectedItems().count(), 0); // There was no action in this view yet that would warrant a selection.
398 // Go back to the parent folder.
399 m_mainWindow
->actionCollection()->action(KStandardAction::name(KStandardAction::Back
))->trigger();
400 QVERIFY(spyDirectoryLoadingCompleted
.wait());
401 QTest::qWait(100); // Somehow the item we emerged from doesn't have keyboard focus yet if we don't wait a split second.
402 QCOMPARE(m_mainWindow
->activeViewContainer()->url(), parentDirUrl
);
403 QVERIFY(m_mainWindow
->isUrlOpen(parentDirUrl
.toString()));
405 // Close current tab and see if the "go" actions are correctly disabled in the remaining tab that was never active until now and shows the "b" dir
406 m_mainWindow
->actionCollection()->action(KStandardAction::name(KStandardAction::Close
))->trigger(); // Close current tab
407 QVERIFY(m_mainWindow
->m_tabWidget
->count() == 1);
408 QCOMPARE(m_mainWindow
->activeViewContainer()->url(), childDirUrl
);
409 QCOMPARE(m_mainWindow
->m_activeViewContainer
->view()->selectedItems().count(), 0); // There was no action in this tab yet that would warrant a selection.
410 QVERIFY(!m_mainWindow
->actionCollection()->action(KStandardAction::name(KStandardAction::Back
))->isEnabled());
411 QVERIFY(!m_mainWindow
->actionCollection()->action(KStandardAction::name(KStandardAction::Forward
))->isEnabled());
412 QVERIFY(m_mainWindow
->actionCollection()->action(QStringLiteral("undo_close_tab"))->isEnabled());
415 void DolphinMainWindowTest::cleanupTestCase()
417 m_mainWindow
->showNormal();
418 m_mainWindow
->actionCollection()->action(QStringLiteral("split_view"))->setChecked(false); // disable split view (starts animation)
421 m_mainWindow
->actionCollection()->action(QStringLiteral("show_information_panel"))->setChecked(false); // hide panel
425 m_mainWindow
->actionCollection()->action(QStringLiteral("show_terminal_panel"))->setChecked(false); // hide panel
428 // Quit Dolphin to save the hiding of panels and make sure that normal Quit doesn't crash.
429 m_mainWindow
->actionCollection()->action(KStandardAction::name(KStandardAction::Quit
))->trigger();
433 QTEST_MAIN(DolphinMainWindowTest
)
435 #include "dolphinmainwindowtest.moc"