]> cloud.milkyroute.net Git - dolphin.git/blob - src/THOUGHTS.zecke
Changes to Undo/Redo in regard to ProgressIndicator
[dolphin.git] / src / THOUGHTS.zecke
1 Zecke's Implementation Thoughts
2
3
4 Task: Kill the Dolphin Singleton
5 Reasoning: Have more than one Dolphin TLW
6 Approach:
7 1. Create DolphinApplication to hold all TLW's.
8 2. Make dolphin.h dolphomainwindow.h
9 3. Change the Views to have a DolphinMainWindow
10 parameter
11
12 Reasoning:
13 I find it more natural that the DolphinApplication
14 holds and controls the list of managed MainWindows and
15 will control the life time of them, specially deleting
16 them on exit.
17 The downside is that DolphinApplication and DolphinMainWindow
18 need to work together but this is managable
19
20 Making DolphinView::mainWindow() public. Most users of the
21 current Dolphin::mainView have a pointer to the current view
22 already. We could pass a second pointer for the mainwindow each
23 time but the same can be achieved by using the appropriate
24 DolphinView::mainWindow.
25 Another approach would be to ask the DolphinView to execute
26 actions on the MainWindow like it is done with declareViewActive
27 in DolphinView. I'm not entirely sure which one wins but currently
28 using mainWindow() does not show any negative impact.
29
30 2 times Dolphin::mainWin was used to check if the view is current.
31 this can be made a method of of the view
32
33 1 time we want the viewChanged signal of our mainwindow to update,
34 the UrlNavigator could connect a signal to a signal to allow this
35
36 12 times this was used to access the actionCollection